mirror of
https://github.com/nushell/nushell
synced 2025-01-10 04:09:09 +00:00
924986576d
# Description / User-Facing Changes Signals are no longer blocked for child processes launched from both interactive and non-interactive mode. The only exception is that `SIGTSTP`, `SIGTTIN`, and `SIGTTOU` remain blocked for child processes launched only from **interactive** mode. This is to help prevent nushell from getting into an unrecoverable state, since we don't support background jobs. Anyways, this fully fixes #9026. # Other Notes - Needs Rust version `>= 1.66` for a fix in `std::process::Command::spawn`, but it looks our current Rust version is way above this. - Uses `sigaction` instead of `signal`, since the behavior of `signal` can apparently differ across systems. Also, the `sigaction` man page says: > The sigaction() function supersedes the signal() function, and should be used in preference. Additionally, using both `sigaction` and `signal` is not recommended. Since we were already using `sigaction` in some places (and possibly some of our dependencies as well), this PR replaces all usages of `signal`. # Tests Might want to wait for #11178 for testing. |
||
|---|---|---|
| .. | ||
| complete.rs | ||
| exec.rs | ||
| mod.rs | ||
| nu_check.rs | ||
| ps.rs | ||
| registry_query.rs | ||
| run_external.rs | ||
| sys.rs | ||
| which_.rs | ||