mirror of
https://github.com/nushell/nushell
synced 2025-01-02 16:29:00 +00:00
32a53450a6
# Description Fixes: #7389 Make split row works more like python or rust, especially, when the input string stars/ends with separator, append a empty string to result. Here are examples: python: ```python In [6]: "\nasdf\nghi\n".split("\n") Out[6]: ['', 'asdf', 'ghi', ''] ``` rust: ```rust fn main() { let x = "\nabc\ndef\n"; let y = x.split("\n").collect::<Vec<&str>>(); println!("{:?}", y); // outputs: ["", "abc", "def", ""] } ``` # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. |
||
|---|---|---|
| .. | ||
| assets | ||
| proptest-regressions/format_conversions | ||
| src | ||
| tests | ||
| build.rs | ||
| Cargo.toml | ||
| LICENSE | ||