mirror of
https://github.com/nushell/nushell
synced 2024-12-30 15:03:25 +00:00
19beafa865
# Description Change behavior of block evaluation to not print result of intermediate commands. Previously result of every but last pipeline in a block was printed to stdout, and last one was returned  With this change results of intermediate pipelines are discarded after they finish and the last one is returned as before:  Now one should use `print` explicitly to print something to stdout  **Note, that this behavior is not limited to functions!** The scope of this change are all blocks. All of the below are executed as blocks and thus exibited this behavior in the same way:  With this change outputs for all types of blocks are cleaned:  # User-Facing Changes All types of blocks (function bodies, closures, `if` branches, `for` and `loop` bodies e.t.c.) no longer print result of intermediate pipelines. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
34 lines
927 B
Rust
34 lines
927 B
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn while_sum() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
"mut total = 0; mut x = 0; while $x <= 10 { $total = $total + $x; $x = $x + 1 }; $total"
|
|
);
|
|
|
|
assert_eq!(actual.out, "55");
|
|
}
|
|
|
|
#[test]
|
|
fn while_auto_print_in_each_iteration() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
"mut total = 0; while $total < 2 { $total = $total + 1; echo 1 }"
|
|
);
|
|
// Note: nu! macro auto replace "\n" and "\r\n" with ""
|
|
// so our output will be `11`
|
|
// that's ok, our main concern is it auto print value in each iteration.
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn while_break_on_external_failed() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
"mut total = 0; while $total < 2 { $total = $total + 1; print 1; nu --testbin fail }"
|
|
);
|
|
// Note: nu! macro auto replace "\n" and "\r\n" with ""
|
|
// so our output will be `1`
|
|
assert_eq!(actual.out, "1");
|
|
}
|