KITAGAWA Yasutaka 752d25b004 separate commandline into subcommands (#11877) ... <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Related issue and PR, #11825 #11864 This improves the signature of `commandline`. ## Before `commandline` returns different types depending on the flags and an aurgument. | command | input | output | description | |-----------------------------|---------|---------|----------------------------------------| | `commandline` | nothing | string | get current cursor line | | `commandline arg` | nothing | nothing | replace the cursor line with `arg` | | `commandline --append arg` | nothing | nothing | append `arg` to the end of cursor line | | `commandline --insert arg` | nothing | nothing | insert `arg` to the position of cursor | | `commandline --replace arg` | nothing | nothing | replace the cursor line with `arg` | | `commandline --cursor` | nothing | int | get current cursor position | | `commandline --cursor pos` | nothing | nothing | set cursor position to pos | | `commandline --cursor-end` | nothing | nothing | set cursor position to end | `help commandline` shows that `commandline` accepts string as pipeline input, but `commandline` ignores pipeline input. ``` Input/output types: ╭───┬─────────┬─────────╮ │ # │ input │ output │ ├───┼─────────┼─────────┤ │ 0 │ nothing │ nothing │ │ 1 │ string │ string │ ╰───┴─────────┴─────────╯ ``` 671bd08bcd/crates/nu-cli/src/commands/commandline.rs (L70) This is misleading. Due to the change #11864 , typecheck does not work well. https://github.com/nushell/nushell/pull/11864#discussion_r1491814054 ## After Separate `commandline` into subcommands so that each subcommands returns the same type for the same input type. | command | input | output | description | |----------------------------------|---------|---------|----------------------------------------| | `commandline` | nothing | string | get current cursor line | | `commandline edit arg` | nothing | nothing | replace the cursor line with `arg` | | `commandline edit --append arg` | nothing | nothing | append `arg` to the end of cursor line | | `commandline edit --insert arg` | nothing | nothing | insert `arg` to the position of cursor | | `commandline edit --replace arg` | nothing | nothing | replace the cursor line with `arg` | | `commandline get-cursor` | nothing | int | get current cursor position | | `commandline set-cursor pos` | nothing | nothing | set cursor position to pos | | `commandline set-cursor --end` | nothing | nothing | set cursor position to end | # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->		2024-02-18 16:15:59 -06:00
..
src	separate commandline into subcommands (#11877)	2024-02-18 16:15:59 -06:00
tests	Fix file completions which contains glob pattern (#11766)	2024-02-08 06:42:50 +08:00
Cargo.toml	Bump which from 5.0.0 to 6.0.0 (#11832)	2024-02-15 14:43:56 +00:00
LICENSE	Fix rest of license year ranges (#8727)	2023-04-04 09:03:29 +12:00