mirror of
https://github.com/nushell/nushell
synced 2025-01-09 03:39:03 +00:00
73f3c0b60b
# Description Adds support for the following operations on plugin custom values, in addition to `to_base_value` which was already present: - `follow_path_int()` - `follow_path_string()` - `partial_cmp()` - `operation()` - `Drop` (notification, if opted into with `CustomValue::notify_plugin_on_drop`) There are additionally customizable methods within the `Plugin` and `StreamingPlugin` traits for implementing these functions in a way that requires access to the plugin state, as a registered handle model such as might be used in a dataframes plugin would. `Value::append` was also changed to handle custom values correctly. # User-Facing Changes - Signature of `CustomValue::follow_path_string` and `CustomValue::follow_path_int` changed to give access to the span of the custom value itself, useful for some errors. - Plugins using custom values have to be recompiled because the engine will try to do custom value operations that aren't supported - Plugins can do more things 🎉 # Tests + Formatting Tests were added for all of the new custom values functionality. - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting - [ ] Document protocol reference `CustomValueOp` variants: - [ ] `FollowPathInt` - [ ] `FollowPathString` - [ ] `PartialCmp` - [ ] `Operation` - [ ] `Dropped` - [ ] Document `notify_on_drop` optional field in `PluginCustomValue`
632 lines
19 KiB
Rust
632 lines
19 KiB
Rust
use super::definitions::{
|
|
db_column::DbColumn, db_constraint::DbConstraint, db_foreignkey::DbForeignKey,
|
|
db_index::DbIndex, db_table::DbTable,
|
|
};
|
|
use nu_protocol::{CustomValue, PipelineData, Record, ShellError, Span, Spanned, Value};
|
|
use rusqlite::{
|
|
types::ValueRef, Connection, DatabaseName, Error as SqliteError, OpenFlags, Row, Statement,
|
|
};
|
|
use serde::{Deserialize, Serialize};
|
|
use std::{
|
|
fs::File,
|
|
io::Read,
|
|
path::{Path, PathBuf},
|
|
sync::{atomic::AtomicBool, Arc},
|
|
};
|
|
|
|
const SQLITE_MAGIC_BYTES: &[u8] = "SQLite format 3\0".as_bytes();
|
|
pub const MEMORY_DB: &str = "file:memdb1?mode=memory&cache=shared";
|
|
|
|
#[derive(Debug, Clone, Serialize, Deserialize)]
|
|
pub struct SQLiteDatabase {
|
|
// I considered storing a SQLite connection here, but decided against it because
|
|
// 1) YAGNI, 2) it's not obvious how cloning a connection could work, 3) state
|
|
// management gets tricky quick. Revisit this approach if we find a compelling use case.
|
|
pub path: PathBuf,
|
|
#[serde(skip)]
|
|
// this understandably can't be serialized. think that's OK, I'm not aware of a
|
|
// reason why a CustomValue would be serialized outside of a plugin
|
|
ctrlc: Option<Arc<AtomicBool>>,
|
|
}
|
|
|
|
impl SQLiteDatabase {
|
|
pub fn new(path: &Path, ctrlc: Option<Arc<AtomicBool>>) -> Self {
|
|
Self {
|
|
path: PathBuf::from(path),
|
|
ctrlc,
|
|
}
|
|
}
|
|
|
|
pub fn try_from_path(
|
|
path: &Path,
|
|
span: Span,
|
|
ctrlc: Option<Arc<AtomicBool>>,
|
|
) -> Result<Self, ShellError> {
|
|
let mut file = File::open(path).map_err(|e| ShellError::ReadingFile {
|
|
msg: e.to_string(),
|
|
span,
|
|
})?;
|
|
|
|
let mut buf: [u8; 16] = [0; 16];
|
|
file.read_exact(&mut buf)
|
|
.map_err(|e| ShellError::ReadingFile {
|
|
msg: e.to_string(),
|
|
span,
|
|
})
|
|
.and_then(|_| {
|
|
if buf == SQLITE_MAGIC_BYTES {
|
|
Ok(SQLiteDatabase::new(path, ctrlc))
|
|
} else {
|
|
Err(ShellError::ReadingFile {
|
|
msg: "Not a SQLite file".into(),
|
|
span,
|
|
})
|
|
}
|
|
})
|
|
}
|
|
|
|
pub fn try_from_value(value: Value) -> Result<Self, ShellError> {
|
|
let span = value.span();
|
|
match value {
|
|
Value::CustomValue { val, .. } => match val.as_any().downcast_ref::<Self>() {
|
|
Some(db) => Ok(Self {
|
|
path: db.path.clone(),
|
|
ctrlc: db.ctrlc.clone(),
|
|
}),
|
|
None => Err(ShellError::CantConvert {
|
|
to_type: "database".into(),
|
|
from_type: "non-database".into(),
|
|
span,
|
|
help: None,
|
|
}),
|
|
},
|
|
x => Err(ShellError::CantConvert {
|
|
to_type: "database".into(),
|
|
from_type: x.get_type().to_string(),
|
|
span: x.span(),
|
|
help: None,
|
|
}),
|
|
}
|
|
}
|
|
|
|
pub fn try_from_pipeline(input: PipelineData, span: Span) -> Result<Self, ShellError> {
|
|
let value = input.into_value(span);
|
|
Self::try_from_value(value)
|
|
}
|
|
|
|
pub fn into_value(self, span: Span) -> Value {
|
|
let db = Box::new(self);
|
|
Value::custom_value(db, span)
|
|
}
|
|
|
|
pub fn query(&self, sql: &Spanned<String>, call_span: Span) -> Result<Value, ShellError> {
|
|
let conn = open_sqlite_db(&self.path, call_span)?;
|
|
|
|
let stream =
|
|
run_sql_query(conn, sql, self.ctrlc.clone()).map_err(|e| ShellError::GenericError {
|
|
error: "Failed to query SQLite database".into(),
|
|
msg: e.to_string(),
|
|
span: Some(sql.span),
|
|
help: None,
|
|
inner: vec![],
|
|
})?;
|
|
|
|
Ok(stream)
|
|
}
|
|
|
|
pub fn open_connection(&self) -> Result<Connection, ShellError> {
|
|
if self.path == PathBuf::from(MEMORY_DB) {
|
|
open_connection_in_memory_custom()
|
|
} else {
|
|
Connection::open(&self.path).map_err(|e| ShellError::GenericError {
|
|
error: "Failed to open SQLite database from open_connection".into(),
|
|
msg: e.to_string(),
|
|
span: None,
|
|
help: None,
|
|
inner: vec![],
|
|
})
|
|
}
|
|
}
|
|
|
|
pub fn get_tables(&self, conn: &Connection) -> Result<Vec<DbTable>, SqliteError> {
|
|
let mut table_names =
|
|
conn.prepare("SELECT name FROM sqlite_master WHERE type = 'table'")?;
|
|
let rows = table_names.query_map([], |row| row.get(0))?;
|
|
let mut tables = Vec::new();
|
|
|
|
for row in rows {
|
|
let table_name: String = row?;
|
|
tables.push(DbTable {
|
|
name: table_name,
|
|
create_time: None,
|
|
update_time: None,
|
|
engine: None,
|
|
schema: None,
|
|
})
|
|
}
|
|
|
|
Ok(tables.into_iter().collect())
|
|
}
|
|
|
|
pub fn drop_all_tables(&self, conn: &Connection) -> Result<(), SqliteError> {
|
|
let tables = self.get_tables(conn)?;
|
|
|
|
for table in tables {
|
|
conn.execute(&format!("DROP TABLE {}", table.name), [])?;
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
pub fn export_in_memory_database_to_file(
|
|
&self,
|
|
conn: &Connection,
|
|
filename: String,
|
|
) -> Result<(), SqliteError> {
|
|
//vacuum main into 'c:\\temp\\foo.db'
|
|
conn.execute(&format!("vacuum main into '{}'", filename), [])?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
pub fn backup_database_to_file(
|
|
&self,
|
|
conn: &Connection,
|
|
filename: String,
|
|
) -> Result<(), SqliteError> {
|
|
conn.backup(DatabaseName::Main, Path::new(&filename), None)?;
|
|
Ok(())
|
|
}
|
|
|
|
pub fn restore_database_from_file(
|
|
&self,
|
|
conn: &mut Connection,
|
|
filename: String,
|
|
) -> Result<(), SqliteError> {
|
|
conn.restore(
|
|
DatabaseName::Main,
|
|
Path::new(&filename),
|
|
Some(|p: rusqlite::backup::Progress| {
|
|
let percent = if p.pagecount == 0 {
|
|
100
|
|
} else {
|
|
(p.pagecount - p.remaining) * 100 / p.pagecount
|
|
};
|
|
if percent % 10 == 0 {
|
|
log::trace!("Restoring: {} %", percent);
|
|
}
|
|
}),
|
|
)?;
|
|
Ok(())
|
|
}
|
|
|
|
fn get_column_info(&self, row: &Row) -> Result<DbColumn, SqliteError> {
|
|
let dbc = DbColumn {
|
|
cid: row.get("cid")?,
|
|
name: row.get("name")?,
|
|
r#type: row.get("type")?,
|
|
notnull: row.get("notnull")?,
|
|
default: row.get("dflt_value")?,
|
|
pk: row.get("pk")?,
|
|
};
|
|
Ok(dbc)
|
|
}
|
|
|
|
pub fn get_columns(
|
|
&self,
|
|
conn: &Connection,
|
|
table: &DbTable,
|
|
) -> Result<Vec<DbColumn>, SqliteError> {
|
|
let mut column_names = conn.prepare(&format!(
|
|
"SELECT * FROM pragma_table_info('{}');",
|
|
table.name
|
|
))?;
|
|
|
|
let mut columns: Vec<DbColumn> = Vec::new();
|
|
let rows = column_names.query_and_then([], |row| self.get_column_info(row))?;
|
|
|
|
for row in rows {
|
|
columns.push(row?);
|
|
}
|
|
|
|
Ok(columns)
|
|
}
|
|
|
|
fn get_constraint_info(&self, row: &Row) -> Result<DbConstraint, SqliteError> {
|
|
let dbc = DbConstraint {
|
|
name: row.get("index_name")?,
|
|
column_name: row.get("column_name")?,
|
|
origin: row.get("origin")?,
|
|
};
|
|
Ok(dbc)
|
|
}
|
|
|
|
pub fn get_constraints(
|
|
&self,
|
|
conn: &Connection,
|
|
table: &DbTable,
|
|
) -> Result<Vec<DbConstraint>, SqliteError> {
|
|
let mut column_names = conn.prepare(&format!(
|
|
"
|
|
SELECT
|
|
p.origin,
|
|
s.name AS index_name,
|
|
i.name AS column_name
|
|
FROM
|
|
sqlite_master s
|
|
JOIN pragma_index_list(s.tbl_name) p ON s.name = p.name,
|
|
pragma_index_info(s.name) i
|
|
WHERE
|
|
s.type = 'index'
|
|
AND tbl_name = '{}'
|
|
AND NOT p.origin = 'c'
|
|
",
|
|
&table.name
|
|
))?;
|
|
|
|
let mut constraints: Vec<DbConstraint> = Vec::new();
|
|
let rows = column_names.query_and_then([], |row| self.get_constraint_info(row))?;
|
|
|
|
for row in rows {
|
|
constraints.push(row?);
|
|
}
|
|
|
|
Ok(constraints)
|
|
}
|
|
|
|
fn get_foreign_keys_info(&self, row: &Row) -> Result<DbForeignKey, SqliteError> {
|
|
let dbc = DbForeignKey {
|
|
column_name: row.get("from")?,
|
|
ref_table: row.get("table")?,
|
|
ref_column: row.get("to")?,
|
|
};
|
|
Ok(dbc)
|
|
}
|
|
|
|
pub fn get_foreign_keys(
|
|
&self,
|
|
conn: &Connection,
|
|
table: &DbTable,
|
|
) -> Result<Vec<DbForeignKey>, SqliteError> {
|
|
let mut column_names = conn.prepare(&format!(
|
|
"SELECT p.`from`, p.`to`, p.`table` FROM pragma_foreign_key_list('{}') p",
|
|
&table.name
|
|
))?;
|
|
|
|
let mut foreign_keys: Vec<DbForeignKey> = Vec::new();
|
|
let rows = column_names.query_and_then([], |row| self.get_foreign_keys_info(row))?;
|
|
|
|
for row in rows {
|
|
foreign_keys.push(row?);
|
|
}
|
|
|
|
Ok(foreign_keys)
|
|
}
|
|
|
|
fn get_index_info(&self, row: &Row) -> Result<DbIndex, SqliteError> {
|
|
let dbc = DbIndex {
|
|
name: row.get("index_name")?,
|
|
column_name: row.get("name")?,
|
|
seqno: row.get("seqno")?,
|
|
};
|
|
Ok(dbc)
|
|
}
|
|
|
|
pub fn get_indexes(
|
|
&self,
|
|
conn: &Connection,
|
|
table: &DbTable,
|
|
) -> Result<Vec<DbIndex>, SqliteError> {
|
|
let mut column_names = conn.prepare(&format!(
|
|
"
|
|
SELECT
|
|
m.name AS index_name,
|
|
p.*
|
|
FROM
|
|
sqlite_master m,
|
|
pragma_index_info(m.name) p
|
|
WHERE
|
|
m.type = 'index'
|
|
AND m.tbl_name = '{}'
|
|
",
|
|
&table.name,
|
|
))?;
|
|
|
|
let mut indexes: Vec<DbIndex> = Vec::new();
|
|
let rows = column_names.query_and_then([], |row| self.get_index_info(row))?;
|
|
|
|
for row in rows {
|
|
indexes.push(row?);
|
|
}
|
|
|
|
Ok(indexes)
|
|
}
|
|
}
|
|
|
|
impl CustomValue for SQLiteDatabase {
|
|
fn clone_value(&self, span: Span) -> Value {
|
|
let cloned = SQLiteDatabase {
|
|
path: self.path.clone(),
|
|
ctrlc: self.ctrlc.clone(),
|
|
};
|
|
|
|
Value::custom_value(Box::new(cloned), span)
|
|
}
|
|
|
|
fn value_string(&self) -> String {
|
|
self.typetag_name().to_string()
|
|
}
|
|
|
|
fn to_base_value(&self, span: Span) -> Result<Value, ShellError> {
|
|
let db = open_sqlite_db(&self.path, span)?;
|
|
read_entire_sqlite_db(db, span, self.ctrlc.clone()).map_err(|e| ShellError::GenericError {
|
|
error: "Failed to read from SQLite database".into(),
|
|
msg: e.to_string(),
|
|
span: Some(span),
|
|
help: None,
|
|
inner: vec![],
|
|
})
|
|
}
|
|
|
|
fn as_any(&self) -> &dyn std::any::Any {
|
|
self
|
|
}
|
|
|
|
fn follow_path_int(
|
|
&self,
|
|
_self_span: Span,
|
|
_index: usize,
|
|
path_span: Span,
|
|
) -> Result<Value, ShellError> {
|
|
// In theory we could support this, but tables don't have an especially well-defined order
|
|
Err(ShellError::IncompatiblePathAccess { type_name: "SQLite databases do not support integer-indexed access. Try specifying a table name instead".into(), span: path_span })
|
|
}
|
|
|
|
fn follow_path_string(
|
|
&self,
|
|
_self_span: Span,
|
|
_column_name: String,
|
|
path_span: Span,
|
|
) -> Result<Value, ShellError> {
|
|
let db = open_sqlite_db(&self.path, path_span)?;
|
|
|
|
read_single_table(db, _column_name, path_span, self.ctrlc.clone()).map_err(|e| {
|
|
ShellError::GenericError {
|
|
error: "Failed to read from SQLite database".into(),
|
|
msg: e.to_string(),
|
|
span: Some(path_span),
|
|
help: None,
|
|
inner: vec![],
|
|
}
|
|
})
|
|
}
|
|
|
|
fn typetag_name(&self) -> &'static str {
|
|
"SQLiteDatabase"
|
|
}
|
|
|
|
fn typetag_deserialize(&self) {
|
|
unimplemented!("typetag_deserialize")
|
|
}
|
|
}
|
|
|
|
pub fn open_sqlite_db(path: &Path, call_span: Span) -> Result<Connection, ShellError> {
|
|
if path.to_string_lossy() == MEMORY_DB {
|
|
open_connection_in_memory_custom()
|
|
} else {
|
|
let path = path.to_string_lossy().to_string();
|
|
Connection::open(path).map_err(|e| ShellError::GenericError {
|
|
error: "Failed to open SQLite database".into(),
|
|
msg: e.to_string(),
|
|
span: Some(call_span),
|
|
help: None,
|
|
inner: vec![],
|
|
})
|
|
}
|
|
}
|
|
|
|
fn run_sql_query(
|
|
conn: Connection,
|
|
sql: &Spanned<String>,
|
|
ctrlc: Option<Arc<AtomicBool>>,
|
|
) -> Result<Value, SqliteError> {
|
|
let stmt = conn.prepare(&sql.item)?;
|
|
prepared_statement_to_nu_list(stmt, sql.span, ctrlc)
|
|
}
|
|
|
|
fn read_single_table(
|
|
conn: Connection,
|
|
table_name: String,
|
|
call_span: Span,
|
|
ctrlc: Option<Arc<AtomicBool>>,
|
|
) -> Result<Value, SqliteError> {
|
|
let stmt = conn.prepare(&format!("SELECT * FROM [{table_name}]"))?;
|
|
prepared_statement_to_nu_list(stmt, call_span, ctrlc)
|
|
}
|
|
|
|
fn prepared_statement_to_nu_list(
|
|
mut stmt: Statement,
|
|
call_span: Span,
|
|
ctrlc: Option<Arc<AtomicBool>>,
|
|
) -> Result<Value, SqliteError> {
|
|
let column_names = stmt
|
|
.column_names()
|
|
.into_iter()
|
|
.map(String::from)
|
|
.collect::<Vec<String>>();
|
|
|
|
let row_results = stmt.query_map([], |row| {
|
|
Ok(convert_sqlite_row_to_nu_value(
|
|
row,
|
|
call_span,
|
|
&column_names,
|
|
))
|
|
})?;
|
|
|
|
// we collect all rows before returning them. Not ideal but it's hard/impossible to return a stream from a CustomValue
|
|
let mut row_values = vec![];
|
|
|
|
for row_result in row_results {
|
|
if nu_utils::ctrl_c::was_pressed(&ctrlc) {
|
|
// return whatever we have so far, let the caller decide whether to use it
|
|
return Ok(Value::list(row_values, call_span));
|
|
}
|
|
|
|
if let Ok(row_value) = row_result {
|
|
row_values.push(row_value);
|
|
}
|
|
}
|
|
|
|
Ok(Value::list(row_values, call_span))
|
|
}
|
|
|
|
fn read_entire_sqlite_db(
|
|
conn: Connection,
|
|
call_span: Span,
|
|
ctrlc: Option<Arc<AtomicBool>>,
|
|
) -> Result<Value, SqliteError> {
|
|
let mut tables = Record::new();
|
|
|
|
let mut get_table_names =
|
|
conn.prepare("SELECT name FROM sqlite_master WHERE type = 'table'")?;
|
|
let rows = get_table_names.query_map([], |row| row.get(0))?;
|
|
|
|
for row in rows {
|
|
let table_name: String = row?;
|
|
let table_stmt = conn.prepare(&format!("select * from [{table_name}]"))?;
|
|
let rows = prepared_statement_to_nu_list(table_stmt, call_span, ctrlc.clone())?;
|
|
tables.push(table_name, rows);
|
|
}
|
|
|
|
Ok(Value::record(tables, call_span))
|
|
}
|
|
|
|
pub fn convert_sqlite_row_to_nu_value(row: &Row, span: Span, column_names: &[String]) -> Value {
|
|
let record = column_names
|
|
.iter()
|
|
.enumerate()
|
|
.map(|(i, col)| {
|
|
(
|
|
col.clone(),
|
|
convert_sqlite_value_to_nu_value(row.get_ref_unwrap(i), span),
|
|
)
|
|
})
|
|
.collect();
|
|
|
|
Value::record(record, span)
|
|
}
|
|
|
|
pub fn convert_sqlite_value_to_nu_value(value: ValueRef, span: Span) -> Value {
|
|
match value {
|
|
ValueRef::Null => Value::nothing(span),
|
|
ValueRef::Integer(i) => Value::int(i, span),
|
|
ValueRef::Real(f) => Value::float(f, span),
|
|
ValueRef::Text(buf) => {
|
|
let s = match std::str::from_utf8(buf) {
|
|
Ok(v) => v,
|
|
Err(_) => return Value::error(ShellError::NonUtf8 { span }, span),
|
|
};
|
|
Value::string(s.to_string(), span)
|
|
}
|
|
ValueRef::Blob(u) => Value::binary(u.to_vec(), span),
|
|
}
|
|
}
|
|
|
|
pub fn open_connection_in_memory_custom() -> Result<Connection, ShellError> {
|
|
let flags = OpenFlags::default();
|
|
Connection::open_with_flags(MEMORY_DB, flags).map_err(|e| ShellError::GenericError {
|
|
error: "Failed to open SQLite custom connection in memory".into(),
|
|
msg: e.to_string(),
|
|
span: Some(Span::test_data()),
|
|
help: None,
|
|
inner: vec![],
|
|
})
|
|
}
|
|
|
|
pub fn open_connection_in_memory() -> Result<Connection, ShellError> {
|
|
Connection::open_in_memory().map_err(|e| ShellError::GenericError {
|
|
error: "Failed to open SQLite standard connection in memory".into(),
|
|
msg: e.to_string(),
|
|
span: Some(Span::test_data()),
|
|
help: None,
|
|
inner: vec![],
|
|
})
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
use nu_protocol::record;
|
|
|
|
#[test]
|
|
fn can_read_empty_db() {
|
|
let db = open_connection_in_memory().unwrap();
|
|
let converted_db = read_entire_sqlite_db(db, Span::test_data(), None).unwrap();
|
|
|
|
let expected = Value::test_record(Record::new());
|
|
|
|
assert_eq!(converted_db, expected);
|
|
}
|
|
|
|
#[test]
|
|
fn can_read_empty_table() {
|
|
let db = open_connection_in_memory().unwrap();
|
|
|
|
db.execute(
|
|
"CREATE TABLE person (
|
|
id INTEGER PRIMARY KEY,
|
|
name TEXT NOT NULL,
|
|
data BLOB
|
|
)",
|
|
[],
|
|
)
|
|
.unwrap();
|
|
let converted_db = read_entire_sqlite_db(db, Span::test_data(), None).unwrap();
|
|
|
|
let expected = Value::test_record(record! {
|
|
"person" => Value::test_list(vec![]),
|
|
});
|
|
|
|
assert_eq!(converted_db, expected);
|
|
}
|
|
|
|
#[test]
|
|
fn can_read_null_and_non_null_data() {
|
|
let span = Span::test_data();
|
|
let db = open_connection_in_memory().unwrap();
|
|
|
|
db.execute(
|
|
"CREATE TABLE item (
|
|
id INTEGER PRIMARY KEY,
|
|
name TEXT
|
|
)",
|
|
[],
|
|
)
|
|
.unwrap();
|
|
|
|
db.execute("INSERT INTO item (id, name) VALUES (123, NULL)", [])
|
|
.unwrap();
|
|
|
|
db.execute("INSERT INTO item (id, name) VALUES (456, 'foo bar')", [])
|
|
.unwrap();
|
|
|
|
let converted_db = read_entire_sqlite_db(db, span, None).unwrap();
|
|
|
|
let expected = Value::test_record(record! {
|
|
"item" => Value::test_list(
|
|
vec![
|
|
Value::test_record(record! {
|
|
"id" => Value::test_int(123),
|
|
"name" => Value::nothing(span),
|
|
}),
|
|
Value::test_record(record! {
|
|
"id" => Value::test_int(456),
|
|
"name" => Value::test_string("foo bar"),
|
|
}),
|
|
]
|
|
),
|
|
});
|
|
|
|
assert_eq!(converted_db, expected);
|
|
}
|
|
}
|