mirror of
https://github.com/nushell/nushell
synced 2024-12-30 15:03:25 +00:00
03ee54a4df
# Description Partialy addresses #13868. `try` does not catch non-zero exit code errors from the last command in a pipeline if the result is assigned to a variable using `let` (or `mut`). This was fixed by adding a new `OutDest::Value` case. This is used when the pipeline is in a "value" position. I.e., it will be collected into a value. This ended up replacing most of the usages of `OutDest::Capture`. So, this PR also renames `OutDest::Capture` to `OutDest::PipeSeparate` to better fit the few remaining use cases for it. # User-Facing Changes Bug fix. # Tests + Formatting Added two tests.
119 lines
3 KiB
Rust
119 lines
3 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn try_succeed() {
|
|
let output = nu!("try { 345 } catch { echo 'hello' }");
|
|
|
|
assert!(output.out.contains("345"));
|
|
}
|
|
|
|
#[test]
|
|
fn try_catch() {
|
|
let output = nu!("try { foobarbaz } catch { echo 'hello' }");
|
|
|
|
assert!(output.out.contains("hello"));
|
|
}
|
|
|
|
#[test]
|
|
fn catch_can_access_error() {
|
|
let output = nu!("try { foobarbaz } catch { |err| $err | get raw }");
|
|
|
|
assert!(output.err.contains("External command failed"));
|
|
}
|
|
|
|
#[test]
|
|
fn catch_can_access_error_as_dollar_in() {
|
|
let output = nu!("try { foobarbaz } catch { $in | get raw }");
|
|
|
|
assert!(output.err.contains("External command failed"));
|
|
}
|
|
|
|
#[test]
|
|
fn external_failed_should_be_caught() {
|
|
let output = nu!("try { nu --testbin fail; echo 'success' } catch { echo 'fail' }");
|
|
|
|
assert!(output.out.contains("fail"));
|
|
}
|
|
|
|
#[test]
|
|
fn loop_try_break_should_be_successful() {
|
|
let output =
|
|
nu!("loop { try { print 'successful'; break } catch { print 'failed'; continue } }");
|
|
|
|
assert_eq!(output.out, "successful");
|
|
}
|
|
|
|
#[test]
|
|
fn loop_catch_break_should_show_failed() {
|
|
let output = nu!("loop {
|
|
try { invalid 1;
|
|
continue; } catch { print 'failed'; break }
|
|
}
|
|
");
|
|
|
|
assert_eq!(output.out, "failed");
|
|
}
|
|
|
|
#[test]
|
|
fn loop_try_ignores_continue() {
|
|
let output = nu!("mut total = 0;
|
|
for i in 0..10 {
|
|
try { if ($i mod 2) == 0 {
|
|
continue;}
|
|
$total += 1
|
|
} catch { echo 'failed'; break }
|
|
}
|
|
echo $total
|
|
");
|
|
|
|
assert_eq!(output.out, "5");
|
|
}
|
|
|
|
#[test]
|
|
fn loop_try_break_on_command_should_show_successful() {
|
|
let output = nu!("loop { try { ls; break } catch { echo 'failed';continue }}");
|
|
|
|
assert!(!output.out.contains("failed"));
|
|
}
|
|
|
|
#[test]
|
|
fn catch_block_can_use_error_object() {
|
|
let output = nu!("try {1 / 0} catch {|err| print ($err | get msg)}");
|
|
assert_eq!(output.out, "Division by zero.")
|
|
}
|
|
|
|
// This test is disabled on Windows because they cause a stack overflow in CI (but not locally!).
|
|
// For reasons we don't understand, the Windows CI runners are prone to stack overflow.
|
|
// TODO: investigate so we can enable on Windows
|
|
#[cfg(not(target_os = "windows"))]
|
|
#[test]
|
|
fn can_catch_infinite_recursion() {
|
|
let actual = nu!(r#"
|
|
def bang [] { try { bang } catch { "Caught infinite recursion" } }; bang
|
|
"#);
|
|
assert_eq!(actual.out, "Caught infinite recursion");
|
|
}
|
|
|
|
#[test]
|
|
fn exit_code_available_in_catch_env() {
|
|
let actual = nu!("try { nu -c 'exit 42' } catch { $env.LAST_EXIT_CODE }");
|
|
assert_eq!(actual.out, "42");
|
|
}
|
|
|
|
#[test]
|
|
fn exit_code_available_in_catch() {
|
|
let actual = nu!("try { nu -c 'exit 42' } catch { |e| $e.exit_code }");
|
|
assert_eq!(actual.out, "42");
|
|
}
|
|
|
|
#[test]
|
|
fn try_catches_exit_code_in_assignment() {
|
|
let actual = nu!("let x = try { nu -c 'exit 42' } catch { |e| $e.exit_code }; $x");
|
|
assert_eq!(actual.out, "42");
|
|
}
|
|
|
|
#[test]
|
|
fn try_catches_exit_code_in_expr() {
|
|
let actual = nu!("print (try { nu -c 'exit 42' } catch { |e| $e.exit_code })");
|
|
assert_eq!(actual.out, "42");
|
|
}
|