mirror of
https://github.com/nushell/nushell
synced 2025-01-22 18:05:21 +00:00
644164fab3
# Description #8258 Math floor and ceil return int types rather than floats. # User-Facing Changes Before: ``` /home/rdevenney/projects/open_source/nushell〉[(3.14 | math ceil | describe), (3.14 | math floor | describe), (3 | math ceil | describe), (3 | math floor | describe)] ╭───┬───────╮ │ 0 │ float │ │ 1 │ float │ │ 2 │ int │ │ 3 │ int │ ╰───┴───────╯ ``` After: ``` /home/rdevenney/projects/open_source/nushell〉[(3.14 | math ceil | describe), (3.14 | math floor | describe), (3 | math ceil | describe), (3 | math floor | describe)] ╭───┬─────╮ │ 0 │ int │ │ 1 │ int │ │ 2 │ int │ │ 3 │ int │ ╰───┴─────╯ ``` # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. |
||
|---|---|---|
| .. | ||
| abs.rs | ||
| arccos.rs | ||
| arccosh.rs | ||
| arcsin.rs | ||
| arcsinh.rs | ||
| arctan.rs | ||
| arctanh.rs | ||
| avg.rs | ||
| ceil.rs | ||
| cos.rs | ||
| cosh.rs | ||
| euler.rs | ||
| floor.rs | ||
| ln.rs | ||
| log.rs | ||
| math_.rs | ||
| max.rs | ||
| median.rs | ||
| min.rs | ||
| mod.rs | ||
| mode.rs | ||
| pi.rs | ||
| product.rs | ||
| reducers.rs | ||
| round.rs | ||
| sin.rs | ||
| sinh.rs | ||
| sqrt.rs | ||
| stddev.rs | ||
| sum.rs | ||
| tan.rs | ||
| tanh.rs | ||
| tau.rs | ||
| utils.rs | ||
| variance.rs | ||