mirror of
https://github.com/nushell/nushell
synced 2025-01-09 19:59:02 +00:00
4b301710d3
# Description
Use `record!` macro instead of defining two separate `vec!` for `cols`
and `vals` when appropriate.
This visually aligns the key with the value.
Further more you don't have to deal with the construction of `Record {
cols, vals }` so we can hide the implementation details in the future.
## State
Not covering all possible commands yet, also some tests/examples are
better expressed by creating cols and vals separately.
# User/Developer-Facing Changes
The examples and tests should read more natural. No relevant functional
change
# Bycatch
Where I noticed it I replaced usage of `Value` constructors with
`Span::test_data()` or `Span::unknown()` to the `Value::test_...`
constructors. This should make things more readable and also simplify
changes to the `Span` system in the future.
79 lines
2.1 KiB
Rust
79 lines
2.1 KiB
Rust
use crate::math::reducers::{reducer_for, Reduce};
|
|
use crate::math::utils::run_with_function;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
record, Category, Example, PipelineData, ShellError, Signature, Span, Type, Value,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"math max"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("math max")
|
|
.input_output_types(vec![
|
|
(Type::List(Box::new(Type::Any)), Type::Any),
|
|
(Type::Table(vec![]), Type::Record(vec![])),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Math)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Returns the maximum of a list of values, or of columns in a table."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["maximum", "largest"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_with_function(call, input, maximum)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Find the maximum of list of numbers",
|
|
example: "[-50 100 25] | math max",
|
|
result: Some(Value::test_int(100)),
|
|
},
|
|
Example {
|
|
description: "Find the maxima of the columns of a table",
|
|
example: "[{a: 1 b: 3} {a: 2 b: -1}] | math max",
|
|
result: Some(Value::test_record(record! {
|
|
"a" => Value::test_int(2),
|
|
"b" => Value::test_int(3),
|
|
})),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
pub fn maximum(values: &[Value], span: Span, head: Span) -> Result<Value, ShellError> {
|
|
let max_func = reducer_for(Reduce::Maximum);
|
|
max_func(Value::nothing(head), values.to_vec(), span, head)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|