mirror of
https://github.com/nushell/nushell
synced 2024-12-30 15:03:25 +00:00
a8eef9af33
# Description As title, closes: #7921 closes: #8273 # User-Facing Changes when define a closure without pipe, nushell will raise error for now: ``` ❯ let x = {ss ss} Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #2:1:1] 1 │ let x = {ss ss} · ───┬─── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `any`, `each`, `all`, `where` command accepts closure, it forces user input closure like `{||`, or parse error will returned. ``` ❯ {major:2, minor:1, patch:4} | values | each { into string } Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #4:1:1] 1 │ {major:2, minor:1, patch:4} | values | each { into string } · ───────┬─────── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `with-env`, `do`, `def`, `try` are special, they still remain the same, although it says that it accepts a closure, but they don't need to be written like `{||`, it's more likely a block but can capture variable outside of scope: ``` ❯ def test [input] { echo [0 1 2] | do { do { echo $input } } }; test aaa aaa ``` Just realize that It's a big breaking change, we need to update config and scripts... # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
126 lines
2.8 KiB
Rust
126 lines
2.8 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn sets_the_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| update dev-dependencies.pretty_assertions "0.7.0"
|
|
| get dev-dependencies.pretty_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn doesnt_convert_record_to_table() {
|
|
let actual = nu!(
|
|
cwd: ".", r#"{a:1} | update a 2 | to nuon"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "{a: 2}");
|
|
}
|
|
|
|
#[cfg(features = "inc")]
|
|
#[test]
|
|
fn sets_the_column_from_a_block_run_output() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| update dev-dependencies.pretty_assertions { open cargo_sample.toml | get dev-dependencies.pretty_assertions | inc --minor }
|
|
| get dev-dependencies.pretty_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn sets_the_column_from_a_block_full_stream_output() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{content: null}
|
|
| update content {|| open --raw cargo_sample.toml | lines | first 5 }
|
|
| get content.1
|
|
| str contains "nu"
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn sets_the_column_from_a_subexpression() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{content: null}
|
|
| update content (open --raw cargo_sample.toml | lines | first 5)
|
|
| get content.1
|
|
| str contains "nu"
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn upsert_column_missing() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| update dev-dependencies.new_assertions "0.7.0"
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn update_list() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3] | update 1 abc | to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, r#"[1,"abc",3]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn update_past_end_list() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3] | update 5 abc | to json -r
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("too large"));
|
|
}
|
|
|
|
#[test]
|
|
fn update_nonexistent_column() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"{a:1} | update b 2"#
|
|
));
|
|
|
|
assert!(actual.err.contains("cannot find column 'b'"));
|
|
}
|
|
|
|
#[test]
|
|
fn update_uses_enumerate_index() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a]; [7] [6]] | enumerate | update item.a {|el| $el.index + 1 + $el.item.a } | flatten | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[index, a]; [0, 8], [1, 8]]");
|
|
}
|