mirror of
https://github.com/nushell/nushell
synced 2024-12-29 06:23:11 +00:00
3d340657b5
This PR: 1. Adds basic support for `CustomValue` to `explore`. Previously `open foo.db | explore` didn't really work, now we "materialize" the whole database to a `Value` before loading it 2. Adopts `anyhow` for error handling in `explore`. Previously we were kind of rolling our own version of `anyhow` by shoving all errors into a `std::io::Error`; I think this is much nicer. This was necessary because as part of 1), collecting input is now fallible... 3. Removes a lot of `explore`'s fancy command help system. - Previously each command (`:help`, `:try`, etc.) had a sophisticated help system with examples etc... but this was not very visible to users. You had to know to run `:help :try` or view a list of commands with `:help :` - As discussed previously, we eventually want to move to a less modal approach for `explore`, without the Vim-like commands. And so I don't think it's worth keeping this command help system around (it's intertwined with other stuff, and making these changes would have been harder if keeping it). 4. Rename the `--reverse` flag to `--tail`. The flag scrolls to the end of the data, which IMO is described better by "tail" 5. Does some renaming+commenting to clear up things I found difficult to understand when navigating the `explore` code I initially thought 1) would be just a few lines, and then this PR blew up into much more extensive changes 😅 ## Before The whole database was being displayed as a single Nuon/JSON line 🤔 ![image](https://github.com/nushell/nushell/assets/26268125/6383f43b-fdff-48b4-9604-398438ad1499) ## After The database gets displayed like a record ![image](https://github.com/nushell/nushell/assets/26268125/2f00ed7b-a3c4-47f4-a08c-98d07efc7bb4) ## Future work It is sort of annoying that we have to load a whole SQLite database into memory to make this work; it will be impractical for large databases. I'd like to explore improvements to `CustomValue` that can make this work more efficiently.
35 lines
1.2 KiB
TOML
35 lines
1.2 KiB
TOML
[package]
|
|
authors = ["The Nushell Project Developers"]
|
|
description = "Nushell table pager"
|
|
repository = "https://github.com/nushell/nushell/tree/main/crates/nu-explore"
|
|
edition = "2021"
|
|
license = "MIT"
|
|
name = "nu-explore"
|
|
version = "0.93.1"
|
|
|
|
[lib]
|
|
bench = false
|
|
|
|
[dependencies]
|
|
nu-protocol = { path = "../nu-protocol", version = "0.93.1" }
|
|
nu-parser = { path = "../nu-parser", version = "0.93.1" }
|
|
nu-color-config = { path = "../nu-color-config", version = "0.93.1" }
|
|
nu-engine = { path = "../nu-engine", version = "0.93.1" }
|
|
nu-table = { path = "../nu-table", version = "0.93.1" }
|
|
nu-json = { path = "../nu-json", version = "0.93.1" }
|
|
nu-utils = { path = "../nu-utils", version = "0.93.1" }
|
|
nu-ansi-term = { workspace = true }
|
|
nu-pretty-hex = { path = "../nu-pretty-hex", version = "0.93.1" }
|
|
|
|
anyhow = { workspace = true }
|
|
log = { workspace = true }
|
|
terminal_size = { workspace = true }
|
|
strip-ansi-escapes = { workspace = true }
|
|
crossterm = { workspace = true }
|
|
once_cell = { workspace = true }
|
|
ratatui = { workspace = true }
|
|
ansi-str = { workspace = true }
|
|
unicode-width = { workspace = true }
|
|
lscolors = { workspace = true, default-features = false, features = [
|
|
"nu-ansi-term",
|
|
] }
|