mirror of
https://github.com/nushell/nushell
synced 2024-12-28 22:13:10 +00:00
9945241b77
# Description Remove `--numbered` from ~~`for`~~, `each`, `par-each`, `reduce` and `each while`. These all provide indexes (numbering) via the optional second param to their closures. EDIT: Closes #6986. # User-Facing Changes Every command that had `--numbered` listed as "deprecated" in their help docs is affected. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
97 lines
2 KiB
Rust
97 lines
2 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn insert_the_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| insert dev-dependencies.new_assertions "0.7.0"
|
|
| get dev-dependencies.new_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn doesnt_convert_record_to_table() {
|
|
let actual = nu!(
|
|
cwd: ".", r#"{a:1} | insert b 2 | to nuon"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "{a: 1, b: 2}");
|
|
}
|
|
|
|
#[test]
|
|
fn insert_the_column_conflict() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| insert dev-dependencies.pretty_assertions "0.7.0"
|
|
"#
|
|
));
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("column 'pretty_assertions' already exists"));
|
|
}
|
|
|
|
#[test]
|
|
fn insert_into_list() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3] | insert 1 abc | to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, r#"[1,"abc",2,3]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_into_list_begin() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3] | insert 0 abc | to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, r#"["abc",1,2,3]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_into_list_end() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3] | insert 3 abc | to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, r#"[1,2,3,"abc"]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_past_end_list() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3] | insert 5 abc | to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, r#"[1,2,3,null,null,"abc"]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_uses_enumerate_index() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a]; [7] [6]] | enumerate | insert b {|el| $el.index + 1 + $el.item.a } | flatten | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[index, a, b]; [0, 7, 8], [1, 6, 8]]");
|
|
}
|