mirror of
https://github.com/nushell/nushell
synced 2025-01-23 10:25:22 +00:00
786ba3bf91
# Description This PR tights input/output type-checking a bit more. There are a lot of commands that don't have correct input/output types, so part of the effort is updating them. This PR now contains updates to commands that had wrong input/output signatures. It doesn't add examples for these new signatures, but that can be follow-up work. # User-Facing Changes BREAKING CHANGE BREAKING CHANGE This work enforces many more checks on pipeline type correctness than previous nushell versions. This strictness may uncover incompatibilities in existing scripts or shortcomings in the type information for internal commands. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
153 lines
3.7 KiB
Rust
153 lines
3.7 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn basic_binary_starts_with() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
"hello world" | into binary | bytes starts-with 0x[68 65 6c 6c 6f]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn basic_string_fails() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
"hello world" | bytes starts-with 0x[68 65 6c 6c 6f]
|
|
"#
|
|
);
|
|
|
|
assert!(actual.err.contains("command doesn't support"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn short_stream_binary() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 5 | bytes starts-with 0x[010101]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn short_stream_mismatch() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[010203]) 5 | bytes starts-with 0x[010204]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn short_stream_binary_overflow() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 5 | bytes starts-with 0x[010101010101]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_binary() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 32768 | bytes starts-with 0x[010101]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_binary_overflow() {
|
|
// .. ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 32768 | bytes starts-with (0..32768 | each {|| 0x[01] } | bytes collect)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_binary_exact() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01020304]) 8192 | bytes starts-with (0..<8192 | each {|| 0x[01020304] } | bytes collect)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_string_exact() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater hell 8192 | bytes starts-with (0..<8192 | each {|| "hell" | into binary } | bytes collect)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_mixed_exact() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
let binseg = (0..<2048 | each {|| 0x[003d9fbf] } | bytes collect)
|
|
let strseg = (0..<2048 | each {|| "hell" | into binary } | bytes collect)
|
|
|
|
nu --testbin repeat_bytes 003d9fbf 2048 68656c6c 2048 | bytes starts-with (bytes build $binseg $strseg)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(
|
|
actual.err, "",
|
|
"invocation failed. command line limit likely reached"
|
|
);
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_mixed_overflow() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
let binseg = (0..<2048 | each {|| 0x[003d9fbf] } | bytes collect)
|
|
let strseg = (0..<2048 | each {|| "hell" | into binary } | bytes collect)
|
|
|
|
nu --testbin repeat_bytes 003d9fbf 2048 68656c6c 2048 | bytes starts-with (bytes build $binseg $strseg 0x[01])
|
|
"#
|
|
);
|
|
|
|
assert_eq!(
|
|
actual.err, "",
|
|
"invocation failed. command line limit likely reached"
|
|
);
|
|
assert_eq!(actual.out, "false");
|
|
}
|