mirror of
https://github.com/nushell/nushell
synced 2025-01-14 14:14:13 +00:00
4af24363c2
# Description For years, Nushell has used `let-env` to set a single environment variable. As our work on scoping continued, we refined what it meant for a variable to be in scope using `let` but never updated how `let-env` would work. Instead, `let-env` confusingly created mutations to the command's copy of `$env`. So, to help fix the mental model and point people to the right way of thinking about what changing the environment means, this PR removes `let-env` to encourage people to think of it as updating the command's environment variable via mutation. Before: ``` let-env FOO = "BAR" ``` Now: ``` $env.FOO = "BAR" ``` It's also a good reminder that the environment owned by the command is in the `$env` variable rather than global like it is in other shells. # User-Facing Changes BREAKING CHANGE BREAKING CHANGE This completely removes `let-env FOO = "BAR"` so that we can focus on `$env.FOO = "BAR"`. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After / Before Submitting integration scripts to update: - ✔️ [starship](https://github.com/starship/starship/blob/master/src/init/starship.nu) - ✔️ [virtualenv](https://github.com/pypa/virtualenv/blob/main/src/virtualenv/activation/nushell/activate.nu) - ✔️ [atuin](https://github.com/ellie/atuin/blob/main/atuin/src/shell/atuin.nu) (PR: https://github.com/ellie/atuin/pull/1080) - ❌ [zoxide](https://github.com/ajeetdsouza/zoxide/blob/main/templates/nushell.txt) (PR: https://github.com/ajeetdsouza/zoxide/pull/587) - ✔️ [oh-my-posh](https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/src/shell/scripts/omp.nu) (pr: https://github.com/JanDeDobbeleer/oh-my-posh/pull/4011)
113 lines
2.6 KiB
Rust
113 lines
2.6 KiB
Rust
use crate::tests::{fail_test, run_test, TestResult};
|
|
|
|
#[test]
|
|
fn module_def_imports_1() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export def a [] { 1 }; def b [] { 2 } }; use foo; foo a"#,
|
|
"1",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_imports_2() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export def a [] { 1 }; def b [] { 2 } }; use foo a; a"#,
|
|
"1",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_imports_3() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export def a [] { 1 }; export def b [] { 2 } }; use foo *; b"#,
|
|
"2",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_imports_4() -> TestResult {
|
|
fail_test(
|
|
r#"module foo { export def a [] { 1 }; export def b [] { 2 } }; use foo c"#,
|
|
"not find import",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_imports_5() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export def a [] { 1 }; def b [] { '2' }; export def c [] { '3' } }; use foo [a, c]; c"#,
|
|
"3",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_env_imports_1() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export-env { $env.a = '1' } }; use foo; $env.a"#,
|
|
"1",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_env_imports_2() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export-env { $env.a = '1'; $env.b = '2' } }; use foo; $env.b"#,
|
|
"2",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_env_imports_3() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export-env { $env.a = '1' }; export-env { $env.b = '2' }; export-env {$env.c = '3'} }; use foo; $env.c"#,
|
|
"3",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_and_env_imports_1() -> TestResult {
|
|
run_test(
|
|
r#"module spam { export-env { $env.foo = "foo" }; export def foo [] { "bar" } }; use spam; $env.foo"#,
|
|
"foo",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_and_env_imports_2() -> TestResult {
|
|
run_test(
|
|
r#"module spam { export-env { $env.foo = "foo" }; export def foo [] { "bar" } }; use spam foo; foo"#,
|
|
"bar",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_def_import_uses_internal_command() -> TestResult {
|
|
run_test(
|
|
r#"module foo { def b [] { 2 }; export def a [] { b } }; use foo; foo a"#,
|
|
"2",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn module_env_import_uses_internal_command() -> TestResult {
|
|
run_test(
|
|
r#"module foo { def b [] { "2" }; export-env { $env.a = (b) } }; use foo; $env.a"#,
|
|
"2",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn multi_word_imports() -> TestResult {
|
|
run_test(
|
|
r#"module spam { export def "foo bar" [] { 10 } }; use spam "foo bar"; foo bar"#,
|
|
"10",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn export_alias() -> TestResult {
|
|
run_test(
|
|
r#"module foo { export alias hi = echo hello }; use foo hi; hi"#,
|
|
"hello",
|
|
)
|
|
}
|