mirror of
https://github.com/nushell/nushell
synced 2024-12-29 06:23:11 +00:00
b9419e0f36
# Description Fixes #7800 . `to csv` and `to tsv` no longer: - accept anything but records and tables as input, - accept lists that are not tables, - accept tables and records with values that are not primitives (other lists, tables and records). # User-Facing Changes Using `to csv` and `to tsv` on any of inputs mentioned above will result in `cant_convert` error. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
247 lines
6.3 KiB
Rust
247 lines
6.3 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn table_to_csv_text_and_from_csv_text_back_into_table() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"open caco3_plastics.csv | to csv | from csv | first | get origin "
|
|
);
|
|
|
|
assert_eq!(actual.out, "SPAIN");
|
|
}
|
|
|
|
#[test]
|
|
fn table_to_csv_text() {
|
|
Playground::setup("filter_to_csv_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"csv_text_sample.txt",
|
|
r#"
|
|
importer,shipper,tariff_item,name,origin
|
|
Plasticos Rival,Reverte,2509000000,Calcium carbonate,Spain
|
|
Tigre Ecuador,OMYA Andina,3824909999,Calcium carbonate,Colombia
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open csv_text_sample.txt
|
|
| lines
|
|
| str trim
|
|
| split column "," a b c d origin
|
|
| last 1
|
|
| to csv
|
|
| lines
|
|
| get 1
|
|
"#
|
|
));
|
|
|
|
assert!(actual
|
|
.out
|
|
.contains("Tigre Ecuador,OMYA Andina,3824909999,Calcium carbonate,Colombia"));
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn table_to_csv_text_skipping_headers_after_conversion() {
|
|
Playground::setup("filter_to_csv_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"csv_text_sample.txt",
|
|
r#"
|
|
importer,shipper,tariff_item,name,origin
|
|
Plasticos Rival,Reverte,2509000000,Calcium carbonate,Spain
|
|
Tigre Ecuador,OMYA Andina,3824909999,Calcium carbonate,Colombia
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open csv_text_sample.txt
|
|
| lines
|
|
| str trim
|
|
| split column "," a b c d origin
|
|
| last 1
|
|
| to csv --noheaders
|
|
"#
|
|
));
|
|
|
|
assert!(actual
|
|
.out
|
|
.contains("Tigre Ecuador,OMYA Andina,3824909999,Calcium carbonate,Colombia"));
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn infers_types() {
|
|
Playground::setup("filter_from_csv_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_cuatro_mosqueteros.csv",
|
|
r#"
|
|
first_name,last_name,rusty_luck,d
|
|
Andrés,Robalino,1,d
|
|
Jonathan,Turner,1,d
|
|
Yehuda,Katz,1,d
|
|
Jason,Gedge,1,d
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_cuatro_mosqueteros.csv
|
|
| where rusty_luck > 0
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_csv_text_to_table() {
|
|
Playground::setup("filter_from_csv_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_tres_caballeros.txt",
|
|
r#"
|
|
first_name,last_name,rusty_luck
|
|
Andrés,Robalino,1
|
|
Jonathan,Turner,1
|
|
Yehuda,Katz,1
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_tres_caballeros.txt
|
|
| from csv
|
|
| get rusty_luck
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_csv_text_with_separator_to_table() {
|
|
Playground::setup("filter_from_csv_test_3", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_tres_caballeros.txt",
|
|
r#"
|
|
first_name;last_name;rusty_luck
|
|
Andrés;Robalino;1
|
|
Jonathan;Turner;1
|
|
Yehuda;Katz;1
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_tres_caballeros.txt
|
|
| from csv --separator ";"
|
|
| get rusty_luck
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_csv_text_with_tab_separator_to_table() {
|
|
Playground::setup("filter_from_csv_test_4", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_tres_caballeros.txt",
|
|
r#"
|
|
first_name last_name rusty_luck
|
|
Andrés Robalino 1
|
|
Jonathan Turner 1
|
|
Yehuda Katz 1
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_tres_caballeros.txt
|
|
| from csv --separator (char tab)
|
|
| get rusty_luck
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_csv_text_skipping_headers_to_table() {
|
|
Playground::setup("filter_from_csv_test_5", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_tres_amigos.txt",
|
|
r#"
|
|
Andrés,Robalino,1
|
|
Jonathan,Turner,1
|
|
Yehuda,Katz,1
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_tres_amigos.txt
|
|
| from csv --noheaders
|
|
| get column3
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn table_with_record_error() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
[[a b]; [1 2] [3 {a: 1 b: 2}]]
|
|
| to csv
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("can't convert"))
|
|
}
|
|
|
|
#[test]
|
|
fn list_not_table_error() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
[{a: 1 b: 2} {a: 3 b: 4} 1]
|
|
| to csv
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("can't convert"))
|
|
}
|
|
|
|
#[test]
|
|
fn string_to_csv_error() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
'qwe' | to csv
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("can't convert"))
|
|
}
|