mirror of
https://github.com/nushell/nushell
synced 2024-12-28 22:13:10 +00:00
19beafa865
# Description Change behavior of block evaluation to not print result of intermediate commands. Previously result of every but last pipeline in a block was printed to stdout, and last one was returned  With this change results of intermediate pipelines are discarded after they finish and the last one is returned as before:  Now one should use `print` explicitly to print something to stdout  **Note, that this behavior is not limited to functions!** The scope of this change are all blocks. All of the below are executed as blocks and thus exibited this behavior in the same way:  With this change outputs for all types of blocks are cleaned:  # User-Facing Changes All types of blocks (function bodies, closures, `if` branches, `for` and `loop` bodies e.t.c.) no longer print result of intermediate pipelines. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
98 lines
2 KiB
Rust
98 lines
2 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn with_env_extends_environment() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"with-env [FOO BARRRR] {echo $env} | get FOO"
|
|
);
|
|
|
|
assert_eq!(actual.out, "BARRRR");
|
|
}
|
|
|
|
#[test]
|
|
fn with_env_shorthand() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"FOO=BARRRR echo $env | get FOO"
|
|
);
|
|
|
|
assert_eq!(actual.out, "BARRRR");
|
|
}
|
|
|
|
#[test]
|
|
fn shorthand_doesnt_reorder_arguments() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"FOO=BARRRR nu --testbin cococo first second"
|
|
);
|
|
|
|
assert_eq!(actual.out, "first second");
|
|
}
|
|
|
|
#[test]
|
|
fn with_env_shorthand_trims_quotes() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"FOO='BARRRR' echo $env | get FOO"
|
|
);
|
|
|
|
assert_eq!(actual.out, "BARRRR");
|
|
}
|
|
|
|
#[test]
|
|
fn with_env_and_shorthand_same_result() {
|
|
let actual_shorthand = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"FOO='BARRRR' echo $env | get FOO"
|
|
);
|
|
|
|
let actual_normal = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"with-env [FOO BARRRR] {echo $env} | get FOO"
|
|
);
|
|
|
|
assert_eq!(actual_shorthand.out, actual_normal.out);
|
|
}
|
|
|
|
#[test]
|
|
fn test_redirection2() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"let x = (FOO=BAR nu --testbin cococo niceenvvar); $x | str trim | str length"
|
|
);
|
|
|
|
assert_eq!(actual.out, "10");
|
|
}
|
|
|
|
#[test]
|
|
fn with_env_hides_variables_in_parent_scope() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
r#"
|
|
let-env FOO = "1"
|
|
print $env.FOO
|
|
with-env [FOO null] {
|
|
echo $env.FOO
|
|
}
|
|
print $env.FOO
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn with_env_shorthand_can_not_hide_variables() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
r#"
|
|
let-env FOO = "1"
|
|
print $env.FOO
|
|
FOO=null print $env.FOO
|
|
print $env.FOO
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "1null1");
|
|
}
|