nushell/crates/nu-command/src/math
Leon 220b105efb
Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412)
# Description

While perusing Value.rs, I noticed the `Value::int()`, `Value::float()`,
`Value::boolean()` and `Value::string()` constructors, which seem
designed to make it easier to construct various Values, but which aren't
used often at all in the codebase. So, using a few find-replaces
regexes, I increased their usage. This reduces overall LOC because
structures like this:
```
Value::Int {
  val: a,
  span: head
}
```
are changed into
```
Value::int(a, head)
```
and are respected as such by the project's formatter.
There are little readability concerns because the second argument to all
of these is `span`, and it's almost always extremely obvious which is
the span at every callsite.

# User-Facing Changes

None.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-09 11:37:51 -05:00
..
abs.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
arccos.rs Add inverse for trigonometric functions (#7258) 2022-12-01 15:58:05 +01:00
arccosh.rs Add inverse hyperbolic functions (#7258) 2022-12-01 15:58:05 +01:00
arcsin.rs Add inverse for trigonometric functions (#7258) 2022-12-01 15:58:05 +01:00
arcsinh.rs Add inverse hyperbolic functions (#7258) 2022-12-01 15:58:05 +01:00
arctan.rs Add inverse for trigonometric functions (#7258) 2022-12-01 15:58:05 +01:00
arctanh.rs Add inverse hyperbolic functions (#7258) 2022-12-01 15:58:05 +01:00
avg.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
ceil.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
cos.rs Add basic trigonometric functions (#7258) 2022-12-01 15:58:05 +01:00
cosh.rs Add basic hyperbolic functions (#7258) 2022-12-01 15:58:05 +01:00
euler.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
eval.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
floor.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
ln.rs Add natural logarithm (#7258) 2022-12-01 15:58:05 +01:00
log.rs Add arbitrary base math log (#7409) 2022-12-09 11:20:42 +01:00
math_.rs add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
max.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
median.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
min.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
mod.rs Add arbitrary base math log (#7409) 2022-12-09 11:20:42 +01:00
mode.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
pi.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
product.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
reducers.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
round.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
sin.rs Add basic trigonometric functions (#7258) 2022-12-01 15:58:05 +01:00
sinh.rs Add basic hyperbolic functions (#7258) 2022-12-01 15:58:05 +01:00
sqrt.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
stddev.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
sum.rs Declare input and output types of commands (#6796) 2022-11-10 10:55:05 +13:00
tan.rs Add basic trigonometric functions (#7258) 2022-12-01 15:58:05 +01:00
tanh.rs Add basic hyperbolic functions (#7258) 2022-12-01 15:58:05 +01:00
tau.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00
utils.rs Revert "Add support for optional list stream output formatting (#6325)" (#6454) 2022-08-31 18:09:40 -05:00
variance.rs Reduced LOC by replacing several instances of Value::Int {}, Value::Float{}, Value::Bool {}, and Value::String {} with Value::int(), Value::float(), Value::boolean() and Value::string() (#7412) 2022-12-09 11:37:51 -05:00