mirror of
https://github.com/nushell/nushell
synced 2024-12-27 21:43:09 +00:00
208ffdc1da
# Description From nushell 0.8 philosophy: https://github.com/nushell/nushell.github.io/blob/main/contributor-book/philosophy_0_80.md#core-categories > The following categories should be moved to plugins: Uncommon format support So this pr is trying to move following commands to plugin: - [X] from eml - [x] from ics - [x] from ini - [x] from vcf And we can have a new plugin handles for these formatting, currently it's implemented here: https://github.com/WindSoilder/nu_plugin_format The command usage should be the same to original command. If it's ok, the plugin can support more formats like [parquet](https://github.com/fdncred/nu_plugin_from_parquet), or [EDN format](https://github.com/nushell/nushell/issues/6415), or something else. Just create a draft pr to show what's the blueprint looks like, and is it a good direction to move forward? # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
99 lines
3 KiB
Rust
99 lines
3 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::nu_with_plugins;
|
|
use nu_test_support::playground::Playground;
|
|
|
|
#[test]
|
|
fn infers_types() {
|
|
Playground::setup("filter_from_ics_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"calendar.ics",
|
|
r#"
|
|
BEGIN:VCALENDAR
|
|
PRODID:-//Google Inc//Google Calendar 70.9054//EN
|
|
VERSION:2.0
|
|
BEGIN:VEVENT
|
|
DTSTART:20171007T200000Z
|
|
DTEND:20171007T233000Z
|
|
DTSTAMP:20200319T182138Z
|
|
UID:4l80f6dcovnriq38g57g07btid@google.com
|
|
CREATED:20170719T202915Z
|
|
DESCRIPTION:
|
|
LAST-MODIFIED:20170930T190808Z
|
|
LOCATION:
|
|
SEQUENCE:1
|
|
STATUS:CONFIRMED
|
|
SUMMARY:Maryland Game
|
|
TRANSP:TRANSPARENT
|
|
END:VEVENT
|
|
BEGIN:VEVENT
|
|
DTSTART:20171002T010000Z
|
|
DTEND:20171002T020000Z
|
|
DTSTAMP:20200319T182138Z
|
|
UID:2v61g7mij4s7ieoubm3sjpun5d@google.com
|
|
CREATED:20171001T180103Z
|
|
DESCRIPTION:
|
|
LAST-MODIFIED:20171001T180103Z
|
|
LOCATION:
|
|
SEQUENCE:0
|
|
STATUS:CONFIRMED
|
|
SUMMARY:Halloween Wars
|
|
TRANSP:OPAQUE
|
|
END:VEVENT
|
|
END:VCALENDAR
|
|
"#,
|
|
)]);
|
|
let cwd = dirs.test();
|
|
|
|
let actual = nu_with_plugins!(
|
|
cwd: cwd,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open calendar.ics | get events.0 | length"
|
|
);
|
|
|
|
assert_eq!(actual.out, "2");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_ics_text_to_table() {
|
|
Playground::setup("filter_from_ics_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"calendar.txt",
|
|
r#"
|
|
BEGIN:VCALENDAR
|
|
BEGIN:VEVENT
|
|
DTSTART:20171007T200000Z
|
|
DTEND:20171007T233000Z
|
|
DTSTAMP:20200319T182138Z
|
|
UID:4l80f6dcovnriq38g57g07btid@google.com
|
|
CREATED:20170719T202915Z
|
|
DESCRIPTION:
|
|
LAST-MODIFIED:20170930T190808Z
|
|
LOCATION:
|
|
SEQUENCE:1
|
|
STATUS:CONFIRMED
|
|
SUMMARY:Maryland Game
|
|
TRANSP:TRANSPARENT
|
|
END:VEVENT
|
|
END:VCALENDAR
|
|
"#,
|
|
)]);
|
|
|
|
let cwd = dirs.test();
|
|
let actual = nu_with_plugins!(
|
|
cwd: cwd,
|
|
plugin: ("nu_plugin_formats"),
|
|
r#"
|
|
open calendar.txt
|
|
| from ics
|
|
| get events.0
|
|
| get properties.0
|
|
| where name == "SUMMARY"
|
|
| first
|
|
| get value
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "Maryland Game");
|
|
})
|
|
}
|