mirror of
https://github.com/nushell/nushell
synced 2024-12-29 06:23:11 +00:00
da7f77867a
# Description I noticed that some json values are not parsed at the top level, for example: `null`, `true`, `false`. Although this is a valid json. ``` > "null" | from json Error: × Error while parsing JSON text ╭─[entry #12:1:1] 1 │ "null" | from json · ────┬──── · ╰── error parsing JSON text ╰──── Error: × Error while parsing JSON text ╭──── 1 │ null ╰──── ``` I tried to fix it and it seems to work fine. # User-Facing Changes It should give fewer errors. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace --features=extra` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. Co-authored-by: sholderbach <sholderbach@users.noreply.github.com>
110 lines
3 KiB
Rust
110 lines
3 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn table_to_json_text_and_from_json_text_back_into_table() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open sgml_description.json
|
|
| to json
|
|
| from json
|
|
| get glossary.GlossDiv.GlossList.GlossEntry.GlossSee
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "markup");
|
|
}
|
|
|
|
#[test]
|
|
fn from_json_text_to_table() {
|
|
Playground::setup("filter_from_json_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"katz.txt",
|
|
r#"
|
|
{
|
|
"katz": [
|
|
{"name": "Yehuda", "rusty_luck": 1},
|
|
{"name": "Jonathan", "rusty_luck": 1},
|
|
{"name": "Andres", "rusty_luck": 1},
|
|
{"name":"GorbyPuff", "rusty_luck": 1}
|
|
]
|
|
}
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(),
|
|
"open katz.txt | from json | get katz | get rusty_luck | length "
|
|
);
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_json_text_recognizing_objects_independently_to_table() {
|
|
Playground::setup("filter_from_json_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"katz.txt",
|
|
r#"
|
|
{"name": "Yehuda", "rusty_luck": 1}
|
|
{"name": "Jonathan", "rusty_luck": 1}
|
|
{"name": "Andres", "rusty_luck": 1}
|
|
{"name":"GorbyPuff", "rusty_luck": 3}
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open katz.txt
|
|
| from json -o
|
|
| where name == "GorbyPuff"
|
|
| get rusty_luck.0
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn table_to_json_text() {
|
|
Playground::setup("filter_to_json_test", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"sample.txt",
|
|
r#"
|
|
JonAndrehudaTZ,3
|
|
GorbyPuff,100
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open sample.txt
|
|
| lines
|
|
| split column "," name luck
|
|
| select name
|
|
| to json
|
|
| from json
|
|
| get 0
|
|
| get name
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "JonAndrehudaTZ");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn top_level_values_from_json() {
|
|
for (value, type_name) in [("null", "nothing"), ("true", "bool"), ("false", "bool")] {
|
|
let actual = nu!(r#""{}" | from json | to json"#, value);
|
|
assert_eq!(actual.out, value);
|
|
let actual = nu!(r#""{}" | from json | describe"#, value);
|
|
assert_eq!(actual.out, type_name);
|
|
}
|
|
}
|