mirror of
https://github.com/nushell/nushell
synced 2024-12-27 05:23:11 +00:00
a332712275
# Description This PR adds a new function that allows one to get an env var case-insensitively. I did this so we can hopefully stop having problems when Windows has HKLM as path and HKCU as Path. Instead of just changing every function that used the original one, I chose the ones that I thought were specific to getting the path. I didn't want to go all in and make every env get case insensitive, but maybe we should? 🤷🏻♂️ closes #12676 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
75 lines
2.2 KiB
Rust
75 lines
2.2 KiB
Rust
use nu_protocol::{
|
|
engine::{EngineState, Stack},
|
|
Config, Span, Value,
|
|
};
|
|
use rstest::rstest;
|
|
|
|
#[test]
|
|
fn test_comparison_nothing() {
|
|
let values = vec![
|
|
Value::test_int(1),
|
|
Value::test_string("string"),
|
|
Value::test_float(1.0),
|
|
];
|
|
|
|
let nothing = Value::nothing(Span::test_data());
|
|
|
|
for value in values {
|
|
assert!(matches!(
|
|
value.eq(Span::test_data(), ¬hing, Span::test_data()),
|
|
Ok(Value::Bool { val: false, .. })
|
|
));
|
|
|
|
assert!(matches!(
|
|
value.ne(Span::test_data(), ¬hing, Span::test_data()),
|
|
Ok(Value::Bool { val: true, .. })
|
|
));
|
|
|
|
assert!(matches!(
|
|
nothing.eq(Span::test_data(), &value, Span::test_data()),
|
|
Ok(Value::Bool { val: false, .. })
|
|
));
|
|
|
|
assert!(matches!(
|
|
nothing.ne(Span::test_data(), &value, Span::test_data()),
|
|
Ok(Value::Bool { val: true, .. })
|
|
));
|
|
}
|
|
}
|
|
|
|
#[rstest]
|
|
#[case(365 * 24 * 3600 * 1_000_000_000, "52wk 1day")]
|
|
#[case( (((((((7 + 2) * 24 + 3) * 60 + 4) * 60) + 5) * 1000 + 6) * 1000 + 7) * 1000 + 8,
|
|
"1wk 2day 3hr 4min 5sec 6ms 7µs 8ns")]
|
|
fn test_duration_to_string(#[case] in_ns: i64, #[case] expected: &str) {
|
|
let dur = Value::test_duration(in_ns);
|
|
assert_eq!(
|
|
expected,
|
|
dur.to_expanded_string("", &Config::default()),
|
|
"expected != observed"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_case_insensitive_env_var() {
|
|
let mut engine_state = EngineState::new();
|
|
let stack = Stack::new();
|
|
|
|
for (name, value) in std::env::vars() {
|
|
engine_state.add_env_var(name, Value::test_string(value));
|
|
}
|
|
|
|
let path_lower = engine_state.get_env_var_insensitive("path");
|
|
let path_upper = engine_state.get_env_var_insensitive("PATH");
|
|
let path_mixed = engine_state.get_env_var_insensitive("PaTh");
|
|
|
|
assert_eq!(path_lower, path_upper);
|
|
assert_eq!(path_lower, path_mixed);
|
|
|
|
let stack_path_lower = stack.get_env_var_insensitive(&engine_state, "path");
|
|
let stack_path_upper = stack.get_env_var_insensitive(&engine_state, "PATH");
|
|
let stack_path_mixed = stack.get_env_var_insensitive(&engine_state, "PaTh");
|
|
|
|
assert_eq!(stack_path_lower, stack_path_upper);
|
|
assert_eq!(stack_path_lower, stack_path_mixed);
|
|
}
|