mirror of
https://github.com/nushell/nushell
synced 2025-01-08 11:18:58 +00:00
49ab559992
Closes #6337 and #5366. Prior to this PR, when "shelling out" to cmd.exe on Windows we were not trimming quotes correctly: ```bash 〉^echo "foo" \"foo\" ``` After this change, we do: ```bash 〉^echo "foo" foo ``` ### Breaking Change I ended up removing `dir` from the list of supported cmd.exe internal commands as part of this PR. For this PR, I extracted the argument-cleaning-and-expanding code from `spawn_simple_command()` for reuse in `spawn_cmd_command()`. This means that we now expand globs, which broke some tests for the `dir` cmd.exe internal command. I probably could have kept the tests working, but... tbh, I don't think it's worth it. I don't want to make the `cmd.exe` functionality any more complicated than it already is, and calling `dir` from Nu is always going to be weird+hacky compared to `ls`. |
||
|---|---|---|
| .. | ||
| benchmark.rs | ||
| complete.rs | ||
| exec.rs | ||
| mod.rs | ||
| nu_check.rs | ||
| ps.rs | ||
| registry_query.rs | ||
| run_external.rs | ||
| sys.rs | ||
| which_.rs | ||