mirror of
https://github.com/nushell/nushell
synced 2025-01-28 12:55:40 +00:00
02fc844e40
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> I had issues with the following tests: - `commands::network::http::delete::http_delete_timeout` - `commands::network::http::get::http_get_timeout` - `commands::network::http::options::http_options_timeout` - `commands::network::http::patch::http_patch_timeout` - `commands::network::http::post::http_post_timeout` - `commands::network::http::put::http_put_timeout` I checked what the actual issue was and my problem was that the tested string `"did not properly respond after a period of time"` wasn't in the actual error. This happened because my german Windows would return a german error message which obviosly did not include that string. To fix that I replaced the string check with the os error code that is also part of the error message which should be language agnostic. (I hope.) # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> None. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` \o/ # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
343 lines
8.3 KiB
Rust
343 lines
8.3 KiB
Rust
use std::{thread, time::Duration};
|
|
|
|
use mockito::Server;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn http_get_is_success() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server.mock("GET", "/").with_body("foo").create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
r#"
|
|
http get {url}
|
|
"#,
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert_eq!(actual.out, "foo")
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_failed_due_to_server_error() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server.mock("GET", "/").with_status(400).create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
r#"
|
|
http get {url}
|
|
"#,
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert!(actual.err.contains("Bad request (400)"))
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_with_accept_errors() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server
|
|
.mock("GET", "/")
|
|
.with_status(400)
|
|
.with_body("error body")
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
r#"
|
|
http get -e {url}
|
|
"#,
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert!(actual.out.contains("error body"))
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_with_accept_errors_and_full_raw_response() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server
|
|
.mock("GET", "/")
|
|
.with_status(400)
|
|
.with_body("error body")
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
r#"
|
|
http get -e -f {url} | $"($in.status) => ($in.body)"
|
|
"#,
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert!(actual.out.contains("400 => error body"))
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_with_accept_errors_and_full_json_response() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server
|
|
.mock("GET", "/")
|
|
.with_status(400)
|
|
.with_header("content-type", "application/json")
|
|
.with_body(
|
|
r#"
|
|
{"msg": "error body"}
|
|
"#,
|
|
)
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
r#"
|
|
http get -e -f {url} | $"($in.status) => ($in.body.msg)"
|
|
"#,
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert!(actual.out.contains("400 => error body"))
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_with_custom_headers_as_records() {
|
|
let mut server = Server::new();
|
|
|
|
let mock1 = server
|
|
.mock("GET", "/")
|
|
.match_header("content-type", "application/json")
|
|
.with_body(r#"{"hello": "world"}"#)
|
|
.create();
|
|
|
|
let mock2 = server
|
|
.mock("GET", "/")
|
|
.match_header("content-type", "text/plain")
|
|
.with_body("world")
|
|
.create();
|
|
|
|
let _json_response = nu!(format!(
|
|
"http get -H {{content-type: application/json}} {url}",
|
|
url = server.url()
|
|
));
|
|
|
|
let _text_response = nu!(format!(
|
|
"http get -H {{content-type: text/plain}} {url}",
|
|
url = server.url()
|
|
));
|
|
|
|
mock1.assert();
|
|
mock2.assert();
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_full_response() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server.mock("GET", "/").with_body("foo").create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
"http get --full {url} --headers [foo bar] | to json",
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
let output: serde_json::Value = serde_json::from_str(&actual.out).unwrap();
|
|
|
|
assert_eq!(output["status"], 200);
|
|
assert_eq!(output["body"], "foo");
|
|
|
|
// There's only one request header, we can get it by index
|
|
assert_eq!(output["headers"]["request"][0]["name"], "foo");
|
|
assert_eq!(output["headers"]["request"][0]["value"], "bar");
|
|
|
|
// ... and multiple response headers, so have to search by name
|
|
let header = output["headers"]["response"]
|
|
.as_array()
|
|
.unwrap()
|
|
.iter()
|
|
.find(|e| e["name"] == "connection")
|
|
.unwrap();
|
|
assert_eq!(header["value"], "close");
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_follows_redirect() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server.mock("GET", "/bar").with_body("bar").create();
|
|
let _mock = server
|
|
.mock("GET", "/foo")
|
|
.with_status(301)
|
|
.with_header("Location", "/bar")
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!("http get {url}/foo", url = server.url()).as_str()
|
|
));
|
|
|
|
assert_eq!(&actual.out, "bar");
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_redirect_mode_manual() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server
|
|
.mock("GET", "/foo")
|
|
.with_status(301)
|
|
.with_body("foo")
|
|
.with_header("Location", "/bar")
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
"http get --redirect-mode manual {url}/foo",
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert_eq!(&actual.out, "foo");
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_redirect_mode_error() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server
|
|
.mock("GET", "/foo")
|
|
.with_status(301)
|
|
.with_body("foo")
|
|
.with_header("Location", "/bar")
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
"http get --redirect-mode error {url}/foo",
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert!(&actual.err.contains("nu::shell::network_failure"));
|
|
assert!(&actual.err.contains(
|
|
"Redirect encountered when redirect handling mode was 'error' (301 Moved Permanently)"
|
|
));
|
|
}
|
|
|
|
// These tests require network access; they use badssl.com which is a Google-affiliated site for testing various SSL errors.
|
|
// Revisit this if these tests prove to be flaky or unstable.
|
|
//
|
|
// These tests are flaky and cause CI to fail somewhat regularly. See PR #12010.
|
|
|
|
#[test]
|
|
#[ignore = "unreliable test"]
|
|
fn http_get_expired_cert_fails() {
|
|
let actual = nu!("http get https://expired.badssl.com/");
|
|
assert!(actual.err.contains("network_failure"));
|
|
}
|
|
|
|
#[test]
|
|
#[ignore = "unreliable test"]
|
|
fn http_get_expired_cert_override() {
|
|
let actual = nu!("http get --insecure https://expired.badssl.com/");
|
|
assert!(actual.out.contains("<html>"));
|
|
}
|
|
|
|
#[test]
|
|
#[ignore = "unreliable test"]
|
|
fn http_get_self_signed_fails() {
|
|
let actual = nu!("http get https://self-signed.badssl.com/");
|
|
assert!(actual.err.contains("network_failure"));
|
|
}
|
|
|
|
#[test]
|
|
#[ignore = "unreliable test"]
|
|
fn http_get_self_signed_override() {
|
|
let actual = nu!("http get --insecure https://self-signed.badssl.com/");
|
|
assert!(actual.out.contains("<html>"));
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_with_invalid_mime_type() {
|
|
let mut server = Server::new();
|
|
|
|
let _mock = server
|
|
.mock("GET", "/foo.nuon")
|
|
.with_status(200)
|
|
// `what&ever` is not a parseable MIME type
|
|
.with_header("content-type", "what&ever")
|
|
.with_body("[1 2 3]")
|
|
.create();
|
|
|
|
// but `from nuon` is a known command in nu, so we take `foo.{ext}` and pass it to `from {ext}`
|
|
let actual = nu!(pipeline(
|
|
format!(
|
|
r#"http get {url}/foo.nuon | to json --raw"#,
|
|
url = server.url()
|
|
)
|
|
.as_str()
|
|
));
|
|
|
|
assert_eq!(actual.out, "[1,2,3]");
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_with_unknown_mime_type() {
|
|
let mut server = Server::new();
|
|
let _mock = server
|
|
.mock("GET", "/foo")
|
|
.with_status(200)
|
|
// `application/nuon` is not an IANA-registered MIME type
|
|
.with_header("content-type", "application/nuon")
|
|
.with_body("[1 2 3]")
|
|
.create();
|
|
|
|
// but `from nuon` is a known command in nu, so we take `{garbage}/{whatever}` and pass it to `from {whatever}`
|
|
let actual = nu!(pipeline(
|
|
format!(r#"http get {url}/foo | to json --raw"#, url = server.url()).as_str()
|
|
));
|
|
|
|
assert_eq!(actual.out, "[1,2,3]");
|
|
}
|
|
|
|
#[test]
|
|
fn http_get_timeout() {
|
|
let mut server = Server::new();
|
|
let _mock = server
|
|
.mock("GET", "/")
|
|
.with_chunked_body(|w| {
|
|
thread::sleep(Duration::from_secs(10));
|
|
w.write_all(b"Delayed response!")
|
|
})
|
|
.create();
|
|
|
|
let actual = nu!(pipeline(
|
|
format!("http get --max-time 100ms {url}", url = server.url()).as_str()
|
|
));
|
|
|
|
assert!(&actual.err.contains("nu::shell::network_failure"));
|
|
|
|
#[cfg(not(target_os = "windows"))]
|
|
assert!(&actual.err.contains("timed out reading response"));
|
|
#[cfg(target_os = "windows")]
|
|
assert!(&actual.err.contains(super::WINDOWS_ERROR_TIMEOUT_SLOW_LINK));
|
|
}
|