nushell/crates/nu-command/src/system
Himadri Bhattacharjee 02a920395c
fix: use environment variables to prevent command_not_found from recursing (#11090)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx

you can also mention related issues, PRs or discussions!
-->
- fixes #11014

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
When the `command_not_found` hook is entered, we set an environment
variable for context. If an unknown command is encountered and the
`command_not_found` context environment variable is already present, it
implies a command in the hook closure is also not found. We stop the
recursion right there.

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
Incorrect `command_not_found` hooks can be caught without panicking.

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
Tests are passing.

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-03-21 21:12:03 +02:00
..
complete.rs IO and redirection overhaul (#11934) 2024-03-14 15:51:55 -05:00
exec.rs IO and redirection overhaul (#11934) 2024-03-14 15:51:55 -05:00
mod.rs FreeBSD compatibility patches (#11869) 2024-02-17 20:04:59 +01:00
nu_check.rs Refactor nu-check (#12137) 2024-03-09 18:58:02 +02:00
ps.rs FreeBSD compatibility patches (#11869) 2024-02-17 20:04:59 +01:00
registry_query.rs Name the Value conversion functions more clearly (#11851) 2024-02-17 18:14:16 +00:00
run_external.rs fix: use environment variables to prevent command_not_found from recursing (#11090) 2024-03-21 21:12:03 +02:00
sys.rs Bump sysinfo from 0.29 to 0.30 (#11484) 2024-01-05 05:31:29 -06:00
which_.rs Fix incorrect handling of boolean flags for builtin commands (#11492) 2024-01-11 17:19:48 +02:00