# Description
This PR upgrades the Windows less version from v590 to v608
# User-Facing Changes
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
Following up on #7180 with some feature cleanup:
- Move the `database` feature from `plugin` to `default`
- Rename the `database` feature to `sqlite`
- Remove `--features=extra` from a lot of scripts etc.
- No need to specify this, the `extra` feature is now the same as the
default feature set
- Remove the now-redundant 2nd Ubuntu test run
Currently we see CI failures due to a `chrono` upgrade with
deprecations.
Also on every new reedline release we also suffer from regular compile
problems.
* Initialize join.rs as a copy of collect.rs
* Evolve StrCollect into StrJoin
* Replace 'str collect' with 'str join' everywhere
git ls-files | lines | par-each { |it| sed -i 's,str collect,str join,g' $it }
* Deprecate 'str collect'
* Revert "Deprecate 'str collect'"
This reverts commit 959d14203e.
* Change `str collect` help message to say that it is deprecated
We cannot remove `str collect` currently (i.e. via
`nu_protocol::ShellError::DeprecatedCommand` since a prominent project
uses the API:
b85542c31c/src/virtualenv/activation/nushell/activate.nu (L43)
Rename `all?`, `any?` and `empty?` to `all`, `any` and `is-empty` for sake of simplicity and consistency.
- More understandable for newcomers, that these commands are no special to others.
- `?` syntax did not really aprove readability. For me it made it worse.
- We can reserve `?` syntax for any other nushell feature.
Let's see, if we can use `cargo-cache` again for the tests after #6389
reduced the number of test binaries to build that are quite large due as
they statically link copies of the same engine.
This might be one of the reasons why the tests on windows exceeded the
allotted disk space.
* Add test requirements to PR template
* tweak words
* another tweak
* add /tests folder as a suggestion
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
We're no longer using `cargo nextest` for our main test job. The separate action for doctests was only necessary because `cargo nextest` does not support doctests, it can be removed.
Hoping this will result in less data cached but we'll see.
* Try removing debuginfo for ci builds
* oops, wrong inherits
* extra flag
* nextest doesn't support --profile in the same way
* try to allow for a ci-specific target
* Oops, run more tests
* Add cache+docs to plugin CI job
* CI perf: don't statically link OpenSSL
* Run Clippy in plugin job
* comment
* bust cache
* trigger build
* remove nextest, split plugins better
* trigger CI
* try disabling embed-resource
* try disabling libgit2 in shadow-rs
* use lld linker on Windows
* Skip embedding Windows resource (slow) during tests
* disable shadow-rs git integration during tests
* go back to simpler shadow-rs and embed-resources setup
* some renaming
* forgot nextest
* trigger ci
* Remove Clippy and unnecessary build
* trigger CI
* disable lld
* reenable lld
* cleanup
* revert embed_resource change
The faster `cargo nextest` currently doesn't support running the doctests.
Thus, add an additional step for them with cargo's default test runner.
- Fix doctests for the `nu-pretty-hex` crate
