2503 commits

Author	SHA1	Message	Date
JT	894e0f7658	bump to 0.84 (#10093)	2023-08-22 21:23:39 +03:00
JT	5378727049	Revert "pin serde to avoid https://github.com/serde-rs/serde/issues/2538" (#10078) ... Reverts nushell/nushell#10061 The latest serde (1.0.184) reverts the binary requirement.	2023-08-22 05:04:34 +12:00
Darren Schroeder	0786ddddbd	allow help to return a Type::Table (#10082) ... # Description This PR changes the signature of the `help` command so that it can return a `Type::Table`. closes #10077 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-21 07:46:44 -05:00
Jakub Žádník	3148acd3a4	Recursively export constants from modules (#10049) ... <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> https://github.com/nushell/nushell/pull/9773 introduced constants to modules and allowed to export them, but only within one level. This PR: * allows recursive exporting of constants from all submodules * fixes submodule imports in a list import pattern * makes sure exported constants are actual constants Should unblock https://github.com/nushell/nushell/pull/9678 ### Example: ```nushell module spam { export module eggs { export module bacon { export const viking = 'eats' } } } use spam print $spam.eggs.bacon.viking # prints 'eats' use spam [eggs] print $eggs.bacon.viking # prints 'eats' use spam eggs bacon viking print $viking # prints 'eats' ``` ### Limitation 1: Considering the above `spam` module, attempting to get `eggs bacon` from `spam` module doesn't work directly: ```nushell use spam [ eggs bacon ] # attempts to load `eggs`, then `bacon` use spam [ "eggs bacon" ] # obviously wrong name for a constant, but doesn't work also for commands ``` Workaround (for example): ```nushell use spam eggs use eggs [ bacon ] print $bacon.viking # prints 'eats' ``` I'm thinking I'll just leave it in, as you can easily work around this. It is also a limitation of the import pattern in general, not just constants. ### Limitation 2: `overlay use` successfully imports the constants, but `overlay hide` does not hide them, even though it seems to hide normal variables successfully. This needs more investigation. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> Allows recursive constant exports from submodules. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-20 14:51:35 +02:00
Darren Schroeder	e6ce8a89be	try and fix into datetime to accept more dt formats (#10063) ... # Description This PR tries to fix `into datetime`. The problem was that it didn't support many input formats and the `--format` was clunky. `--format` is still a bit clunky but can work. The big change here is that it first tries to use `dtparse` to convert text into datetime. ### Before ```nushell ❯ '20220604' | into datetime Thu, 01 Jan 1970 00:00:00 +0000 (53 years ago) ``` ### After ```nushell ❯ '20220604' | into datetime Sat, 04 Jun 2022 00:00:00 -0500 (a year ago) ``` ## Supported Input Formats `dtparse` should support all these formats. Taken from their [repo](https://github.com/bspeice/dtparse/blob/master/build_pycompat.py). ```python 'test_parse_default': [ "Thu Sep 25 10:36:28", "Sep 10:36:28", "10:36:28", "10:36", "Sep 2003", "Sep", "2003", "10h36m28.5s", "10h36m28s", "10h36m", "10h", "10 h 36", "10 h 36.5", "36 m 5", "36 m 5 s", "36 m 05", "36 m 05 s", "10h am", "10h pm", "10am", "10pm", "10:00 am", "10:00 pm", "10:00am", "10:00pm", "10:00a.m", "10:00p.m", "10:00a.m.", "10:00p.m.", "October", "31-Dec-00", "0:01:02", "12h 01m02s am", "12:08 PM", "01h02m03", "01h02", "01h02s", "01m02", "01m02h", "2004 10 Apr 11h30m", # testPertain 'Sep 03', 'Sep of 03', # test_hmBY - Note: This appears to be Python 3 only, no idea why '02:17NOV2017', # Weekdays "Thu Sep 10:36:28", "Thu 10:36:28", "Wed", "Wednesday" ], 'test_parse_simple': [ "Thu Sep 25 10:36:28 2003", "Thu Sep 25 2003", "2003-09-25T10:49:41", "2003-09-25T10:49", "2003-09-25T10", "2003-09-25", "20030925T104941", "20030925T1049", "20030925T10", "20030925", "2003-09-25 10:49:41,502", "199709020908", "19970902090807", "2003-09-25", "09-25-2003", "25-09-2003", "10-09-2003", "10-09-03", "2003.09.25", "09.25.2003", "25.09.2003", "10.09.2003", "10.09.03", "2003/09/25", "09/25/2003", "25/09/2003", "10/09/2003", "10/09/03", "2003 09 25", "09 25 2003", "25 09 2003", "10 09 2003", "10 09 03", "25 09 03", "03 25 Sep", "25 03 Sep", " July 4 , 1976 12:01:02 am ", "Wed, July 10, '96", "1996.July.10 AD 12:08 PM", "July 4, 1976", "7 4 1976", "4 jul 1976", "7-4-76", "19760704", "0:01:02 on July 4, 1976", "0:01:02 on July 4, 1976", "July 4, 1976 12:01:02 am", "Mon Jan 2 04:24:27 1995", "04.04.95 00:22", "Jan 1 1999 11:23:34.578", "950404 122212", "3rd of May 2001", "5th of March 2001", "1st of May 2003", '0099-01-01T00:00:00', '0031-01-01T00:00:00', "20080227T21:26:01.123456789", '13NOV2017', '0003-03-04', 'December.0031.30', # testNoYearFirstNoDayFirst '090107', # test_mstridx '2015-15-May', ], 'test_parse_tzinfo': [ 'Thu Sep 25 10:36:28 BRST 2003', '2003 10:36:28 BRST 25 Sep Thu', ], 'test_parse_offset': [ 'Thu, 25 Sep 2003 10:49:41 -0300', '2003-09-25T10:49:41.5-03:00', '2003-09-25T10:49:41-03:00', '20030925T104941.5-0300', '20030925T104941-0300', # dtparse-specific "2018-08-10 10:00:00 UTC+3", "2018-08-10 03:36:47 PM GMT-4", "2018-08-10 04:15:00 AM Z-02:00" ], 'test_parse_dayfirst': [ '10-09-2003', '10.09.2003', '10/09/2003', '10 09 2003', # testDayFirst '090107', # testUnambiguousDayFirst '2015 09 25' ], 'test_parse_yearfirst': [ '10-09-03', '10.09.03', '10/09/03', '10 09 03', # testYearFirst '090107', # testUnambiguousYearFirst '2015 09 25' ], 'test_parse_dfyf': [ # testDayFirstYearFirst '090107', # testUnambiguousDayFirstYearFirst '2015 09 25' ], 'test_unspecified_fallback': [ 'April 2009', 'Feb 2007', 'Feb 2008' ], 'test_parse_ignoretz': [ 'Thu Sep 25 10:36:28 BRST 2003', '1996.07.10 AD at 15:08:56 PDT', 'Tuesday, April 12, 1952 AD 3:30:42pm PST', 'November 5, 1994, 8:15:30 am EST', '1994-11-05T08:15:30-05:00', '1994-11-05T08:15:30Z', '1976-07-04T00:01:02Z', '1986-07-05T08:15:30z', 'Tue Apr 4 00:22:12 PDT 1995' ], 'test_fuzzy_tzinfo': [ 'Today is 25 of September of 2003, exactly at 10:49:41 with timezone -03:00.' ], 'test_fuzzy_tokens_tzinfo': [ 'Today is 25 of September of 2003, exactly at 10:49:41 with timezone -03:00.' ], 'test_fuzzy_simple': [ 'I have a meeting on March 1, 1974', # testFuzzyAMPMProblem 'On June 8th, 2020, I am going to be the first man on Mars', # testFuzzyAMPMProblem 'Meet me at the AM/PM on Sunset at 3:00 AM on December 3rd, 2003', # testFuzzyAMPMProblem 'Meet me at 3:00 AM on December 3rd, 2003 at the AM/PM on Sunset', # testFuzzyAMPMProblem 'Jan 29, 1945 14:45 AM I going to see you there?', # testFuzzyIgnoreAMPM '2017-07-17 06:15:', # test_idx_check ], ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-20 07:32:48 -05:00
JT	2ae1de2470	move 'bytes' back to commands (#10051) ... # Description Moves the `bytes XXXX` commands back to the default set.	2023-08-19 22:43:53 +02:00
Antoine Stevan	028a327ce8	Revert "deprecate --format and --list in into datetime (#10017)" (#10055) ... related to - https://github.com/nushell/nushell/issues/10017#issuecomment-1683082039 # Description this PR undeprecates `into datetime --format` and `into datetime --list`. this PR reverts commit f33b60c001. # User-Facing Changes # Tests + Formatting # After Submitting	2023-08-19 14:34:16 -05:00
JT	318862aad6	pin serde to avoid https://github.com/serde-rs/serde/issues/2538 (#10061) ... Context: https://github.com/serde-rs/serde/issues/2538 As other projects are investigating, this should pin serde to the last stable release before binary requirements were introduced. # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-20 05:50:26 +12:00
Darren Schroeder	98c7ab96b6	enable/update some example tests so they work again (#10058) ... # Description This PR updates some `Example` tests so that they work again. The only one I couldn't figure out is the one in the `filter` command. It should work but does not. However, I left the test in because it's valuable, it just has a `None` result. I'd like to fix this but I'm not sure how. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-19 09:06:59 -05:00
Jakub Žádník	fb908df17d	Add additional span to IncorrectValue error (#10036)	2023-08-18 20:47:05 +03:00
Jakub Žádník	fe2c498a81	Fix wrong path expansion in save (#10046)	2023-08-18 20:45:10 +03:00
Darren Schroeder	fe7122280d	allow int as a cellpath for select (#10048) ... Description This PR allows ints to be used as cell paths. ### Before ```nushell ❯ let index = 0 ❯ locations | select $index Error: nu:🐚:cant_convert × Can't convert to cell path. ╭─[entry #26:1:1] 1 │ locations | select $index · ───┬── · ╰── can't convert int to cell path ╰──── ``` ### After ```nushell ❯ let index = 0 ❯ locations | select $index ╭#┬───────location────────┬city_column┬state_column┬country_column┬lat_column┬lon_column╮ │0│http://ip-api.com/json/│city │region │countryCode │lat │lon │ ╰─┴───────────────────────┴───────────┴────────────┴──────────────┴──────────┴──────────╯ ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-18 10:16:18 -05:00
Jakub Žádník	2e0fb7c1a6	Change str replace to match substring by default (#10038)	2023-08-18 00:18:16 +03:00
Antoine Stevan	f33b60c001	deprecate --format and --list in into datetime (#10017) ... related to - https://discord.com/channels/601130461678272522/614593951969574961/1141009665266831470 # Description this PR - prints a colorful warning when a user uses either `--format` or `--list` on `into datetime` - does NOT remove the features for now, i.e. the two options still work - redirect to the `format date` command instead i propose to - land this now - prepare a removal PR right after this - land the removal PR in between 0.84 and 0.85 # User-Facing Changes `into datetime --format` and `into datetime --list` will be deprecated in 0.85. ## how it looks - `into datetime --list` in the REPL ```nushell > into datetime --list | first Error: × Deprecated option ╭─[entry #1:1:1] 1 │ into datetime --list | first · ──────┬────── · ╰── `into datetime --list` is deprecated and will be removed in 0.85 ╰──── help: see `format datetime --list` instead ╭───────────────┬────────────────────────────────────────────╮ │ Specification │ %Y │ │ Example │ 2023 │ │ Description │ The full proleptic Gregorian year, │ │ │ zero-padded to 4 digits. │ ╰───────────────┴────────────────────────────────────────────╯ ``` - `into datetime --list` in a script ```nushell > nu /tmp/foo.nu Error: × Deprecated option ╭─[/tmp/foo.nu:4:1] 4 │ # 5 │ into datetime --list | first · ──────┬────── · ╰── `into datetime --list` is deprecated and will be removed in 0.85 ╰──── help: see `format datetime --list` instead ╭───────────────┬────────────────────────────────────────────╮ │ Specification │ %Y │ │ Example │ 2023 │ │ Description │ The full proleptic Gregorian year, │ │ │ zero-padded to 4 digits. │ ╰───────────────┴────────────────────────────────────────────╯ ``` - `help into datetime`  # Tests + Formatting # After Submitting	2023-08-17 15:20:22 -05:00
Eugene Diachkin	ec5b9b9f37	Make http -f display the request headers. Closes #9912 (#10022) ... # Description As described in https://github.com/nushell/nushell/issues/9912, the `http` command could display the request headers with the `--full` flag, which could help in debugging the requests. This PR adds such functionality. # User-Facing Changes If `http get` or other `http` command which supports the `--full` flag is invoked with the flag, it used to display the `headers` key which contained an table of response headers. Now this key contains two nested keys: `response` and `request`, each of them being a table of the response and request headers accordingly. 	2023-08-17 09:19:10 -05:00
Jakub Žádník	e88a51e930	Refactor scope commands (#10023)	2023-08-17 11:58:38 +03:00
3lvir4	35f8d8548a	Remove potential panic from path join (#10012) ... Co-authored-by: amtoine <stevan.antoine@gmail.com>	2023-08-16 10:27:36 +03:00
Darren Schroeder	3ed45c7ba8	allow select to take a $variable with a list of columns (#9987) ... # Description This PR enables `select` to take a constructed list of columns as a variable. ```nushell > let cols = [name type];[[name type size]; [Cargo.toml toml 1kb] [Cargo.lock toml 2kb]] | select $cols ╭#┬───name───┬type╮ │0│Cargo.toml│toml│ │1│Cargo.lock│toml│ ╰─┴──────────┴────╯ ``` and rows ```nushell > let rows = [0 2];[[name type size]; [Cargo.toml toml 1kb] [Cargo.lock toml 2kb] [file.json json 3kb]] | select $rows ╭#┬───name───┬type┬size╮ │0│Cargo.toml│toml│1kb │ │1│file.json │json│3kb │ ╰─┴──────────┴────┴────╯ ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-15 07:01:45 -05:00
Maxim Zhiburt	696b2cda4a	nu-table: Fix padding 0 width issues (#10011) ... close #10001 cc: @fdncred @amtoine note: make sure you rebase/squash --------- Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>	2023-08-14 19:07:34 -05:00
Stefan Holderbach	435348aa61	Rename misused "deprecation" to removal (#10000) ... # Description In the past we named the process of completely removing a command and providing a basic error message pointing to the new alternative "deprecation". But this doesn't match the expectation of most users that have seen deprecation _warnings_ that alert to either impending removal or discouraged use after a stability promise. # User-Facing Changes Command category changed from `deprecated` to `removed`	2023-08-15 07:17:31 +12:00
dependabot[bot]	0a5f41abc2	Bump quick-xml from 0.29.0 to 0.30.0 (#9870)	2023-08-14 13:58:15 +00:00
Stefan Holderbach	5d94b16d71	Improve I/O types of into decimal(/float) (#9998) ... # Description - Add identity cast to `into decimal` (float->float) - Correct `into decimal` output to concrete float # User-Facing Changes `1.23 | into decimal` will now work. By fixing the output type it can now be used in conjunction with commands that expect `float`/`list<float>` # Tests + Formatting Adapts example to do identity cast and heterogeneous cast	2023-08-13 20:29:17 +02:00
Stefan Holderbach	3bd46fe27a	Add search terms to reject (#9996) ... # Description This may be easy to find/confuse with `drop` # User-Facing Changes Users coming from SQL will be happier when using `help -f` or `F1` # Tests + Formatting None	2023-08-13 20:27:29 +02:00
Reilly Wood	7b1c7debcb	Fix watch not handling all file changes (#9990) ... Closes https://github.com/nushell/nushell/issues/9910 I noticed that`watch` was not catching all filesystem changes, because some are reported as `ModifyKind::Data(DataChange::Any)` and we were only handling `ModifyKind::Data(DataChange::Content)`. Easy fix. This was happening on Ubuntu 23.04, ext4.	2023-08-12 14:34:40 -07:00
JT	e77a0a48aa	Rename main to script name when running scripts (#9948) ... # Description This PR does three related changes: * Keeps the originally declared name in help outputs. * Updates the name of the commands called `main` in the user script to the name of the script. * Fixes the source of signature information in multiple places. This allows scripts to have more complete help output. Combined, the above allow the user to see the script name in the help output of scripts, like so:  NOTE: You still declare and call the definition `main`, so from inside the script `main` is still the correct name. But multiple folks agreed that seeing `main` in the script help was confusing, so this PR changes that. # User-Facing Changes One potential minor breaking change is that module renames will be shown as their originally defined name rather than the renamed name. I believe this to be a better default. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-12 05:58:49 +12:00
Maxim Zhiburt	aa37572ddc	nu-table/ Add table.indent configuration (#9983) ... Hi there. Am I got it right? ref: https://github.com/zhiburt/tabled/issues/358 cc: @fdncred --------- Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>	2023-08-11 08:37:16 -05:00
Stefan Holderbach	a0cecf7658	Move format duration/filesize back into core (#9978) ... # Description Those two commands are very complementary to `into duration` and `into filesize` when you want to coerce a particular string output. This keeps the old `format` command with its separate formatting syntax still in `nu-cmd-extra`. # User-Facing Changes `format filesize` is back accessible with the default build. The new `format duration` command is also available to everybody # Tests + Formatting	2023-08-11 06:01:47 +12:00
Antoine Stevan	23170ff368	fix the signature of input list (#9977) ... # Description in its documentation, `input list` says it only accepts the following signatures - `list<any> -> list<any>` - `list<string> -> string` however this is incorrect as the following is allowed and even in the help page ```nushell [1 2 3] | input list # -> returns an `int` ``` this PR fixes the signature of `input list`. - with no option or `--fuzzy`, `input list` takes a `list<any>` and outputs a single `any` - with `--multi`, `input list` takes a `list<any>` and outputs a `list<any>` # User-Facing Changes the input output signature of `input list` is now ``` ╭───┬───────────┬───────────╮ │ # │ input │ output │ ├───┼───────────┼───────────┤ │ 0 │ list<any> │ list<any> │ │ 1 │ list<any> │ any │ ╰───┴───────────┴───────────╯ ``` # Tests + Formatting this shouldn't change anything as `[1 2 3] | input list` already works. # After Submitting	2023-08-10 16:44:59 +02:00
Antoine Stevan	202dfdaee2	fix panic with lines on an error (#9967) ... should close https://github.com/nushell/nushell/issues/9965 # Description this PR implements the `todo!()` left in `lines`. # User-Facing Changes ### before ```nushell > open . | lines thread 'main' panicked at 'not yet implemented', crates/nu-command/src/filters/lines.rs:248:35 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` ### after ```nushell > open . | lines Error: nu:🐚:io_error × I/O error help: Is a directory (os error 21) ``` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - ⚫ `toolkit test` - ⚫ `toolkit test stdlib` this PR adds the `lines_on_error` test to make sure this does not happen again 😌 # After Submitting	2023-08-09 14:12:58 +02:00
dependabot[bot]	02be83efbf	Bump rstest from 0.17.0 to 0.18.1 (#9782)	2023-08-08 17:11:05 +00:00
Antoine Stevan	b964347895	add a test to make sure "nothing" shows up as "nothing" in help (#9941) ... related to - https://github.com/nushell/nushell/pull/9935 # Description this PR just adds a test to make sure type annotations in `def`s show as `nothing` in the help pages of commands. # User-Facing Changes # Tests + Formatting adds a new test `nothing_type_annotation`. # After Submitting	2023-08-09 05:10:34 +12:00
panicbit	56ed1eb807	parse: collect external stream chunks before matching (#9950) ... <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx --> # Description This PR implements the workaround discussed in #9795, i.e. having `parse` collect an external stream before operating on it with a regex. - Should close #9795 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> - `parse` will give the correct output for external streams - increased memory and time overhead due to collecting the entire stream (no short-circuiting) # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - formatting is checked - clippy is happy - no tests that weren't already broken fail - added test case # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-08 06:48:13 -05:00
Bob Hyman	570175f95d	Fix duration type to not report months or years (#9632) ... <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> This PR should close #8036, #9028 (in the negative) and #9118. Fix for #9118 is a bit pedantic. As reported, the issue is: ``` > 2023-05-07T04:08:45+12:00 - 2019-05-10T09:59:12+12:00 3yr 12month 2day 18hr 9min 33sec ``` with this PR, you now get: ``` > 2023-05-07T04:08:45+12:00 - 2019-05-10T09:59:12+12:00 208wk 1day 18hr 9min 33sec ``` Which is strictly correct, but could still fairly be called "weird date arithmetic". # Description * [x] Abide by constraint that Value::Duration remains a number of nanoseconds with no additional fields. * [x] `to_string()` only displays weeks .. nanoseconds. Duration doesn't have base date to compute months or years from. * [x] `duration | into record` likewise only has fields for weeks .. nanoseconds. * [x] `string | into duration` now accepts compound form of duration to_string() (e.g '2day 3hr`, not just '2day') * [x] `duration | into string` now works (and produces the same representation as to_string(), which may be compound). # User-Facing Changes ## duration -> string -> duration Now you can "round trip" an arbitrary duration value: convert it to a string that may include multiple time units (a "compound" value), then convert that string back into a duration. This required changes to `string | into duration` and the addition of `duration | into string'. ``` > 2day + 3hr 2day 3hr # the "to_string()" representation (in this case, a compound value) > 2day + 3hr | into string 2day 3hr # string value > 2day + 3hr | into string | into duration 2day 3hr # round-trip duration -> string -> duration ``` Note that `to nuon` and `from nuon` already round-tripped durations, but use a different string representation. ## potentially breaking changes * string rendering of a duration no longer has 'yr' or 'month' phrases. * record from `duration | into record` no longer has 'year' or 'month' fields. The excess duration is all lumped into the `week` field, which is the largest time unit you can convert to without knowing the datetime from which the duration was calculated. Scripts that depended on month or year time units on output will need to be changed. ### Examples ``` > 365day 52wk 1day ## Used to be: ## 1yr > 365day | into record ╭──────┬────╮ │ week │ 52 │ │ day │ 1 │ │ sign │ + │ ╰──────┴────╯ ## used to be: ##╭──────┬───╮ ##│ year │ 1 │ ##│ sign │ + │ ##╰──────┴───╯ > (365day + 4wk + 5day + 6hr + 7min + 8sec + 9ms + 10us + 11ns) 56wk 6day 6hr 7min 8sec 9ms 10µs 11ns ## used to be: ## 1yr 1month 3day 6hr 7min 8sec 9ms 10µs 11ns ## which looks reasonable, but was actually only correct in 75% of the years and 25% of the months in the last 4 years. > (365day + 4wk + 5day + 6hr + 7min + 8sec + 9ms + 10us + 11ns) | into record ╭─────────────┬────╮ │ week │ 56 │ │ day │ 6 │ │ hour │ 6 │ │ minute │ 7 │ │ second │ 8 │ │ millisecond │ 9 │ │ microsecond │ 10 │ │ nanosecond │ 11 │ │ sign │ + │ ╰─────────────┴────╯ ``` Strictly speaking, these changes could break an existing user script. Losing years and months as time units is arguably a regression in behavior. Also, the corrected duration calculation could break an existing script that was calibrated using the old algorithm. # Tests + Formatting ``` > toolkit check pr ``` - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> --------- Co-authored-by: Bob Hyman <bobhy@localhost.localdomain>	2023-08-08 06:24:09 -05:00
JT	839010b89d	Auto-expand table based on terminal width (#9934) ... # Description This PR adds back the functionality to auto-expand tables based on the terminal width, using the logic that if the terminal is over 100 columns to expand. This sets the default config value in both the Rust and the default nushell config. To do so, it also adds back the ability for hooks to be strings of code and not just code blocks. Fixed a couple tests: two which assumed that the builtin display hook didn't use a table -e, and one that assumed a hook couldn't be a string. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-08 05:47:23 -05:00
JT	4accc67843	Move help commands to use more structure in signatures (#9949) ... # Description Signatures in `help commands` will now have more structure for params and input/output pairs. Example: Improved params  Improved input/output pairs  # User-Facing Changes This is technically a breaking change if previous code assumed the shape of things in `help commands`. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-08 08:33:01 +12:00
Ian Manske	c070e2d6f7	Make Value::columns return slice instead of cloned Vec (#9927) ... # Description This PR changes `Value::columns` to return a slice of columns instead of cloning said columns. If the caller needs an owned copy, they can use `slice::to_vec` or the like. This eliminates unnecessary Vec clones (e.g., in `update cells`). # User-Facing Changes Breaking change for `nu_protocol` API.	2023-08-07 21:43:32 +02:00
A. Taha Baki	d302d63030	str-expand: update bracoxide to v0.1.2, fixes #9913 (#9940) ... Fixes: #9913 Changes: - updated crate bracoxide from v0.1.1 to v0.1.2	2023-08-07 21:40:38 +02:00
Michael Angerman	b1974fae39	Categorification: move commands histogram and version out of the default category (#9946) ... * histogram to chart * version to core This completes moving commands out of the *Default* category... When you run ```rust nu -n --no-std-lib ``` ```rust help commands | where category == "default" ``` You now get an *Empty List* 😄	2023-08-07 09:23:53 -07:00
Michael Angerman	7248de1167	Categorification: move from Default category to Filters (#9945) ... The following *Filters* commands were incorrectly in the category *Default* * group-by * join * reduce * split-by * transpose This continues the effort of moving commands out of default and into their proper category...	2023-08-07 08:33:30 -07:00
Michael Angerman	bb6335830a	Categorification: move Path commands out of the default category (#9937) ... Path commands were incorrectly located in the default category... This PR moves all of the *Path* commands into their own Category called *Path*	2023-08-07 16:03:23 +12:00
Michael Angerman	bd3a61a2f7	Categorification: graduate nuon --- from the experimental category to the formats category (#9932) ... @jntrnr and I discussed the fact that we can now *graduate* nuon to be a first class citizen... This PR moves * from nuon * to nuon out of the *experimental* stage and into *formats*	2023-08-07 05:09:44 +12:00
Michael Angerman	fa2d9a8a58	Categorification: move uncategorized String commands to Category::Strings (#9931) ... In an effort to go through and review all of the remaining commands to find anything else that could possibly be moved to *nu-cmd-extra* I noticed that there are still some commands that have not been categorized... I am going to *Categorize* the remaining commands that still *do not have Category homes* In PR land I will call this *Categorification* as a play off of *Cratification* * str substring * str trim * str upcase were in the *default* category because for some reason they had not yet been categorized. I went ahead and moved them to the ```rust .category(Category::Strings) ```	2023-08-07 04:08:45 +12:00
Michael Angerman	58f98a4260	Cratification: move some str case commands to nu-cmd-extra (#9926) ... I am moving the following str case commands to nu-cmd-extra (as discussed in the core team meeting the other day) * camel-case * kebab-case * pascal-case * screaming-snake-case * snake-case * title-case	2023-08-06 06:40:44 -07:00
Antoine Stevan	dcb1a1996c	remove old deprecated commands (#9840) ... # Description in this PR i propose to remove the following old deprecated commands - `hash base64` -> `encode base64` - `math eval` -> `math <sub>` - `str to-datetime` -> `into datetime` - `str to-decimal` -> `into decimal` - `str find-replace` -> `str replace` - `str to-int` -> `into int` - `keep` -> `take` - `match` -> `find` - `nth` -> `select` - `pivot` -> `transpose` - `unalias` -> `hide` - `all?` -> `all` - `any?` -> `any` - `empty?` -> `is-empty` - `build-string` -> `str join` / string concatenation with `+` - `str lpad` -> `fill` - `str rpad` -> `fill` - `str collect` -> `str join` - `old-alias` -> `alias` so old i do not remember them at all 😮 i left the following four commands because they have been moved much more recently i think! - `fetch` -> `http get` - `post` -> `http post` - `benchmark` -> `timeit` - `let-env` - `date format` -> `format date` # User-Facing Changes # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - ⚫ `toolkit test` - ⚫ `toolkit test stdlib` # After Submitting	2023-08-06 06:42:16 -05:00
panicbit	6b4d06d8a7	do not emit None mid-stream during parse (#9925) ... <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #issue you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Currently `parse` acts like a `.filter` over an iterator, except that it emits `None` for elements that can't be parsed. This causes consumers of the adapted iterator to stop iterating too early. The correct behaviour is to keep pulling the inner iterator until either the end of it is reached or an element can be parsed. - this PR should close #9906 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> List streams won't be truncated anymore after the first parse failure. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - [-] `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - [x] `cargo test --workspace` to check that all tests pass - 11 tests fail, but the same 11 tests fail on main as well - [x] `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-06 06:17:03 -05:00
Ian Manske	f615038938	Enable macOS foreground process handling (#9909) ... # Description Currently, foreground process management is disabled for macOS, since the original code had issues (see #7068). This PR re-enables process management on macOS in combination with the changes from #9693. # User-Facing Changes Fixes hang on exit for nested nushells on macOS (issue #9859). Nushell should now manage processes in the same way on macOS and other unix systems.	2023-08-04 15:43:35 -05:00
Darren Schroeder	2b431f994f	updates let-env signature to remove required params (#9917) ... # Description This PR changes the signature of the deprecated command `let-env` so that it does not mislead people when invoking it without parameters. ### Before ```nushell > let-env Error: nu::parser::missing_positional × Missing required positional argument. ╭─[entry #2:1:1] 1 │ let-env ╰──── help: Usage: let-env <var_name> = <initial_value> ``` ### After ```nushell ❯ let-env Error: nu:🐚:deprecated_command × Deprecated command let-env ╭─[entry #1:1:1] 1 │ let-env · ───┬─── · ╰── 'let-env' is deprecated. Please use '$env.<environment variable> = ...' instead. ╰──── ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-08-04 14:06:41 -05:00
Maxim Zhiburt	7e096e61d7	Add an option to set header on border (style) (#9920) ... fix #9796 Sorry that you've had the issues. I've actually encountered them yesterday too (seems like they have appeared after some refactoring in the middle) but was not able to fix that rapid. Created a bunch of tests. cc: @fdncred Note: This option will be certainly slower then a default ones. (could be fixed but ... maybe later). Maybe it shall be cited somewhere. PS: Haven't tested on a wrapped/expanded tables. --------- Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com> Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>	2023-08-04 13:50:47 -05:00
JT	a98b3124c5	Revert "Add an option to move header on borders" (#9908) ... Reverts nushell/nushell#9796 This is just draft since we're seeing some issues with the latest fixes to table drawing that just landed with #9796. We're hoping to get these fixed, but if we're not able to fix them before the next release, we'll need to revert (hence this PR, just in case we need it).	2023-08-03 14:52:12 -05:00
Maxim Zhiburt	7162289d77	Add an option to move header on borders (#9796) ... A patch to play with. Need to make a few tests after all. The question is what shall be done with `table.mode = none`, as it has no borders. ```nu $env.config.table.move_header = true ```  cc: @fdncred --------- Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>	2023-08-04 07:03:20 +12:00