Mirrors/nushell
2
0
Fork 0
mirror of https://github.com/nushell/nushell synced 2024-11-15 09:27:08 +00:00
Code Issues Projects Releases Packages Wiki Activity

suppress the parser error for an insufficient number of required arguments if the named keyword argument 'help' is given (#1659)

Browse source
This commit is contained in:
rimathia 2020-04-25 18:45:45 +02:00 committed by GitHub
parent 846a779516
commit e7767ab7b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
crates/nu-cli/tests/commands/histogram.rs
View file

@ -30,3 +30,32 @@ fn summarizes() {
// 50%
})
}
#[test]
fn help() {
Playground::setup("histogram_test_help", |dirs, _sandbox| {
let help_command = nu!(
cwd: dirs.test(), pipeline(
r#"
help histogram
"#
));
let help_short = nu!(
cwd: dirs.test(), pipeline(
r#"
histogram -h
"#
));
let help_long = nu!(
cwd: dirs.test(), pipeline(
r#"
histogram --help
"#
));
assert_eq!(help_short, help_command);
assert_eq!(help_long, help_command);
})
}

13
crates/nu-parser/src/parse.rs
View file

@ -976,11 +976,14 @@ fn parse_internal_command(
}
}
if positional.len() < required_arg_count && error.is_none() {
let (_, name) = &signature.positional[positional.len()];
error = Some(ParseError::argument_error(
lite_cmd.name.clone(),
ArgumentError::MissingMandatoryPositional(name.to_owned()),
));
// to make "command -h" work even if required arguments are missing
if !named.named.contains_key("help") {
let (_, name) = &signature.positional[positional.len()];
error = Some(ParseError::argument_error(
lite_cmd.name.clone(),
ArgumentError::MissingMandatoryPositional(name.to_owned()),
));
}
}
if !named.is_empty() {