From b01cbf82c3c644e71c2c93e43c31e0f7d6d04a61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=B6rmet=20Yiltiz?= Date: Tue, 21 Mar 2023 23:13:07 -0500 Subject: [PATCH] Fix nu build script since for loops are stateful now (#8559) Need to get back to the src top directory after each `cd`. # Description _(Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes.)_ _(Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience.)_ # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --- build-all.nu | 1 + 1 file changed, 1 insertion(+) diff --git a/build-all.nu b/build-all.nu index 8a5a5346f0..c1909e4a37 100644 --- a/build-all.nu +++ b/build-all.nu @@ -20,5 +20,6 @@ for plugin in $plugins { '----------------------------' cd $'crates/($plugin)' cargo build + cd ../../ ignore }