From 92091599ffc1322257dbc280c42b147d419b32cd Mon Sep 17 00:00:00 2001 From: Stefan Holderbach Date: Fri, 6 Sep 2024 00:57:36 +0200 Subject: [PATCH] Fixup `serde` feature selection in `nu-protocol` (#13793) Discovered by @cptpiepmatz that #13749 broke the standalone check for `nu-protocol` Explicit use of the feature as workspace root also disables all features for `serde`. Alternatively we could reconsider this there. --- Cargo.toml | 2 +- crates/nu-protocol/Cargo.toml | 2 +- crates/nu_plugin_custom_values/Cargo.toml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 070269cf77..48bda05ba0 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -146,7 +146,7 @@ roxmltree = "0.19" rstest = { version = "0.18", default-features = false } rusqlite = "0.31" rust-embed = "8.5.0" -serde = { version = "1.0", default-features = false } +serde = { version = "1.0" } serde_json = "1.0" serde_urlencoded = "0.7.1" serde_yaml = "0.9" diff --git a/crates/nu-protocol/Cargo.toml b/crates/nu-protocol/Cargo.toml index ac44ade67f..37db9fd289 100644 --- a/crates/nu-protocol/Cargo.toml +++ b/crates/nu-protocol/Cargo.toml @@ -34,7 +34,7 @@ lru = { workspace = true } miette = { workspace = true, features = ["fancy-no-backtrace"] } num-format = { workspace = true } rmp-serde = { workspace = true, optional = true } -serde = { workspace = true, default-features = false } +serde = { workspace = true } thiserror = "1.0" typetag = "0.2" os_pipe = { workspace = true, features = ["io_safety"] } diff --git a/crates/nu_plugin_custom_values/Cargo.toml b/crates/nu_plugin_custom_values/Cargo.toml index 90e00b1feb..aa8d42bedf 100644 --- a/crates/nu_plugin_custom_values/Cargo.toml +++ b/crates/nu_plugin_custom_values/Cargo.toml @@ -12,8 +12,8 @@ bench = false [dependencies] nu-plugin = { path = "../nu-plugin", version = "0.97.2" } nu-protocol = { path = "../nu-protocol", version = "0.97.2", features = ["plugin"] } -serde = { workspace = true, default-features = false } +serde = { workspace = true } typetag = "0.2" [dev-dependencies] -nu-plugin-test-support = { path = "../nu-plugin-test-support", version = "0.97.2" } \ No newline at end of file +nu-plugin-test-support = { path = "../nu-plugin-test-support", version = "0.97.2" }