Mirrors/nushell
2
0
Fork 0
mirror of https://github.com/nushell/nushell synced 2024-12-28 14:03:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Incrementing the eager dataframe cache value before returning it (#13624)

Browse source 
# Description

Fixes issue [12828](https://github.com/nushell/nushell/issues/12828).

When attempting a `polars collect` on an eager dataframe, we return
dataframe as is. However, before this fix I failed to increment the
internal cache reference count. This caused the value to be dropped from
the internal cache when the references were decremented again.

This fix adds a call to cache.get to increment the value before
returning.
This commit is contained in:
Jack Wright 2024-08-14 13:38:46 -07:00 committed by GitHub
parent e690e7aac0
commit 803bc9c63f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/nu_plugin_polars/src/dataframe/lazy/collect.rs
View file

@ -75,6 +75,11 @@ impl PluginCommand for LazyCollect {
)) ))
} }
PolarsPluginObject::NuDataFrame(df) => { PolarsPluginObject::NuDataFrame(df) => {
// This should just increment the cache value.
// We can return a value back without incrementing the
// cache value or the value will be dropped (issue #12828)
let _ = plugin.cache.get(&df.id, true)?;
// just return the dataframe, add to cache again to be safe // just return the dataframe, add to cache again to be safe
Ok(PipelineData::Value( Ok(PipelineData::Value(
df.cache(plugin, engine, call.head)?.into_value(call.head), df.cache(plugin, engine, call.head)?.into_value(call.head),