Mirrors/nushell
2
0
Fork 0
mirror of https://github.com/nushell/nushell synced 2025-01-16 07:04:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

compile error to show issue

Browse source
This commit is contained in:
Michael Angerman 2021-10-26 21:04:48 -07:00
parent 6d6b850911
commit 5d62f1a9c1
1 changed files with 23 additions and 64 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

87
crates/nu-command/src/filters/last.rs
View file

@ -2,10 +2,8 @@ use nu_engine::CallExt;
use nu_protocol::ast::Call; use nu_protocol::ast::Call;
use nu_protocol::engine::{Command, EngineState, Stack}; use nu_protocol::engine::{Command, EngineState, Stack};
use nu_protocol::{PipelineData, ShellError, Signature, SyntaxShape, Value}; use nu_protocol::{IntoPipelineData, PipelineData, ShellError, Signature, SyntaxShape, Value};
use std::convert::TryInto;
//use nu_protocol::{IntoPipelineData, PipelineData, ShellError, Signature, SyntaxShape, Value};
//use std::convert::TryInto;
#[derive(Clone)] #[derive(Clone)]
pub struct Last; pub struct Last;
@ -35,72 +33,33 @@ impl Command for Last {
input: PipelineData, input: PipelineData,
) -> Result<PipelineData, ShellError> { ) -> Result<PipelineData, ShellError> {
let rows: Option<i64> = call.opt(engine_state, stack, 0)?; let rows: Option<i64> = call.opt(engine_state, stack, 0)?;
let iter_count: i64 = input.into_iter().count() as i64; let iter_count: i64 = input.into_iter().count() as i64;
let beginning_rows_to_skip = rows_to_skip(iter_count, rows); let beginning_rows_to_skip = rows_to_skip(iter_count, rows);
dbg!(beginning_rows_to_skip); dbg!(beginning_rows_to_skip);
// This code works fine and does the correct // let beginning_rows_to_skip = 3;
// calculation of the beginning_rows_to_skip
// but it can not currently be used because
// I am not able to clone the input
/* match input {
let vlength = length(input)?; PipelineData::Stream(stream) => {
dbg!(vlength); dbg!("Stream");
Ok(stream
.skip(beginning_rows_to_skip.try_into().unwrap())
.into_pipeline_data())
}
PipelineData::Value(Value::List { vals, .. }) => {
dbg!("Value");
Ok(vals
.into_iter()
.skip(beginning_rows_to_skip.try_into().unwrap())
.into_pipeline_data())
}
_ => {
dbg!("Fall to the bottom");
Ok(PipelineData::Value(Value::Nothing { span: call.head }))
}
}
let end_rows_desired = if let Some(quantity) = rows { // Ok(PipelineData::Value(Value::Nothing { span: call.head }))
quantity
} else {
1
};
let beginning_rows_to_skip = if end_rows_desired < vlength {
vlength - end_rows_desired
} else {
0
};
*/
// This code works fine if I am able to get this value
// So for now I am hard coding this number
// The above code successfully calculates this number
// and it all works if I was able to clone the input
// it seems being able to
// clone the input is important
// As we were able to do that prior to your changes...
/*
let beginning_rows_to_skip = 2;
match input {
PipelineData::Stream(stream) => {
dbg!("Stream");
Ok(stream
.skip(beginning_rows_to_skip.try_into().unwrap())
.into_pipeline_data())
}
PipelineData::Value(Value::List { vals, .. }) => {
dbg!("Value");
Ok(vals
.into_iter()
.skip(beginning_rows_to_skip.try_into().unwrap())
.into_pipeline_data())
}
_ => {
dbg!("Fall to the bottom");
Ok(PipelineData::Value(Value::Nothing { span: call.head }))
}
}
*/
Ok(PipelineData::Value(Value::Nothing { span: call.head }))
} }
} }