Mirrors/nushell
2
0
Fork 0
mirror of https://github.com/nushell/nushell synced 2024-12-27 05:23:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Allow for and other commands missing positionals near keywords (#606)

Browse source 
* Allow for and other commands missing positionals near keywords

* A bit more resilience
This commit is contained in:
JT 2021-12-28 07:04:48 +11:00 committed by GitHub
parent 5c94528fe2
commit 384ea111eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/nu-parser/src/parser.rs
View file

@ -596,6 +596,17 @@ pub fn parse_internal_call(
// spans_idx, end, positional_idx // spans_idx, end, positional_idx
// ); // );
if spans[..end].is_empty() {
error = error.or_else(|| {
Some(ParseError::MissingPositional(
positional.name.clone(),
spans[spans_idx],
))
});
positional_idx += 1;
continue;
}
let orig_idx = spans_idx; let orig_idx = spans_idx;
let (arg, err) = parse_multispan_value( let (arg, err) = parse_multispan_value(
working_set, working_set,

5
src/tests/test_parser.rs
View file

@ -118,3 +118,8 @@ fn long_flag() -> TestResult {
fn let_not_statement() -> TestResult { fn let_not_statement() -> TestResult {
fail_test(r#"let x = "hello" | str length"#, "can't") fail_test(r#"let x = "hello" | str length"#, "can't")
} }
#[test]
fn for_in_missing_var_name() -> TestResult {
fail_test("for in", "missing")
}