Split extra (#2348)

* Split default/extra plugins

* Oops, too many deletes

* Pipelines

.azure/azure-pipelines.yml

@@ -9,6 +9,9 @@ strategy:
     linux-minimal:
       image: ubuntu-18.04
       style: 'minimal'
+    linux-extra:
+      image: ubuntu-18.04
+      style: 'extra'
     macos-stable:
       image: macos-10.14
       style: 'unflagged'
@@ -49,21 +52,24 @@ steps:
   #     echo "##vso[task.prependpath]$HOME/.cargo/bin"
   #     rustup component add rustfmt
     displayName: Install Rust
-  - bash: RUSTFLAGS="-D warnings" cargo test --all --features stable
+  - bash: RUSTFLAGS="-D warnings" cargo test --all
     condition: eq(variables['style'], 'unflagged')
     displayName: Run tests
-  - bash: RUSTFLAGS="-D warnings" cargo clippy --all --features=stable -- -D clippy::unwrap_used
+  - bash: RUSTFLAGS="-D warnings" cargo clippy --all -- -D clippy::unwrap_used
     condition: eq(variables['style'], 'unflagged')
     displayName: Check clippy lints
-  - bash: RUSTFLAGS="-D warnings" cargo test --all --features stable
+  - bash: RUSTFLAGS="-D warnings" cargo test --all
     condition: eq(variables['style'], 'canary')
     displayName: Run tests
-  - bash: RUSTFLAGS="-D warnings" cargo clippy --all --features=stable -- -D clippy::unwrap_used
+  - bash: RUSTFLAGS="-D warnings" cargo clippy --all -- -D clippy::unwrap_used
     condition: eq(variables['style'], 'canary')
     displayName: Check clippy lints
   - bash: RUSTFLAGS="-D warnings" cargo test --all --no-default-features
     condition: eq(variables['style'], 'minimal')
     displayName: Run tests
+  - bash: RUSTFLAGS="-D warnings" cargo test --all --features=extra
+    condition: eq(variables['style'], 'extra')
+    displayName: Run tests
   - bash: cargo fmt --all -- --check
     condition: eq(variables['style'], 'fmt')
     displayName: Lint

Cargo.lock

@@ -3335,7 +3335,6 @@ version = "0.18.2"
 dependencies = [
  "ansi_term 0.12.1",
  "bat",
- "crossterm",
  "nu-cli",
  "nu-errors",
  "nu-plugin",

Cargo.toml

@@ -74,8 +74,12 @@ default = [
   "ptree-support",
   "term-support",
   "uuid-support",
+  "match",
+  "post",
+  "fetch"
 ]
-stable = ["default", "binaryview", "match", "tree", "post", "fetch", "clipboard-cli", "trash-support", "start", "bson", "sqlite", "s3"]
+stable = ["default"]
+extra = ["default", "binaryview", "tree", "clipboard-cli", "trash-support", "start", "bson", "sqlite", "s3"]
 
 # Default
 inc = ["semver", "nu_plugin_inc"]
@@ -128,40 +132,41 @@ name = "nu_plugin_core_sys"
 path = "src/plugins/nu_plugin_core_sys.rs"
 required-features = ["sys"]
 
-# Stable plugins
 [[bin]]
-name = "nu_plugin_stable_fetch"
+name = "nu_plugin_core_fetch"
-path = "src/plugins/nu_plugin_stable_fetch.rs"
+path = "src/plugins/nu_plugin_core_fetch.rs"
 required-features = ["fetch"]
 
 [[bin]]
-name = "nu_plugin_stable_binaryview"
+name = "nu_plugin_core_match"
-path = "src/plugins/nu_plugin_stable_binaryview.rs"
+path = "src/plugins/nu_plugin_core_match.rs"
-required-features = ["binaryview"]
-
-[[bin]]
-name = "nu_plugin_stable_match"
-path = "src/plugins/nu_plugin_stable_match.rs"
 required-features = ["match"]
 
 [[bin]]
-name = "nu_plugin_stable_post"
+name = "nu_plugin_core_post"
-path = "src/plugins/nu_plugin_stable_post.rs"
+path = "src/plugins/nu_plugin_core_post.rs"
 required-features = ["post"]
 
+# Extra plugins
+
 [[bin]]
-name = "nu_plugin_stable_tree"
+name = "nu_plugin_extra_binaryview"
-path = "src/plugins/nu_plugin_stable_tree.rs"
+path = "src/plugins/nu_plugin_extra_binaryview.rs"
+required-features = ["binaryview"]
+
+[[bin]]
+name = "nu_plugin_extra_tree"
+path = "src/plugins/nu_plugin_extra_tree.rs"
 required-features = ["tree"]
 
 [[bin]]
-name = "nu_plugin_stable_start"
+name = "nu_plugin_extra_start"
-path = "src/plugins/nu_plugin_stable_start.rs"
+path = "src/plugins/nu_plugin_extra_start.rs"
 required-features = ["start"]
 
 [[bin]]
-name = "nu_plugin_stable_s3"
+name = "nu_plugin_extra_s3"
-path = "src/plugins/nu_plugin_stable_s3.rs"
+path = "src/plugins/nu_plugin_extra_s3.rs"
 required-features = ["s3"]
 
 # Main nu binary

crates/nu_plugin_textview/Cargo.toml

@@ -18,8 +18,6 @@ nu-source = {path = "../nu-source", version = "0.18.2"}
 
 ansi_term = "0.12.1"
 bat = {version = "0.15.4", features = ["regex-fancy", "paging"]}
-
-crossterm = "0.17.5"
 term_size = "0.3.2"
 url = "2.1.1"