Mirrors/nushell
2
0
Fork 0
mirror of https://github.com/nushell/nushell synced 2024-12-27 05:23:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix 'skip' support for binary streams (#5943)

Browse source
This commit is contained in:
JT 2022-07-04 19:53:54 +12:00 committed by GitHub
parent c16d8f0d5f
commit 2da8310b11
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/nu-command/src/filters/skip/skip_.rs
View file

@ -93,18 +93,17 @@ impl Command for Skip {
let bytes = val.as_bytes();
if bytes.len() < remaining {
remaining -= bytes.len();
output.extend_from_slice(bytes)
//output.extend_from_slice(bytes)
} else {
output.extend_from_slice(&bytes[0..remaining]);
output.extend_from_slice(&bytes[remaining..]);
break;
}
}
Value::Binary { val: bytes, .. } => {
if bytes.len() < remaining {
remaining -= bytes.len();
output.extend_from_slice(&bytes)
} else {
output.extend_from_slice(&bytes[0..remaining]);
output.extend_from_slice(&bytes[remaining..]);
break;
}
}

1
crates/nu-command/tests/commands/skip/mod.rs
View file

@ -1,2 +1,3 @@
mod skip_;
mod until;
mod while_;

16
crates/nu-command/tests/commands/skip/skip_.rs Normal file
View file

@ -0,0 +1,16 @@
use nu_test_support::{nu, pipeline};
#[test]
fn binary_skip() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
r#"
open sample_data.ods --raw |
skip 2 |
take 2 |
into int
"#
));
assert_eq!(actual.out, "772");
}