From 21d30d1e4d83826ab7836dd65e8ffeb4a42e5ea5 Mon Sep 17 00:00:00 2001 From: Ian Manske Date: Sat, 9 Sep 2023 00:03:30 +0000 Subject: [PATCH] Fix `rm` on macOS (#10282) # Description Removes the signal ignore for `SIGCHLD` added by #10021, since it interferes with `rm` on macOS. --- src/terminal.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/terminal.rs b/src/terminal.rs index fe54c99ff0..9a653647e6 100644 --- a/src/terminal.rs +++ b/src/terminal.rs @@ -34,7 +34,9 @@ pub(crate) fn acquire_terminal(interactive: bool) { signal(Signal::SIGTSTP, SigHandler::SigIgn).expect("signal ignore"); signal(Signal::SIGTTIN, SigHandler::SigIgn).expect("signal ignore"); signal(Signal::SIGTTOU, SigHandler::SigIgn).expect("signal ignore"); - signal(Signal::SIGCHLD, SigHandler::SigIgn).expect("signal ignore"); + + // TODO: determine if this is necessary or not, since this breaks `rm` on macOS + // signal(Signal::SIGCHLD, SigHandler::SigIgn).expect("signal ignore"); signal_hook::low_level::register(signal_hook::consts::SIGTERM, || { // Safety: can only call async-signal-safe functions here