mirror of
https://github.com/nushell/nushell
synced 2024-12-26 13:03:07 +00:00
fix: 🐛 handle windows Path casing (#9210)
# Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> PATH and Path are different (in nushell at least) based on the OS # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> None the command now works as expected # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
parent
acd7c98c39
commit
1de57eb2b6
2 changed files with 20 additions and 13 deletions
|
@ -38,14 +38,17 @@ export def-env "path add" [
|
||||||
--append (-a) # append to $env.PATH instead of prepending to.
|
--append (-a) # append to $env.PATH instead of prepending to.
|
||||||
...paths # the paths to add to $env.PATH.
|
...paths # the paths to add to $env.PATH.
|
||||||
] {
|
] {
|
||||||
let-env PATH = (
|
let path_name = if "PATH" in $env { "PATH" } else { "Path" }
|
||||||
$env.PATH
|
|
||||||
| if $append { append $paths }
|
|
||||||
else { prepend $paths }
|
|
||||||
)
|
|
||||||
|
|
||||||
|
let-env $path_name = (
|
||||||
|
$env
|
||||||
|
| get $path_name
|
||||||
|
| if $append { append $paths }
|
||||||
|
else { prepend $paths }
|
||||||
|
)
|
||||||
|
|
||||||
if $ret {
|
if $ret {
|
||||||
$env.PATH
|
$env | get $path_name
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -3,23 +3,27 @@ use std
|
||||||
export def test_path_add [] {
|
export def test_path_add [] {
|
||||||
use std "assert equal"
|
use std "assert equal"
|
||||||
|
|
||||||
with-env [PATH []] {
|
let path_name = if "PATH" in $env { "PATH" } else { "Path" }
|
||||||
assert equal $env.PATH []
|
|
||||||
|
with-env [$path_name []] {
|
||||||
|
def get_path [] { $env | get $path_name }
|
||||||
|
|
||||||
|
assert equal (get_path) []
|
||||||
|
|
||||||
std path add "/foo/"
|
std path add "/foo/"
|
||||||
assert equal $env.PATH ["/foo/"]
|
assert equal (get_path) ["/foo/"]
|
||||||
|
|
||||||
std path add "/bar/" "/baz/"
|
std path add "/bar/" "/baz/"
|
||||||
assert equal $env.PATH ["/bar/", "/baz/", "/foo/"]
|
assert equal (get_path) ["/bar/", "/baz/", "/foo/"]
|
||||||
|
|
||||||
let-env PATH = []
|
let-env $path_name = []
|
||||||
|
|
||||||
std path add "foo"
|
std path add "foo"
|
||||||
std path add "bar" "baz" --append
|
std path add "bar" "baz" --append
|
||||||
assert equal $env.PATH ["foo", "bar", "baz"]
|
assert equal (get_path) ["foo", "bar", "baz"]
|
||||||
|
|
||||||
assert equal (std path add "fooooo" --ret) ["fooooo", "foo", "bar", "baz"]
|
assert equal (std path add "fooooo" --ret) ["fooooo", "foo", "bar", "baz"]
|
||||||
assert equal $env.PATH ["fooooo", "foo", "bar", "baz"]
|
assert equal (get_path) ["fooooo", "foo", "bar", "baz"]
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue