Merge pull request #236 from androbtech/meta_magic_save_test

Test coverage for pull #235

tests/commands_test.rs

@@ -81,11 +81,30 @@ fn open_error_if_file_not_found() {
     assert!(output.contains("File could not be opened"));
 }
 
+#[test]
+fn save_figures_out_intelligently_where_to_write_out_with_metadata() {
+    let (playground_path, tests_dir) = h::setup_playground_for("save_smart_test");
+
+    let full_path     = format!("{}/{}", playground_path, tests_dir);
+    let subject_file  = format!("{}/{}", full_path      , "cargo_sample.toml");
+
+    h::copy_file_to("tests/fixtures/formats/cargo_sample.toml", &subject_file);
+
+    nu!(
+        _output,
+        cwd("tests/fixtures"),
+        "open nuplayground/save_smart_test/cargo_sample.toml | inc package.version --minor | save"
+    );
+
+    let actual = h::file_contents(&subject_file);
+    assert!(actual.contains("0.2.0"));
+}
+
 #[test]
 fn save_can_write_out_csv() {
     let (playground_path, tests_dir) = h::setup_playground_for("save_test");
 
-    let full_path     = format!("{}/{}", playground_path, tests_dir         );
+    let full_path     = format!("{}/{}", playground_path, tests_dir);
     let expected_file = format!("{}/{}", full_path      , "cargo_sample.csv");
 
     nu!(
@@ -102,8 +121,8 @@ fn save_can_write_out_csv() {
 fn cp_can_copy_a_file() {
     let (playground_path, tests_dir) = h::setup_playground_for("cp_test");
 
-    let full_path     = format!("{}/{}", playground_path, tests_dir         );
-    let expected_file = format!("{}/{}", full_path      , "sample.ini"      );
+    let full_path     = format!("{}/{}", playground_path, tests_dir);
+    let expected_file = format!("{}/{}", full_path      , "sample.ini");
 
     nu!(
         _output,
@@ -118,8 +137,8 @@ fn cp_can_copy_a_file() {
 fn cp_copies_the_file_inside_directory_if_path_to_copy_is_directory() {
     let (playground_path, tests_dir) = h::setup_playground_for("cp_test_2");
 
-    let full_path     = format!("{}/{}", playground_path, tests_dir         );
-    let expected_file = format!("{}/{}", full_path      , "sample.ini"      );
+    let full_path     = format!("{}/{}", playground_path, tests_dir);
+    let expected_file = format!("{}/{}", full_path      , "sample.ini");
 
     nu!(
         _output,
@@ -151,7 +170,11 @@ fn rm_can_remove_a_file() {
 
     h::create_file_at(&file);
 
-    nu!(_output, cwd(directory), "rm rm_test.txt");
+    nu!(
+        _output,
+        cwd(directory),
+        "rm rm_test.txt"
+    );
 
     assert!(!h::file_exists_at(&file));
 }
@@ -178,23 +201,36 @@ fn rm_error_if_attempting_to_delete_a_directory_without_recursive_flag() {
     let (playground_path, tests_dir) = h::setup_playground_for("rm_test_2");
     let full_path = format!("{}/{}", playground_path, tests_dir);
 
-    nu_error!(output, cwd("tests/fixtures/nuplayground"), "rm rm_test_2");
+    nu_error!(
+        output,
+        cwd("tests/fixtures/nuplayground"),
+        "rm rm_test_2"
+    );
 
     assert!(h::file_exists_at(&full_path));
     assert!(output.contains("is a directory"));
-    h::delete_directory_at(&full_path);
 }
 
 #[test]
 fn rm_error_if_attempting_to_delete_single_dot_as_argument() {
-    nu_error!(output, cwd("tests/fixtures/nuplayground"), "rm .");
+
+    nu_error!(
+        output,
+        cwd("tests/fixtures/nuplayground"),
+        "rm ."
+    );
 
     assert!(output.contains("may not be removed"));
 }
 
 #[test]
 fn rm_error_if_attempting_to_delete_two_dot_as_argument() {
-    nu_error!(output, cwd("tests/fixtures/nuplayground"), "rm ..");
+
+    nu_error!(
+        output,
+        cwd("tests/fixtures/nuplayground"), 
+        "rm .."
+    );
 
     assert!(output.contains("may not be removed"));
 }

tests/filters_test.rs

@@ -15,7 +15,8 @@ fn can_convert_table_to_csv_text_and_from_csv_text_back_into_table() {
 
 #[test]
 fn can_convert_table_to_json_text_and_from_json_text_back_into_table() {
-    nu!(output,
+    nu!(
+        output,
         cwd("tests/fixtures/formats"),
         "open sgml_description.json | to-json | from-json | get glossary.GlossDiv.GlossList.GlossEntry.GlossSee | echo $it"
     );
@@ -47,7 +48,8 @@ fn can_convert_table_to_yaml_text_and_from_yaml_text_back_into_table() {
 
 #[test]
 fn can_sort_by_column() {
-    nu!(output,
+    nu!(
+        output,
         cwd("tests/fixtures/formats"),
         "open cargo_sample.toml --raw | lines | skip 1 | first 4 | split-column \"=\" | sort-by Column1 | skip 1 | first 1 | get Column1 | trim | echo $it"
     );
@@ -57,7 +59,8 @@ fn can_sort_by_column() {
 
 #[test]
 fn can_split_by_column() {
-    nu!(output,
+    nu!(
+        output,
         cwd("tests/fixtures/formats"),
         "open cargo_sample.toml --raw | lines | skip 1 | first 1 | split-column \"=\" | get Column1 | trim | echo $it"
     );

tests/helpers/mod.rs

@@ -7,9 +7,9 @@ use std::io::Read;
 #[macro_export]
 macro_rules! nu {
     ($out:ident, $cwd:expr, $commands:expr) => {
+        pub use std::error::Error;
         pub use std::io::prelude::*;
         pub use std::process::{Command, Stdio};
-        pub use std::error::Error;
 
         let commands = &*format!(
             "
@@ -95,7 +95,8 @@ pub fn setup_playground_for(topic: &str) -> (String, String) {
 pub fn file_contents(full_path: &str) -> String {
     let mut file = std::fs::File::open(full_path).expect("can not open file");
     let mut contents = String::new();
-  file.read_to_string(&mut contents).expect("can not read file");
+    file.read_to_string(&mut contents)
+        .expect("can not read file");
     contents
 }
 
@@ -103,6 +104,10 @@ pub fn create_file_at(full_path: &str) {
     std::fs::write(PathBuf::from(full_path), "fake data".as_bytes()).expect("can not create file");
 }
 
+pub fn copy_file_to(source: &str, destination: &str) {
+    std::fs::copy(source, destination).expect("can not copy file");
+}
+
 pub fn file_exists_at(full_path: &str) -> bool {
     PathBuf::from(full_path).exists()
 }

tests/tests.rs

@@ -15,9 +15,11 @@ fn external_num() {
 
 #[test]
 fn inc_plugin() {
-    nu!(output,
+    nu!(
+        output,
         cwd("tests/fixtures/formats"),
-        "open sgml_description.json | get glossary.GlossDiv.GlossList.GlossEntry.Height | inc | echo $it");
+        "open sgml_description.json | get glossary.GlossDiv.GlossList.GlossEntry.Height | inc | echo $it"
+    );
 
     assert_eq!(output, "11");
 }
@@ -26,7 +28,8 @@ fn inc_plugin() {
 fn add_plugin() {
     nu!(output,
         cwd("tests/fixtures/formats"),
-        "open cargo_sample.toml | add dev-dependencies.newdep \"1\" | get dev-dependencies.newdep | echo $it");
+        "open cargo_sample.toml | add dev-dependencies.newdep \"1\" | get dev-dependencies.newdep | echo $it"
+    );
 
     assert_eq!(output, "1");
 }
@@ -35,7 +38,8 @@ fn add_plugin() {
 fn edit_plugin() {
     nu!(output,
         cwd("tests/fixtures/formats"),
-        "open cargo_sample.toml | edit dev-dependencies.pretty_assertions \"7\" | get dev-dependencies.pretty_assertions | echo $it");
+        "open cargo_sample.toml | edit dev-dependencies.pretty_assertions \"7\" | get dev-dependencies.pretty_assertions | echo $it"
+    );
 
     assert_eq!(output, "7");
 }