Mirrors/nushell
2
0
Fork 0
mirror of https://github.com/nushell/nushell synced 2024-12-26 04:53:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Restrict short-hand flag detection to exact match. (#1406)

Browse source
This commit is contained in:
Andrés N. Robalino 2020-02-18 01:58:30 -05:00 committed by GitHub
parent 0f7c723672
commit 18d988d4c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/nu-parser/src/parse/token_tree.rs
View file

@ -368,8 +368,13 @@ impl SpannedToken {
match flag.kind {
FlagKind::Longhand if value == name => Some(*flag),
FlagKind::Shorthand if short.is_some() && short == name.chars().next() => {
Some(*flag)
FlagKind::Shorthand => {
if let Some(short_hand) = short {
if short_hand.to_string() == name {
return Some(*flag);
}
}
None
}
_ => None,
}

23
tests/shell/pipeline/commands/internal.rs
View file

@ -56,6 +56,29 @@ mod parse {
-r, --raw: Prints the raw value representation.
*/
#[test]
fn errors_if_flag_passed_is_not_exact() {
let actual = nu_error!(cwd: ".", "debug -ra");
assert!(
actual.contains("unexpected flag"),
format!(
"error message '{}' should contain 'unexpected flag'",
actual
)
);
let actual = nu_error!(cwd: ".", "debug --rawx");
assert!(
actual.contains("unexpected flag"),
format!(
"error message '{}' should contain 'unexpected flag'",
actual
)
);
}
#[test]
fn errors_if_flag_is_not_supported() {
let actual = nu_error!(cwd: ".", "debug --ferris");