From 030e749fe742c84dfb603f74a2fc81803f26bd1e Mon Sep 17 00:00:00 2001 From: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> Date: Thu, 24 Aug 2023 20:02:54 +0200 Subject: [PATCH] Add notice to enable develop mode on Windows (#10111) Developer mode needs to be enabled to create symlinks on Windows. Since creating symlinks is part of the testbench, this needs to be enabled. (I always wondered why two tests fail on my Windows machine, but not on the CI) --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index afdbae29b4..40cda47bbc 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -25,7 +25,7 @@ Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style -- `cargo test --workspace` to check that all tests pass +- `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note**