Keep plugins persistently running in the background (#12064)
# Description
This PR uses the new plugin protocol to intelligently keep plugin
processes running in the background for further plugin calls.
Running plugins can be seen by running the new `plugin list` command,
and stopped by running the new `plugin stop` command.
This is an enhancement for the performance of plugins, as starting new
plugin processes has overhead, especially for plugins in languages that
take a significant amount of time on startup. It also enables plugins
that have persistent state between commands, making the migration of
features like dataframes and `stor` to plugins possible.
Plugins are automatically stopped by the new plugin garbage collector,
configurable with `$env.config.plugin_gc`:
```nushell
$env.config.plugin_gc = {
# Configuration for plugin garbage collection
default: {
enabled: true # true to enable stopping of inactive plugins
stop_after: 10sec # how long to wait after a plugin is inactive to stop it
}
plugins: {
# alternate configuration for specific plugins, by name, for example:
#
# gstat: {
# enabled: false
# }
}
}
```
If garbage collection is enabled, plugins will be stopped after
`stop_after` passes after they were last active. Plugins are counted as
inactive if they have no running plugin calls. Reading the stream from
the response of a plugin call is still considered to be activity, but if
a plugin holds on to a stream but the call ends without an active
streaming response, it is not counted as active even if it is reading
it. Plugins can explicitly disable the GC as appropriate with
`engine.set_gc_disabled(true)`.
The `version` command now lists plugin names rather than plugin
commands. The list of plugin commands is accessible via `plugin list`.
Recommend doing this together with #12029, because it will likely force
plugin developers to do the right thing with mutability and lead to less
unexpected behavior when running plugins nested / in parallel.
# User-Facing Changes
- new command: `plugin list`
- new command: `plugin stop`
- changed command: `version` (now lists plugin names, rather than
commands)
- new config: `$env.config.plugin_gc`
- Plugins will keep running and be reused, at least for the configured
GC period
- Plugins that used mutable state in weird ways like `inc` did might
misbehave until fixed
- Plugins can disable GC if they need to
- Had to change plugin signature to accept `&EngineInterface` so that
the GC disable feature works. #12029 does this anyway, and I'm expecting
(resolvable) conflicts with that
# Tests + Formatting
- :green_circle: `toolkit fmt`
- :green_circle: `toolkit clippy`
- :green_circle: `toolkit test`
- :green_circle: `toolkit test stdlib`
Because there is some specific OS behavior required for plugins to not
respond to Ctrl-C directly, I've developed against and tested on both
Linux and Windows to ensure that works properly.
# After Submitting
I think this probably needs to be in the book somewhere
2024-03-09 23:10:22 +00:00
|
|
|
//! The tests in this file check the soundness of plugin persistence. When a plugin is needed by Nu,
|
|
|
|
//! it is spawned only if it was not already running. Plugins that are spawned are kept running and
|
|
|
|
//! are referenced in the engine state. Plugins can be stopped by the user if desired, but not
|
|
|
|
//! removed.
|
|
|
|
|
|
|
|
use nu_test_support::{nu, nu_with_plugins};
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_list_shows_installed_plugins() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugins: [("nu_plugin_inc"), ("nu_plugin_custom_values")],
|
|
|
|
r#"(plugin list).name | str join ','"#
|
|
|
|
);
|
|
|
|
assert_eq!("inc,custom_values", out.out);
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_keeps_running_after_calling_it() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
plugin stop inc
|
|
|
|
(plugin list).0.is_running | print
|
|
|
|
print ";"
|
|
|
|
"2.0.0" | inc -m | ignore
|
|
|
|
(plugin list).0.is_running | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert_eq!(
|
|
|
|
"false;true", out.out,
|
|
|
|
"plugin list didn't show is_running = true"
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_process_exits_after_stop() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
"2.0.0" | inc -m | ignore
|
|
|
|
let pid = (plugin list).0.pid
|
|
|
|
ps | where pid == $pid | length | print
|
|
|
|
print ";"
|
|
|
|
plugin stop inc
|
|
|
|
sleep 10ms
|
|
|
|
ps | where pid == $pid | length | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert_eq!("1;0", out.out, "plugin process did not stop running");
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_process_exits_when_nushell_exits() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
"2.0.0" | inc -m | ignore
|
|
|
|
(plugin list).0.pid | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(!out.out.is_empty());
|
|
|
|
assert!(out.status.success());
|
|
|
|
|
|
|
|
let pid = out.out.parse::<u32>().expect("failed to parse pid");
|
|
|
|
|
|
|
|
// use nu to check if process exists
|
|
|
|
assert_eq!(
|
|
|
|
"0",
|
|
|
|
nu!(format!("ps | where pid == {pid} | length")).out,
|
|
|
|
"plugin process {pid} is still running"
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_commands_run_without_error() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugins: [
|
|
|
|
("nu_plugin_inc"),
|
|
|
|
("nu_plugin_stream_example"),
|
|
|
|
("nu_plugin_custom_values"),
|
|
|
|
],
|
|
|
|
r#"
|
|
|
|
"2.0.0" | inc -m | ignore
|
|
|
|
stream_example seq 1 10 | ignore
|
|
|
|
custom-value generate | ignore
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.err.is_empty());
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_commands_run_multiple_times_without_error() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugins: [
|
|
|
|
("nu_plugin_inc"),
|
|
|
|
("nu_plugin_stream_example"),
|
|
|
|
("nu_plugin_custom_values"),
|
|
|
|
],
|
|
|
|
r#"
|
|
|
|
["2.0.0" "2.1.0" "2.2.0"] | each { inc -m } | print
|
|
|
|
stream_example seq 1 10 | ignore
|
|
|
|
custom-value generate | ignore
|
|
|
|
stream_example seq 1 20 | ignore
|
|
|
|
custom-value generate2 | ignore
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.err.is_empty());
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn multiple_plugin_commands_run_with_the_same_plugin_pid() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_custom_values"),
|
|
|
|
r#"
|
|
|
|
custom-value generate | ignore
|
|
|
|
(plugin list).0.pid | print
|
|
|
|
print ";"
|
|
|
|
custom-value generate2 | ignore
|
|
|
|
(plugin list).0.pid | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
|
|
|
|
let pids: Vec<&str> = out.out.split(';').collect();
|
|
|
|
assert_eq!(2, pids.len());
|
|
|
|
assert_eq!(pids[0], pids[1]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_pid_changes_after_stop_then_run_again() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_custom_values"),
|
|
|
|
r#"
|
|
|
|
custom-value generate | ignore
|
|
|
|
(plugin list).0.pid | print
|
|
|
|
print ";"
|
|
|
|
plugin stop custom_values
|
|
|
|
custom-value generate2 | ignore
|
|
|
|
(plugin list).0.pid | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
|
|
|
|
let pids: Vec<&str> = out.out.split(';').collect();
|
|
|
|
assert_eq!(2, pids.len());
|
|
|
|
assert_ne!(pids[0], pids[1]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn custom_values_can_still_be_passed_to_plugin_after_stop() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_custom_values"),
|
|
|
|
r#"
|
|
|
|
let cv = custom-value generate
|
|
|
|
plugin stop custom_values
|
|
|
|
$cv | custom-value update
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(!out.out.is_empty());
|
|
|
|
assert!(out.err.is_empty());
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn custom_values_can_still_be_collapsed_after_stop() {
|
|
|
|
// print causes a collapse (ToBaseValue) call.
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_custom_values"),
|
|
|
|
r#"
|
|
|
|
let cv = custom-value generate
|
|
|
|
plugin stop custom_values
|
|
|
|
$cv | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(!out.out.is_empty());
|
|
|
|
assert!(out.err.is_empty());
|
|
|
|
assert!(out.status.success());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_gc_can_be_configured_to_stop_plugins_immediately() {
|
|
|
|
// I know the test is to stop "immediately", but if we actually check immediately it could
|
|
|
|
// lead to a race condition. So there's a 1ms sleep just to be fair.
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = { default: { stop_after: 0sec } }
|
|
|
|
"2.3.0" | inc -M
|
|
|
|
sleep 1ms
|
|
|
|
(plugin list | where name == inc).0.is_running
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
assert_eq!("false", out.out, "with config as default");
|
|
|
|
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = {
|
|
|
|
plugins: {
|
|
|
|
inc: { stop_after: 0sec }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"2.3.0" | inc -M
|
|
|
|
sleep 1ms
|
|
|
|
(plugin list | where name == inc).0.is_running
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
assert_eq!("false", out.out, "with inc-specific config");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_gc_can_be_configured_to_stop_plugins_after_delay() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = { default: { stop_after: 50ms } }
|
|
|
|
"2.3.0" | inc -M
|
2024-03-11 11:01:48 +00:00
|
|
|
let start = (date now)
|
|
|
|
mut cond = true
|
|
|
|
while $cond {
|
|
|
|
sleep 100ms
|
|
|
|
$cond = (
|
|
|
|
(plugin list | where name == inc).0.is_running and
|
|
|
|
((date now) - $start) < 5sec
|
|
|
|
)
|
|
|
|
}
|
|
|
|
((date now) - $start) | into int
|
Keep plugins persistently running in the background (#12064)
# Description
This PR uses the new plugin protocol to intelligently keep plugin
processes running in the background for further plugin calls.
Running plugins can be seen by running the new `plugin list` command,
and stopped by running the new `plugin stop` command.
This is an enhancement for the performance of plugins, as starting new
plugin processes has overhead, especially for plugins in languages that
take a significant amount of time on startup. It also enables plugins
that have persistent state between commands, making the migration of
features like dataframes and `stor` to plugins possible.
Plugins are automatically stopped by the new plugin garbage collector,
configurable with `$env.config.plugin_gc`:
```nushell
$env.config.plugin_gc = {
# Configuration for plugin garbage collection
default: {
enabled: true # true to enable stopping of inactive plugins
stop_after: 10sec # how long to wait after a plugin is inactive to stop it
}
plugins: {
# alternate configuration for specific plugins, by name, for example:
#
# gstat: {
# enabled: false
# }
}
}
```
If garbage collection is enabled, plugins will be stopped after
`stop_after` passes after they were last active. Plugins are counted as
inactive if they have no running plugin calls. Reading the stream from
the response of a plugin call is still considered to be activity, but if
a plugin holds on to a stream but the call ends without an active
streaming response, it is not counted as active even if it is reading
it. Plugins can explicitly disable the GC as appropriate with
`engine.set_gc_disabled(true)`.
The `version` command now lists plugin names rather than plugin
commands. The list of plugin commands is accessible via `plugin list`.
Recommend doing this together with #12029, because it will likely force
plugin developers to do the right thing with mutability and lead to less
unexpected behavior when running plugins nested / in parallel.
# User-Facing Changes
- new command: `plugin list`
- new command: `plugin stop`
- changed command: `version` (now lists plugin names, rather than
commands)
- new config: `$env.config.plugin_gc`
- Plugins will keep running and be reused, at least for the configured
GC period
- Plugins that used mutable state in weird ways like `inc` did might
misbehave until fixed
- Plugins can disable GC if they need to
- Had to change plugin signature to accept `&EngineInterface` so that
the GC disable feature works. #12029 does this anyway, and I'm expecting
(resolvable) conflicts with that
# Tests + Formatting
- :green_circle: `toolkit fmt`
- :green_circle: `toolkit clippy`
- :green_circle: `toolkit test`
- :green_circle: `toolkit test stdlib`
Because there is some specific OS behavior required for plugins to not
respond to Ctrl-C directly, I've developed against and tested on both
Linux and Windows to ensure that works properly.
# After Submitting
I think this probably needs to be in the book somewhere
2024-03-09 23:10:22 +00:00
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
2024-03-11 11:01:48 +00:00
|
|
|
let nanos = out.out.parse::<i64>().expect("not a number");
|
|
|
|
assert!(
|
|
|
|
nanos < 5_000_000_000,
|
|
|
|
"with config as default: more than 5 seconds: {nanos} ns"
|
|
|
|
);
|
Keep plugins persistently running in the background (#12064)
# Description
This PR uses the new plugin protocol to intelligently keep plugin
processes running in the background for further plugin calls.
Running plugins can be seen by running the new `plugin list` command,
and stopped by running the new `plugin stop` command.
This is an enhancement for the performance of plugins, as starting new
plugin processes has overhead, especially for plugins in languages that
take a significant amount of time on startup. It also enables plugins
that have persistent state between commands, making the migration of
features like dataframes and `stor` to plugins possible.
Plugins are automatically stopped by the new plugin garbage collector,
configurable with `$env.config.plugin_gc`:
```nushell
$env.config.plugin_gc = {
# Configuration for plugin garbage collection
default: {
enabled: true # true to enable stopping of inactive plugins
stop_after: 10sec # how long to wait after a plugin is inactive to stop it
}
plugins: {
# alternate configuration for specific plugins, by name, for example:
#
# gstat: {
# enabled: false
# }
}
}
```
If garbage collection is enabled, plugins will be stopped after
`stop_after` passes after they were last active. Plugins are counted as
inactive if they have no running plugin calls. Reading the stream from
the response of a plugin call is still considered to be activity, but if
a plugin holds on to a stream but the call ends without an active
streaming response, it is not counted as active even if it is reading
it. Plugins can explicitly disable the GC as appropriate with
`engine.set_gc_disabled(true)`.
The `version` command now lists plugin names rather than plugin
commands. The list of plugin commands is accessible via `plugin list`.
Recommend doing this together with #12029, because it will likely force
plugin developers to do the right thing with mutability and lead to less
unexpected behavior when running plugins nested / in parallel.
# User-Facing Changes
- new command: `plugin list`
- new command: `plugin stop`
- changed command: `version` (now lists plugin names, rather than
commands)
- new config: `$env.config.plugin_gc`
- Plugins will keep running and be reused, at least for the configured
GC period
- Plugins that used mutable state in weird ways like `inc` did might
misbehave until fixed
- Plugins can disable GC if they need to
- Had to change plugin signature to accept `&EngineInterface` so that
the GC disable feature works. #12029 does this anyway, and I'm expecting
(resolvable) conflicts with that
# Tests + Formatting
- :green_circle: `toolkit fmt`
- :green_circle: `toolkit clippy`
- :green_circle: `toolkit test`
- :green_circle: `toolkit test stdlib`
Because there is some specific OS behavior required for plugins to not
respond to Ctrl-C directly, I've developed against and tested on both
Linux and Windows to ensure that works properly.
# After Submitting
I think this probably needs to be in the book somewhere
2024-03-09 23:10:22 +00:00
|
|
|
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = {
|
|
|
|
plugins: {
|
|
|
|
inc: { stop_after: 50ms }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"2.3.0" | inc -M
|
2024-03-11 11:01:48 +00:00
|
|
|
let start = (date now)
|
|
|
|
mut cond = true
|
|
|
|
while $cond {
|
|
|
|
sleep 100ms
|
|
|
|
$cond = (
|
|
|
|
(plugin list | where name == inc).0.is_running and
|
|
|
|
((date now) - $start) < 5sec
|
|
|
|
)
|
|
|
|
}
|
|
|
|
((date now) - $start) | into int
|
Keep plugins persistently running in the background (#12064)
# Description
This PR uses the new plugin protocol to intelligently keep plugin
processes running in the background for further plugin calls.
Running plugins can be seen by running the new `plugin list` command,
and stopped by running the new `plugin stop` command.
This is an enhancement for the performance of plugins, as starting new
plugin processes has overhead, especially for plugins in languages that
take a significant amount of time on startup. It also enables plugins
that have persistent state between commands, making the migration of
features like dataframes and `stor` to plugins possible.
Plugins are automatically stopped by the new plugin garbage collector,
configurable with `$env.config.plugin_gc`:
```nushell
$env.config.plugin_gc = {
# Configuration for plugin garbage collection
default: {
enabled: true # true to enable stopping of inactive plugins
stop_after: 10sec # how long to wait after a plugin is inactive to stop it
}
plugins: {
# alternate configuration for specific plugins, by name, for example:
#
# gstat: {
# enabled: false
# }
}
}
```
If garbage collection is enabled, plugins will be stopped after
`stop_after` passes after they were last active. Plugins are counted as
inactive if they have no running plugin calls. Reading the stream from
the response of a plugin call is still considered to be activity, but if
a plugin holds on to a stream but the call ends without an active
streaming response, it is not counted as active even if it is reading
it. Plugins can explicitly disable the GC as appropriate with
`engine.set_gc_disabled(true)`.
The `version` command now lists plugin names rather than plugin
commands. The list of plugin commands is accessible via `plugin list`.
Recommend doing this together with #12029, because it will likely force
plugin developers to do the right thing with mutability and lead to less
unexpected behavior when running plugins nested / in parallel.
# User-Facing Changes
- new command: `plugin list`
- new command: `plugin stop`
- changed command: `version` (now lists plugin names, rather than
commands)
- new config: `$env.config.plugin_gc`
- Plugins will keep running and be reused, at least for the configured
GC period
- Plugins that used mutable state in weird ways like `inc` did might
misbehave until fixed
- Plugins can disable GC if they need to
- Had to change plugin signature to accept `&EngineInterface` so that
the GC disable feature works. #12029 does this anyway, and I'm expecting
(resolvable) conflicts with that
# Tests + Formatting
- :green_circle: `toolkit fmt`
- :green_circle: `toolkit clippy`
- :green_circle: `toolkit test`
- :green_circle: `toolkit test stdlib`
Because there is some specific OS behavior required for plugins to not
respond to Ctrl-C directly, I've developed against and tested on both
Linux and Windows to ensure that works properly.
# After Submitting
I think this probably needs to be in the book somewhere
2024-03-09 23:10:22 +00:00
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
2024-03-11 11:01:48 +00:00
|
|
|
let nanos = out.out.parse::<i64>().expect("not a number");
|
|
|
|
assert!(
|
|
|
|
nanos < 5_000_000_000,
|
|
|
|
"with inc-specific config: more than 5 seconds: {nanos} ns"
|
|
|
|
);
|
Keep plugins persistently running in the background (#12064)
# Description
This PR uses the new plugin protocol to intelligently keep plugin
processes running in the background for further plugin calls.
Running plugins can be seen by running the new `plugin list` command,
and stopped by running the new `plugin stop` command.
This is an enhancement for the performance of plugins, as starting new
plugin processes has overhead, especially for plugins in languages that
take a significant amount of time on startup. It also enables plugins
that have persistent state between commands, making the migration of
features like dataframes and `stor` to plugins possible.
Plugins are automatically stopped by the new plugin garbage collector,
configurable with `$env.config.plugin_gc`:
```nushell
$env.config.plugin_gc = {
# Configuration for plugin garbage collection
default: {
enabled: true # true to enable stopping of inactive plugins
stop_after: 10sec # how long to wait after a plugin is inactive to stop it
}
plugins: {
# alternate configuration for specific plugins, by name, for example:
#
# gstat: {
# enabled: false
# }
}
}
```
If garbage collection is enabled, plugins will be stopped after
`stop_after` passes after they were last active. Plugins are counted as
inactive if they have no running plugin calls. Reading the stream from
the response of a plugin call is still considered to be activity, but if
a plugin holds on to a stream but the call ends without an active
streaming response, it is not counted as active even if it is reading
it. Plugins can explicitly disable the GC as appropriate with
`engine.set_gc_disabled(true)`.
The `version` command now lists plugin names rather than plugin
commands. The list of plugin commands is accessible via `plugin list`.
Recommend doing this together with #12029, because it will likely force
plugin developers to do the right thing with mutability and lead to less
unexpected behavior when running plugins nested / in parallel.
# User-Facing Changes
- new command: `plugin list`
- new command: `plugin stop`
- changed command: `version` (now lists plugin names, rather than
commands)
- new config: `$env.config.plugin_gc`
- Plugins will keep running and be reused, at least for the configured
GC period
- Plugins that used mutable state in weird ways like `inc` did might
misbehave until fixed
- Plugins can disable GC if they need to
- Had to change plugin signature to accept `&EngineInterface` so that
the GC disable feature works. #12029 does this anyway, and I'm expecting
(resolvable) conflicts with that
# Tests + Formatting
- :green_circle: `toolkit fmt`
- :green_circle: `toolkit clippy`
- :green_circle: `toolkit test`
- :green_circle: `toolkit test stdlib`
Because there is some specific OS behavior required for plugins to not
respond to Ctrl-C directly, I've developed against and tested on both
Linux and Windows to ensure that works properly.
# After Submitting
I think this probably needs to be in the book somewhere
2024-03-09 23:10:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_gc_can_be_configured_as_disabled() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = { default: { enabled: false, stop_after: 0sec } }
|
|
|
|
"2.3.0" | inc -M
|
|
|
|
(plugin list | where name == inc).0.is_running
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
assert_eq!("true", out.out, "with config as default");
|
|
|
|
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_inc"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = {
|
|
|
|
default: { enabled: true, stop_after: 0sec }
|
|
|
|
plugins: {
|
|
|
|
inc: { enabled: false, stop_after: 0sec }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"2.3.0" | inc -M
|
|
|
|
(plugin list | where name == inc).0.is_running
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
assert_eq!("true", out.out, "with inc-specific config");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_gc_can_be_disabled_by_plugin() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_example"),
|
|
|
|
r#"
|
|
|
|
nu-example-disable-gc
|
|
|
|
$env.config.plugin_gc = { default: { stop_after: 0sec } }
|
|
|
|
nu-example-1 1 foo | ignore # ensure we've run the plugin with the new config
|
|
|
|
sleep 10ms
|
|
|
|
(plugin list | where name == example).0.is_running
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
assert_eq!("true", out.out);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn plugin_gc_does_not_stop_plugin_while_stream_output_is_active() {
|
|
|
|
let out = nu_with_plugins!(
|
|
|
|
cwd: ".",
|
|
|
|
plugin: ("nu_plugin_stream_example"),
|
|
|
|
r#"
|
|
|
|
$env.config.plugin_gc = { default: { stop_after: 10ms } }
|
|
|
|
# This would exceed the configured time
|
|
|
|
stream_example seq 1 500 | each { |n| sleep 1ms; $n } | length | print
|
|
|
|
"#
|
|
|
|
);
|
|
|
|
assert!(out.status.success());
|
|
|
|
assert_eq!("500", out.out);
|
|
|
|
}
|