2023-11-29 22:21:34 +00:00
|
|
|
use nu_test_support::fs::Stub::EmptyFile;
|
2020-01-10 15:44:24 +00:00
|
|
|
use nu_test_support::playground::Playground;
|
2020-01-11 06:45:09 +00:00
|
|
|
use nu_test_support::{nu, pipeline};
|
2020-01-10 15:44:24 +00:00
|
|
|
|
|
|
|
#[test]
|
2020-01-11 06:45:09 +00:00
|
|
|
fn regular_columns() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!(pipeline(
|
2021-02-06 00:34:26 +00:00
|
|
|
r#"
|
|
|
|
echo [
|
|
|
|
[first_name, last_name, rusty_at, type];
|
2020-01-10 15:44:24 +00:00
|
|
|
|
Require that values that look like numbers parse as numberlike (#8635)
# Description
Require that any value that looks like it might be a number (starts with
a digit, or a '-' + digit, or a '+' + digits, or a special form float
like `-inf`, `inf`, or `NaN`) must now be treated as a number-like
value. Number-like syntax can only parse into number-like values.
Number-like values include: durations, ints, floats, ranges, filesizes,
binary data, etc.
# User-Facing Changes
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
Just making sure we see this for release notes 😅
This breaks any and all numberlike values that were treated as strings
before. Example, we used to allow `3,` as a bare word. Anything like
this would now require quotes or backticks to be treated as a string or
bare word, respectively.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-28 06:31:38 +00:00
|
|
|
[Andrés Robalino '10/11/2013' A]
|
|
|
|
[JT Turner '10/12/2013' B]
|
|
|
|
[Yehuda Katz '10/11/2013' A]
|
2021-02-06 00:34:26 +00:00
|
|
|
]
|
|
|
|
| select rusty_at last_name
|
2022-02-09 10:58:54 +00:00
|
|
|
| get 0
|
2021-02-06 00:34:26 +00:00
|
|
|
| get last_name
|
|
|
|
"#
|
|
|
|
));
|
2020-01-10 15:44:24 +00:00
|
|
|
|
2021-02-06 00:34:26 +00:00
|
|
|
assert_eq!(actual.out, "Robalino");
|
2020-01-10 15:44:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2020-01-11 06:45:09 +00:00
|
|
|
fn complex_nested_columns() {
|
2023-11-29 22:21:34 +00:00
|
|
|
let sample = r#"
|
2020-01-11 06:45:09 +00:00
|
|
|
{
|
|
|
|
"nu": {
|
|
|
|
"committers": [
|
|
|
|
{"name": "Andrés N. Robalino"},
|
2023-03-15 05:54:55 +00:00
|
|
|
{"name": "JT Turner"},
|
2020-01-11 06:45:09 +00:00
|
|
|
{"name": "Yehuda Katz"}
|
|
|
|
],
|
|
|
|
"releases": [
|
|
|
|
{"version": "0.2"}
|
|
|
|
{"version": "0.8"},
|
|
|
|
{"version": "0.9999999"}
|
|
|
|
],
|
|
|
|
"0xATYKARNU": [
|
|
|
|
["Th", "e", " "],
|
|
|
|
["BIG", " ", "UnO"],
|
|
|
|
["punto", "cero"]
|
|
|
|
]
|
|
|
|
}
|
|
|
|
}
|
2023-11-29 22:21:34 +00:00
|
|
|
"#;
|
2020-01-10 15:44:24 +00:00
|
|
|
|
2023-11-29 22:21:34 +00:00
|
|
|
let actual = nu!(pipeline(&format!(
|
|
|
|
r#"
|
|
|
|
{sample}
|
2020-05-07 11:03:43 +00:00
|
|
|
| select nu."0xATYKARNU" nu.committers.name nu.releases.version
|
2024-07-13 14:54:34 +00:00
|
|
|
| get "nu.releases.version"
|
2022-05-18 11:20:26 +00:00
|
|
|
| where $it > "0.8"
|
|
|
|
| get 0
|
2020-01-11 06:45:09 +00:00
|
|
|
"#
|
2023-11-29 22:21:34 +00:00
|
|
|
)));
|
2020-01-11 06:45:09 +00:00
|
|
|
|
2023-11-29 22:21:34 +00:00
|
|
|
assert_eq!(actual.out, "0.9999999");
|
2020-01-11 06:45:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2022-04-21 11:13:58 +00:00
|
|
|
fn fails_if_given_unknown_column_name() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!(pipeline(
|
2021-02-06 00:34:26 +00:00
|
|
|
r#"
|
|
|
|
echo [
|
|
|
|
[first_name, last_name, rusty_at, type];
|
2020-01-11 06:45:09 +00:00
|
|
|
|
Require that values that look like numbers parse as numberlike (#8635)
# Description
Require that any value that looks like it might be a number (starts with
a digit, or a '-' + digit, or a '+' + digits, or a special form float
like `-inf`, `inf`, or `NaN`) must now be treated as a number-like
value. Number-like syntax can only parse into number-like values.
Number-like values include: durations, ints, floats, ranges, filesizes,
binary data, etc.
# User-Facing Changes
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
Just making sure we see this for release notes 😅
This breaks any and all numberlike values that were treated as strings
before. Example, we used to allow `3,` as a bare word. Anything like
this would now require quotes or backticks to be treated as a string or
bare word, respectively.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-28 06:31:38 +00:00
|
|
|
[Andrés Robalino '10/11/2013' A]
|
|
|
|
[JT Turner '10/12/2013' B]
|
|
|
|
[Yehuda Katz '10/11/2013' A]
|
2021-02-06 00:34:26 +00:00
|
|
|
]
|
|
|
|
| select rrusty_at first_name
|
2021-03-13 21:46:40 +00:00
|
|
|
| length
|
2021-02-06 00:34:26 +00:00
|
|
|
"#
|
|
|
|
));
|
2020-01-10 15:44:24 +00:00
|
|
|
|
2022-04-21 11:13:58 +00:00
|
|
|
assert!(actual.err.contains("nu::shell::name_not_found"));
|
2020-01-10 15:44:24 +00:00
|
|
|
}
|
2020-09-29 21:00:07 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn column_names_with_spaces() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!(pipeline(
|
2021-02-06 00:34:26 +00:00
|
|
|
r#"
|
|
|
|
echo [
|
|
|
|
["first name", "last name"];
|
2020-09-29 21:00:07 +00:00
|
|
|
|
2021-02-06 00:34:26 +00:00
|
|
|
[Andrés Robalino]
|
|
|
|
[Andrés Jnth]
|
|
|
|
]
|
|
|
|
| select "last name"
|
|
|
|
| get "last name"
|
2022-09-11 08:48:27 +00:00
|
|
|
| str join " "
|
2021-02-06 00:34:26 +00:00
|
|
|
"#
|
|
|
|
));
|
2020-09-29 21:00:07 +00:00
|
|
|
|
2021-02-06 00:34:26 +00:00
|
|
|
assert_eq!(actual.out, "Robalino Jnth");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn ignores_duplicate_columns_selected() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!(pipeline(
|
2021-02-06 00:34:26 +00:00
|
|
|
r#"
|
|
|
|
echo [
|
|
|
|
["first name", "last name"];
|
|
|
|
|
|
|
|
[Andrés Robalino]
|
|
|
|
[Andrés Jnth]
|
|
|
|
]
|
|
|
|
| select "first name" "last name" "first name"
|
2022-02-22 16:32:29 +00:00
|
|
|
| columns
|
2022-09-11 08:48:27 +00:00
|
|
|
| str join " "
|
2021-02-06 00:34:26 +00:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "first name last name");
|
2020-09-29 21:00:07 +00:00
|
|
|
}
|
2022-02-09 14:59:40 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn selects_a_row() {
|
|
|
|
Playground::setup("select_test_1", |dirs, sandbox| {
|
2024-05-04 00:53:15 +00:00
|
|
|
sandbox.with_files(&[EmptyFile("notes.txt"), EmptyFile("arepas.txt")]);
|
2022-02-09 14:59:40 +00:00
|
|
|
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: dirs.test(), pipeline(
|
2023-07-21 15:32:37 +00:00
|
|
|
"
|
2022-02-09 14:59:40 +00:00
|
|
|
ls
|
|
|
|
| sort-by name
|
|
|
|
| select 0
|
|
|
|
| get name.0
|
2023-07-21 15:32:37 +00:00
|
|
|
"
|
2022-02-09 14:59:40 +00:00
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "arepas.txt");
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn selects_many_rows() {
|
|
|
|
Playground::setup("select_test_2", |dirs, sandbox| {
|
2024-05-04 00:53:15 +00:00
|
|
|
sandbox.with_files(&[EmptyFile("notes.txt"), EmptyFile("arepas.txt")]);
|
2022-02-09 14:59:40 +00:00
|
|
|
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: dirs.test(), pipeline(
|
2023-07-21 15:32:37 +00:00
|
|
|
"
|
2022-02-09 14:59:40 +00:00
|
|
|
ls
|
|
|
|
| get name
|
|
|
|
| select 1 0
|
|
|
|
| length
|
2023-07-21 15:32:37 +00:00
|
|
|
"
|
2022-02-09 14:59:40 +00:00
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "2");
|
|
|
|
});
|
|
|
|
}
|
2022-09-13 13:17:16 +00:00
|
|
|
|
|
|
|
#[test]
|
2023-01-02 22:45:43 +00:00
|
|
|
fn select_ignores_errors_successfully1() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!("[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select b? | length");
|
2022-09-13 13:17:16 +00:00
|
|
|
|
2022-12-31 11:19:10 +00:00
|
|
|
assert_eq!(actual.out, "3".to_string());
|
2022-09-13 13:17:16 +00:00
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2023-01-02 22:45:43 +00:00
|
|
|
fn select_ignores_errors_successfully2() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!("[{a: 1} {a: 2} {a: 3}] | select b? | to nuon");
|
2022-09-13 13:17:16 +00:00
|
|
|
|
Show `?` for optional entries when displaying `CellPath`s (#14042)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
This PR makes the `Display` implementation for `CellPath` show a `?`
suffix on every optional entry, which makes the output consistent with
the language syntax.
Before this PR, the printing of cell paths was confusing, e.g. `$.x` and
`$.x?` were both printed as `x`. Now, the second one is printed as `x?`.
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
The formatting of cell paths now matches the syntax used to create them,
reducing confusion.
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
All tests pass, including `stdlib` tests.
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-29 13:08:55 +00:00
|
|
|
assert_eq!(actual.out, "[[b?]; [null], [null], [null]]".to_string());
|
2022-09-13 13:17:16 +00:00
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
}
|
2022-11-09 21:57:44 +00:00
|
|
|
|
|
|
|
#[test]
|
2023-01-02 22:45:43 +00:00
|
|
|
fn select_ignores_errors_successfully3() {
|
2024-05-06 23:20:27 +00:00
|
|
|
let actual = nu!("{foo: bar} | select invalid_key? | to nuon");
|
2022-11-09 21:57:44 +00:00
|
|
|
|
Show `?` for optional entries when displaying `CellPath`s (#14042)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
This PR makes the `Display` implementation for `CellPath` show a `?`
suffix on every optional entry, which makes the output consistent with
the language syntax.
Before this PR, the printing of cell paths was confusing, e.g. `$.x` and
`$.x?` were both printed as `x`. Now, the second one is printed as `x?`.
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
The formatting of cell paths now matches the syntax used to create them,
reducing confusion.
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
All tests pass, including `stdlib` tests.
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-29 13:08:55 +00:00
|
|
|
assert_eq!(actual.out, "{invalid_key?: null}".to_string());
|
2022-11-09 21:57:44 +00:00
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2023-01-02 22:45:43 +00:00
|
|
|
fn select_ignores_errors_successfully4() {
|
2023-10-19 20:08:09 +00:00
|
|
|
let actual = nu!(
|
|
|
|
r#""key val\na 1\nb 2\n" | lines | split column --collapse-empty " " | select foo? | to nuon"#
|
|
|
|
);
|
2022-11-09 21:57:44 +00:00
|
|
|
|
Show `?` for optional entries when displaying `CellPath`s (#14042)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
This PR makes the `Display` implementation for `CellPath` show a `?`
suffix on every optional entry, which makes the output consistent with
the language syntax.
Before this PR, the printing of cell paths was confusing, e.g. `$.x` and
`$.x?` were both printed as `x`. Now, the second one is printed as `x?`.
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
The formatting of cell paths now matches the syntax used to create them,
reducing confusion.
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
All tests pass, including `stdlib` tests.
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-29 13:08:55 +00:00
|
|
|
assert_eq!(
|
|
|
|
actual.out,
|
|
|
|
r#"[[foo?]; [null], [null], [null]]"#.to_string()
|
|
|
|
);
|
2022-11-09 21:57:44 +00:00
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_failed1() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!("[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select b ");
|
2022-11-09 21:57:44 +00:00
|
|
|
|
|
|
|
assert!(actual.out.is_empty());
|
|
|
|
assert!(actual.err.contains("cannot find column"));
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_failed2() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!("[{a: 1} {a: 2} {a: 3}] | select b");
|
2022-11-09 21:57:44 +00:00
|
|
|
|
|
|
|
assert!(actual.out.is_empty());
|
|
|
|
assert!(actual.err.contains("cannot find column"));
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_failed3() {
|
2023-10-19 20:08:09 +00:00
|
|
|
let actual =
|
|
|
|
nu!(r#""key val\na 1\nb 2\n" | lines | split column --collapse-empty " " | select "100""#);
|
2022-11-09 21:57:44 +00:00
|
|
|
|
|
|
|
assert!(actual.out.is_empty());
|
|
|
|
assert!(actual.err.contains("cannot find column"));
|
|
|
|
}
|
2023-02-27 02:14:15 +00:00
|
|
|
|
|
|
|
#[test]
|
2023-09-13 11:49:55 +00:00
|
|
|
fn select_repeated_rows() {
|
|
|
|
let actual = nu!("[[a b c]; [1 2 3] [4 5 6] [7 8 9]] | select 0 0 | to nuon");
|
2023-02-27 02:14:15 +00:00
|
|
|
|
2023-09-13 11:49:55 +00:00
|
|
|
assert_eq!(actual.out, "[[a, b, c]; [1, 2, 3]]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_repeated_column() {
|
|
|
|
let actual = nu!("[[a b c]; [1 2 3] [4 5 6] [7 8 9]] | select a a | to nuon");
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[a]; [1], [4], [7]]");
|
2023-02-27 02:14:15 +00:00
|
|
|
}
|
2023-03-16 18:50:04 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn ignore_errors_works() {
|
2023-03-28 19:40:29 +00:00
|
|
|
let actual = nu!(r#"
|
2023-03-16 18:50:04 +00:00
|
|
|
let path = "foo";
|
|
|
|
[{}] | select -i $path | to nuon
|
2023-03-28 19:40:29 +00:00
|
|
|
"#);
|
2023-03-16 18:50:04 +00:00
|
|
|
|
Show `?` for optional entries when displaying `CellPath`s (#14042)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
This PR makes the `Display` implementation for `CellPath` show a `?`
suffix on every optional entry, which makes the output consistent with
the language syntax.
Before this PR, the printing of cell paths was confusing, e.g. `$.x` and
`$.x?` were both printed as `x`. Now, the second one is printed as `x?`.
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
The formatting of cell paths now matches the syntax used to create them,
reducing confusion.
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
All tests pass, including `stdlib` tests.
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-29 13:08:55 +00:00
|
|
|
assert_eq!(actual.out, "[[foo?]; [null]]");
|
2023-03-16 18:50:04 +00:00
|
|
|
}
|
2023-03-28 19:40:29 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_on_empty_list_returns_empty_list() {
|
|
|
|
// once with a List
|
|
|
|
let actual = nu!("[] | select foo | to nuon");
|
|
|
|
assert_eq!(actual.out, "[]");
|
|
|
|
|
|
|
|
// and again with a ListStream
|
|
|
|
let actual = nu!("[] | each {|i| $i} | select foo | to nuon");
|
|
|
|
assert_eq!(actual.out, "[]");
|
|
|
|
}
|
2023-08-15 12:01:45 +00:00
|
|
|
|
|
|
|
#[test]
|
2024-02-15 13:49:48 +00:00
|
|
|
fn select_columns_with_list_spread() {
|
2023-08-15 12:01:45 +00:00
|
|
|
let actual = nu!(r#"
|
|
|
|
let columns = [a c];
|
2024-02-15 13:49:48 +00:00
|
|
|
echo [[a b c]; [1 2 3]] | select ...$columns | to nuon
|
2023-08-15 12:01:45 +00:00
|
|
|
"#);
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[a, c]; [1, 3]]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2024-02-15 13:49:48 +00:00
|
|
|
fn select_rows_with_list_spread() {
|
2023-08-15 12:01:45 +00:00
|
|
|
let actual = nu!(r#"
|
|
|
|
let rows = [0 2];
|
2024-02-15 13:49:48 +00:00
|
|
|
echo [[a b c]; [1 2 3] [4 5 6] [7 8 9]] | select ...$rows | to nuon
|
2023-08-15 12:01:45 +00:00
|
|
|
"#);
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[a, b, c]; [1, 2, 3], [7, 8, 9]]");
|
|
|
|
}
|
2023-08-18 15:16:18 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_single_row_with_variable() {
|
2024-02-15 13:49:48 +00:00
|
|
|
let actual = nu!("let idx = 2; [{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select $idx | to nuon");
|
2023-08-18 15:16:18 +00:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[a]; [3]]".to_string());
|
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
}
|
2024-04-06 14:03:05 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn select_with_negative_number_errors_out() {
|
|
|
|
let actual = nu!("[1 2 3] | select (-2)");
|
|
|
|
assert!(actual.err.contains("negative number"));
|
|
|
|
}
|