2023-06-22 21:45:54 +00:00
|
|
|
use nu_cmd_base::input_handler::{operate, CmdArgument};
|
Add `command_prelude` module (#12291)
# Description
When implementing a `Command`, one must also import all the types
present in the function signatures for `Command`. This makes it so that
we often import the same set of types in each command implementation
file. E.g., something like this:
```rust
use nu_protocol::ast::Call;
use nu_protocol::engine::{Command, EngineState, Stack};
use nu_protocol::{
record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, PipelineData,
ShellError, Signature, Span, Type, Value,
};
```
This PR adds the `nu_engine::command_prelude` module which contains the
necessary and commonly used types to implement a `Command`:
```rust
// command_prelude.rs
pub use crate::CallExt;
pub use nu_protocol::{
ast::{Call, CellPath},
engine::{Command, EngineState, Stack},
record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, IntoSpanned,
PipelineData, Record, ShellError, Signature, Span, Spanned, SyntaxShape, Type, Value,
};
```
This should reduce the boilerplate needed to implement a command and
also gives us a place to track the breadth of the `Command` API. I tried
to be conservative with what went into the prelude modules, since it
might be hard/annoying to remove items from the prelude in the future.
Let me know if something should be included or excluded.
2024-03-26 21:17:30 +00:00
|
|
|
use nu_engine::command_prelude::*;
|
2022-07-06 13:25:37 +00:00
|
|
|
|
|
|
|
struct Arguments {
|
|
|
|
added_data: Vec<u8>,
|
|
|
|
index: Option<usize>,
|
|
|
|
end: bool,
|
2022-10-29 21:29:46 +00:00
|
|
|
cell_paths: Option<Vec<CellPath>>,
|
2022-07-06 13:25:37 +00:00
|
|
|
}
|
|
|
|
|
2022-10-29 21:29:46 +00:00
|
|
|
impl CmdArgument for Arguments {
|
|
|
|
fn take_cell_paths(&mut self) -> Option<Vec<CellPath>> {
|
|
|
|
self.cell_paths.take()
|
2022-07-06 13:25:37 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Clone)]
|
|
|
|
|
|
|
|
pub struct BytesAdd;
|
|
|
|
|
|
|
|
impl Command for BytesAdd {
|
|
|
|
fn name(&self) -> &str {
|
|
|
|
"bytes add"
|
|
|
|
}
|
|
|
|
|
|
|
|
fn signature(&self) -> Signature {
|
|
|
|
Signature::build("bytes add")
|
2023-07-23 18:46:53 +00:00
|
|
|
.input_output_types(vec![
|
|
|
|
(Type::Binary, Type::Binary),
|
|
|
|
(
|
|
|
|
Type::List(Box::new(Type::Binary)),
|
|
|
|
Type::List(Box::new(Type::Binary)),
|
|
|
|
),
|
2024-04-24 15:46:35 +00:00
|
|
|
(Type::table(), Type::table()),
|
|
|
|
(Type::record(), Type::record()),
|
2023-07-23 18:46:53 +00:00
|
|
|
])
|
|
|
|
.allow_variants_without_examples(true)
|
2023-12-15 06:32:37 +00:00
|
|
|
.required("data", SyntaxShape::Binary, "The binary to add.")
|
2022-07-06 13:25:37 +00:00
|
|
|
.named(
|
|
|
|
"index",
|
|
|
|
SyntaxShape::Int,
|
|
|
|
"index to insert binary data",
|
|
|
|
Some('i'),
|
|
|
|
)
|
|
|
|
.switch("end", "add to the end of binary", Some('e'))
|
|
|
|
.rest(
|
|
|
|
"rest",
|
|
|
|
SyntaxShape::CellPath,
|
2023-12-15 06:32:37 +00:00
|
|
|
"For a data structure input, add bytes to the data at the given cell paths.",
|
2022-07-06 13:25:37 +00:00
|
|
|
)
|
|
|
|
.category(Category::Bytes)
|
|
|
|
}
|
|
|
|
|
|
|
|
fn usage(&self) -> &str {
|
2023-03-01 05:33:02 +00:00
|
|
|
"Add specified bytes to the input."
|
2022-07-06 13:25:37 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
|
|
vec!["append", "truncate", "padding"]
|
|
|
|
}
|
|
|
|
|
|
|
|
fn run(
|
|
|
|
&self,
|
|
|
|
engine_state: &EngineState,
|
|
|
|
stack: &mut Stack,
|
|
|
|
call: &Call,
|
|
|
|
input: PipelineData,
|
|
|
|
) -> Result<PipelineData, ShellError> {
|
|
|
|
let added_data: Vec<u8> = call.req(engine_state, stack, 0)?;
|
2022-10-29 21:29:46 +00:00
|
|
|
let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 1)?;
|
2022-11-04 15:27:23 +00:00
|
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
2022-07-06 13:25:37 +00:00
|
|
|
let index: Option<usize> = call.get_flag(engine_state, stack, "index")?;
|
2024-01-11 15:19:48 +00:00
|
|
|
let end = call.has_flag(engine_state, stack, "end")?;
|
2022-07-06 13:25:37 +00:00
|
|
|
|
|
|
|
let arg = Arguments {
|
|
|
|
added_data,
|
|
|
|
index,
|
|
|
|
end,
|
2022-10-29 21:29:46 +00:00
|
|
|
cell_paths,
|
2022-07-06 13:25:37 +00:00
|
|
|
};
|
|
|
|
operate(add, arg, input, call.head, engine_state.ctrlc.clone())
|
|
|
|
}
|
|
|
|
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
|
|
vec![
|
|
|
|
Example {
|
|
|
|
description: "Add bytes `0x[AA]` to `0x[1F FF AA AA]`",
|
|
|
|
example: "0x[1F FF AA AA] | bytes add 0x[AA]",
|
2023-09-03 14:27:29 +00:00
|
|
|
result: Some(Value::binary(vec![0xAA, 0x1F, 0xFF, 0xAA, 0xAA],
|
|
|
|
Span::test_data(),
|
|
|
|
)),
|
2022-07-06 13:25:37 +00:00
|
|
|
},
|
|
|
|
Example {
|
|
|
|
description: "Add bytes `0x[AA BB]` to `0x[1F FF AA AA]` at index 1",
|
2023-10-05 16:45:28 +00:00
|
|
|
example: "0x[1F FF AA AA] | bytes add 0x[AA BB] --index 1",
|
2023-09-03 14:27:29 +00:00
|
|
|
result: Some(Value::binary(vec![0x1F, 0xAA, 0xBB, 0xFF, 0xAA, 0xAA],
|
|
|
|
Span::test_data(),
|
|
|
|
)),
|
2022-07-06 13:25:37 +00:00
|
|
|
},
|
|
|
|
Example {
|
|
|
|
description: "Add bytes `0x[11]` to `0x[FF AA AA]` at the end",
|
2023-10-05 16:45:28 +00:00
|
|
|
example: "0x[FF AA AA] | bytes add 0x[11] --end",
|
2023-09-03 14:27:29 +00:00
|
|
|
result: Some(Value::binary(vec![0xFF, 0xAA, 0xAA, 0x11],
|
|
|
|
Span::test_data(),
|
|
|
|
)),
|
2022-07-06 13:25:37 +00:00
|
|
|
},
|
|
|
|
Example {
|
|
|
|
description: "Add bytes `0x[11 22 33]` to `0x[FF AA AA]` at the end, at index 1(the index is start from end)",
|
2023-10-05 16:45:28 +00:00
|
|
|
example: "0x[FF AA BB] | bytes add 0x[11 22 33] --end --index 1",
|
2023-09-03 14:27:29 +00:00
|
|
|
result: Some(Value::binary(vec![0xFF, 0xAA, 0x11, 0x22, 0x33, 0xBB],
|
|
|
|
Span::test_data(),
|
|
|
|
)),
|
2022-07-06 13:25:37 +00:00
|
|
|
},
|
|
|
|
]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-10-29 21:29:46 +00:00
|
|
|
fn add(val: &Value, args: &Arguments, span: Span) -> Value {
|
2023-09-03 14:27:29 +00:00
|
|
|
let val_span = val.span();
|
2022-10-29 21:29:46 +00:00
|
|
|
match val {
|
2023-09-03 14:27:29 +00:00
|
|
|
Value::Binary { val, .. } => add_impl(val, args, val_span),
|
Standardise the use of ShellError::UnsupportedInput and ShellError::TypeMismatch and add spans to every instance of the former (#7217)
# Description
* I was dismayed to discover recently that UnsupportedInput and
TypeMismatch are used *extremely* inconsistently across the codebase.
UnsupportedInput is sometimes used for input type-checks (as per the
name!!), but *also* used for argument type-checks. TypeMismatch is also
used for both.
I thus devised the following standard: input type-checking *only* uses
UnsupportedInput, and argument type-checking *only* uses TypeMismatch.
Moreover, to differentiate them, UnsupportedInput now has *two* error
arrows (spans), one pointing at the command and the other at the input
origin, while TypeMismatch only has the one (because the command should
always be nearby)
* In order to apply that standard, a very large number of
UnsupportedInput uses were changed so that the input's span could be
retrieved and delivered to it.
* Additionally, I noticed many places where **errors are not propagated
correctly**: there are lots of `match` sites which take a Value::Error,
then throw it away and replace it with a new Value::Error with
less/misleading information (such as reporting the error as an
"incorrect type"). I believe that the earliest errors are the most
important, and should always be propagated where possible.
* Also, to standardise one broad subset of UnsupportedInput error
messages, who all used slightly different wordings of "expected
`<type>`, got `<type>`", I created OnlySupportsThisInputType as a
variant of it.
* Finally, a bunch of error sites that had "repeated spans" - i.e. where
an error expected two spans, but `call.head` was given for both - were
fixed to use different spans.
# Example
BEFORE
```
〉20b | str starts-with 'a'
Error: nu::shell::unsupported_input (link)
× Unsupported input
╭─[entry #31:1:1]
1 │ 20b | str starts-with 'a'
· ┬
· ╰── Input's type is filesize. This command only works with strings.
╰────
〉'a' | math cos
Error: nu::shell::unsupported_input (link)
× Unsupported input
╭─[entry #33:1:1]
1 │ 'a' | math cos
· ─┬─
· ╰── Only numerical values are supported, input type: String
╰────
〉0x[12] | encode utf8
Error: nu::shell::unsupported_input (link)
× Unsupported input
╭─[entry #38:1:1]
1 │ 0x[12] | encode utf8
· ───┬──
· ╰── non-string input
╰────
```
AFTER
```
〉20b | str starts-with 'a'
Error: nu::shell::pipeline_mismatch (link)
× Pipeline mismatch.
╭─[entry #1:1:1]
1 │ 20b | str starts-with 'a'
· ┬ ───────┬───────
· │ ╰── only string input data is supported
· ╰── input type: filesize
╰────
〉'a' | math cos
Error: nu::shell::pipeline_mismatch (link)
× Pipeline mismatch.
╭─[entry #2:1:1]
1 │ 'a' | math cos
· ─┬─ ────┬───
· │ ╰── only numeric input data is supported
· ╰── input type: string
╰────
〉0x[12] | encode utf8
Error: nu::shell::pipeline_mismatch (link)
× Pipeline mismatch.
╭─[entry #3:1:1]
1 │ 0x[12] | encode utf8
· ───┬── ───┬──
· │ ╰── only string input data is supported
· ╰── input type: binary
╰────
```
# User-Facing Changes
Various error messages suddenly make more sense (i.e. have two arrows
instead of one).
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-23 06:48:53 +00:00
|
|
|
// Propagate errors by explicitly matching them before the final case.
|
|
|
|
Value::Error { .. } => val.clone(),
|
2023-09-03 14:27:29 +00:00
|
|
|
other => Value::error(
|
|
|
|
ShellError::OnlySupportsThisInputType {
|
2023-03-01 19:34:48 +00:00
|
|
|
exp_input_type: "binary".into(),
|
|
|
|
wrong_type: other.get_type().to_string(),
|
|
|
|
dst_span: span,
|
2023-08-24 20:48:05 +00:00
|
|
|
src_span: other.span(),
|
2023-09-03 14:27:29 +00:00
|
|
|
},
|
2023-08-24 20:48:05 +00:00
|
|
|
span,
|
2023-09-03 14:27:29 +00:00
|
|
|
),
|
2022-10-29 21:29:46 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn add_impl(input: &[u8], args: &Arguments, span: Span) -> Value {
|
2022-07-06 13:25:37 +00:00
|
|
|
match args.index {
|
|
|
|
None => {
|
|
|
|
if args.end {
|
|
|
|
let mut added_data = args.added_data.clone();
|
|
|
|
let mut result = input.to_vec();
|
|
|
|
result.append(&mut added_data);
|
2023-09-03 14:27:29 +00:00
|
|
|
Value::binary(result, span)
|
2022-07-06 13:25:37 +00:00
|
|
|
} else {
|
|
|
|
let mut result = args.added_data.clone();
|
|
|
|
let mut input = input.to_vec();
|
|
|
|
result.append(&mut input);
|
2023-09-03 14:27:29 +00:00
|
|
|
Value::binary(result, span)
|
2022-07-06 13:25:37 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
Some(mut indx) => {
|
|
|
|
let inserted_index = if args.end {
|
|
|
|
input.len().saturating_sub(indx)
|
|
|
|
} else {
|
|
|
|
if indx > input.len() {
|
|
|
|
indx = input.len()
|
|
|
|
}
|
|
|
|
indx
|
|
|
|
};
|
|
|
|
let mut result = vec![];
|
|
|
|
let mut prev_data = input[..inserted_index].to_vec();
|
|
|
|
result.append(&mut prev_data);
|
|
|
|
let mut added_data = args.added_data.clone();
|
|
|
|
result.append(&mut added_data);
|
|
|
|
let mut after_data = input[inserted_index..].to_vec();
|
|
|
|
result.append(&mut after_data);
|
2023-09-03 14:27:29 +00:00
|
|
|
Value::binary(result, span)
|
2022-07-06 13:25:37 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use super::*;
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_examples() {
|
|
|
|
use crate::test_examples;
|
|
|
|
|
|
|
|
test_examples(BytesAdd {})
|
|
|
|
}
|
|
|
|
}
|