2022-02-08 20:57:46 +00:00
|
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn regular_columns() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!(pipeline(
|
2022-02-08 20:57:46 +00:00
|
|
|
r#"
|
|
|
|
echo [
|
|
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
|
Require that values that look like numbers parse as numberlike (#8635)
# Description
Require that any value that looks like it might be a number (starts with
a digit, or a '-' + digit, or a '+' + digits, or a special form float
like `-inf`, `inf`, or `NaN`) must now be treated as a number-like
value. Number-like syntax can only parse into number-like values.
Number-like values include: durations, ints, floats, ranges, filesizes,
binary data, etc.
# User-Facing Changes
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
Just making sure we see this for release notes 😅
This breaks any and all numberlike values that were treated as strings
before. Example, we used to allow `3,` as a bare word. Anything like
this would now require quotes or backticks to be treated as a string or
bare word, respectively.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-28 06:31:38 +00:00
|
|
|
[Andrés Robalino '10/11/2013' A]
|
|
|
|
[JT Turner '10/12/2013' B]
|
|
|
|
[Yehuda Katz '10/11/2013' A]
|
2022-02-08 20:57:46 +00:00
|
|
|
]
|
|
|
|
| reject type first_name
|
|
|
|
| columns
|
2022-09-11 08:48:27 +00:00
|
|
|
| str join ", "
|
2022-02-08 20:57:46 +00:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
2022-02-16 12:38:02 +00:00
|
|
|
assert_eq!(actual.out, "last_name, rusty_at");
|
2022-02-08 20:57:46 +00:00
|
|
|
}
|
|
|
|
|
2022-03-25 07:48:01 +00:00
|
|
|
#[test]
|
|
|
|
fn skip_cell_rejection() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!("[ {a: 1, b: 2,c:txt}, { a:val } ] | reject a | get c?.0");
|
2022-03-25 07:48:01 +00:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "txt");
|
|
|
|
}
|
|
|
|
|
2022-02-08 20:57:46 +00:00
|
|
|
#[test]
|
|
|
|
fn complex_nested_columns() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!(pipeline(
|
2022-02-08 20:57:46 +00:00
|
|
|
r#"
|
|
|
|
{
|
|
|
|
"nu": {
|
|
|
|
"committers": [
|
|
|
|
{"name": "Andrés N. Robalino"},
|
2023-03-15 05:54:55 +00:00
|
|
|
{"name": "JT Turner"},
|
2022-02-08 20:57:46 +00:00
|
|
|
{"name": "Yehuda Katz"}
|
|
|
|
],
|
|
|
|
"releases": [
|
|
|
|
{"version": "0.2"}
|
|
|
|
{"version": "0.8"},
|
|
|
|
{"version": "0.9999999"}
|
|
|
|
],
|
|
|
|
"0xATYKARNU": [
|
|
|
|
["Th", "e", " "],
|
|
|
|
["BIG", " ", "UnO"],
|
|
|
|
["punto", "cero"]
|
|
|
|
]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
| reject nu."0xATYKARNU" nu.committers
|
|
|
|
| get nu
|
|
|
|
| columns
|
2022-09-11 08:48:27 +00:00
|
|
|
| str join ", "
|
2022-02-08 20:57:46 +00:00
|
|
|
"#,
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "releases");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn ignores_duplicate_columns_rejected() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!(pipeline(
|
2022-02-08 20:57:46 +00:00
|
|
|
r#"
|
|
|
|
echo [
|
|
|
|
["first name", "last name"];
|
|
|
|
|
|
|
|
[Andrés Robalino]
|
|
|
|
[Andrés Jnth]
|
|
|
|
]
|
|
|
|
| reject "first name" "first name"
|
|
|
|
| columns
|
2022-09-11 08:48:27 +00:00
|
|
|
| str join ", "
|
2022-02-08 20:57:46 +00:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "last name");
|
|
|
|
}
|
2022-05-26 00:10:31 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_record_from_raw_eval() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!(r#"{"a": 3} | reject a | describe"#);
|
2022-05-26 00:10:31 +00:00
|
|
|
|
2022-11-20 13:22:42 +00:00
|
|
|
assert!(actual.out.contains("record"));
|
2022-05-26 00:10:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_table_from_raw_eval() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!(r#"[{"a": 3}] | reject a"#);
|
2022-05-26 00:10:31 +00:00
|
|
|
|
|
|
|
assert!(actual.out.contains("record 0 fields"));
|
|
|
|
}
|
2022-09-03 12:35:36 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_nested_field() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!("{a:{b:3,c:5}} | reject a.b | debug");
|
2022-09-03 12:35:36 +00:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "{a: {c: 5}}");
|
|
|
|
}
|
2023-03-14 22:26:48 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_two_identical_elements() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!("[[a, a]; [1, 2]] | reject a");
|
|
|
|
|
2023-03-14 22:26:48 +00:00
|
|
|
assert!(actual.out.contains("record 0 fields"));
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_large_vec_with_two_identical_elements() {
|
2023-04-28 11:25:44 +00:00
|
|
|
let actual = nu!("[[a, b, c, d, e, a]; [1323, 23, 45, 100, 2, 2423]] | reject a");
|
|
|
|
|
2023-03-14 22:26:48 +00:00
|
|
|
assert!(!actual.out.contains("1323"));
|
|
|
|
assert!(!actual.out.contains("2423"));
|
|
|
|
assert!(actual.out.contains('b'));
|
|
|
|
assert!(actual.out.contains('c'));
|
|
|
|
assert!(actual.out.contains('d'));
|
|
|
|
assert!(actual.out.contains('e'));
|
|
|
|
assert!(actual.out.contains("23"));
|
|
|
|
assert!(actual.out.contains("45"));
|
|
|
|
assert!(actual.out.contains("100"));
|
|
|
|
assert!(actual.out.contains('2'));
|
|
|
|
}
|
2023-03-31 23:40:19 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_optional_column() {
|
|
|
|
let actual = nu!("{} | reject foo? | to nuon");
|
|
|
|
assert_eq!(actual.out, "{}");
|
|
|
|
|
|
|
|
let actual = nu!("[{}] | reject foo? | to nuon");
|
|
|
|
assert_eq!(actual.out, "[{}]");
|
|
|
|
|
|
|
|
let actual = nu!("[{} {foo: 2}] | reject foo? | to nuon");
|
|
|
|
assert_eq!(actual.out, "[{}, {}]");
|
|
|
|
|
|
|
|
let actual = nu!("[{foo: 1} {foo: 2}] | reject foo? | to nuon");
|
|
|
|
assert_eq!(actual.out, "[{}, {}]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn reject_optional_row() {
|
|
|
|
let actual = nu!("[{foo: 'bar'}] | reject 3? | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[foo]; [bar]]");
|
|
|
|
}
|