Commit graph

206 commits

Author SHA1 Message Date
Aurélien Mino
74ea93381e [discogs] Use mblinks cache to seed MBIDs for artists, labels,
release-group.
2015-06-07 21:49:51 +02:00
Aurélien Mino
3f00813732 Fix seeding of artist credit MBID and add support for seeding
release-group MBID.
2015-06-07 21:48:00 +02:00
Aurélien Mino
a193e5079f [discogs] Display more MusicBrainz links:
- track artists
- labels
- "All Versions of this Release" link
2015-06-07 20:00:05 +02:00
Laurent Monin
0442f76f55 Update bandcamp importer version 2015-06-07 01:46:50 +02:00
Laurent Monin
92aa8cca37 Clarify single/track/album and related code
- track, /track/ on bandcamp, belongs to an album, not importable
- single, /track/ on bandcamp, standalone, importable
- album, /album/ on bandcamp, importable
2015-06-07 01:46:03 +02:00
Laurent Monin
ff19d2f96f parent_album -> parent_album_url 2015-06-07 01:26:56 +02:00
Laurent Monin
670074e07b Fix up album/artist links on track pages 2015-06-07 01:22:49 +02:00
Laurent Monin
67204007b8 Retrieve release info before anything else. 2015-06-07 01:20:23 +02:00
Laurent Monin
f431b89623 Store url instead of title in release.parent_album
Title is unused in itself, but the whole purpose is to differentiate single tracks vs single tracks belonging to an album.
2015-06-07 01:18:27 +02:00
Laurent Monin
e29787ecc0 Use url provided by Bandcamp in albumData instead of window.location
Provided url is cleaner.
2015-06-07 00:30:25 +02:00
Laurent Monin
166cfd57a9 Fix single import not showing regression
Bug introduced by me in 34584e7b77
2015-06-07 00:22:03 +02:00
Laurent Monin
0ed808ff11 Bump discogs and bandcamp versions 2015-06-06 13:44:05 +02:00
Laurent Monin
c152b18db5 Merge pull request #48 from zas/discogs_mblinks
Discogs importer: use mblinks
2015-06-06 13:42:26 +02:00
Laurent Monin
4bc4e9e3c8 Use latest jquery version
Old version is getting ... old.
2015-06-06 13:12:47 +02:00
Laurent Monin
138943667f Fix mb links display when navigating through pages
Pages are pjax-loaded, an event was listening for changes but due to discogsLinksMagnified attribute set in magnifyLinks(), the step was ignored (we want the links to be magnified again).
So, ignoring this attribute on triggered event is working.

I'm not sure this is the best fix for that yet.
2015-06-06 13:12:07 +02:00
Laurent Monin
e66f4c45df Fix an old issue causing the mb link to be added more than once.
Mark links as processed using an attribute.
Note: there is another old issue related to discogs page navigation, links don't always show up
2015-06-06 10:42:28 +02:00
Laurent Monin
636c9e0ca9 Display link to MB artist on master and release pages 2015-06-05 23:28:45 +02:00
Laurent Monin
3b3ea553f6 Normalize discogs artist urls 2015-06-05 23:28:09 +02:00
Laurent Monin
beef49f3e1 Drop unused variable 2015-06-05 23:26:13 +02:00
Laurent Monin
6d778043fc Discogs importer: use mblinks lib
Behavior changed slightly:
- cached entries are now refreshed after a week (tune-able)
- icons are now specific to types (release, release-group)
2015-06-05 22:17:24 +02:00
Laurent Monin
f19d8a0b0a mblinks: add a way to override link title or image for one or more types 2015-06-05 21:57:03 +02:00
Laurent Monin
b6a7eced65 mblinks: fix up release-group image source links
Issue caused by a mix up of 'release-group' and 'release_group' which remains
unseen with the bandcamp importer since it doesn't use any type with '-'.
2015-06-05 21:50:52 +02:00
Laurent Monin
5dcd552f13 Use relative paths in @require for libs 2015-06-05 20:49:23 +02:00
Laurent Monin
ddbe9ab78d Merge pull request #47 from zas/mblinks_lib
Bandcamp importer: add links to matching MB artist and releases
2015-06-05 20:47:08 +02:00
Laurent Monin
86e842e12b Merge pull request #46 from zas/subtracks_duration
Calculate total duration of sub-tracks if needed
2015-06-05 20:46:51 +02:00
Laurent Monin
3a8fef22bb searchAndDisplayMbLink(): save to cache once, after the loop 2015-06-05 17:32:11 +02:00
Laurent Monin
b7a7b0c617 searchAndDisplayMbLink(): remove check for valid type
At worse, the code will fail if an incorrect type is provided by the dev.
2015-06-05 17:26:53 +02:00
Laurent Monin
5f08654b16 Simplify initCache() 2015-06-05 17:15:04 +02:00
Laurent Monin
14179dda3f Move hardcoded musicbrainz url to a MBLinks property 2015-06-05 17:01:19 +02:00
Laurent Monin
3e16227cd9 Do '-' to '_' replacement in type once, outside the each loop 2015-06-05 16:56:37 +02:00
Laurent Monin
41c5f675cf Encode URI passed as parameter in MB ws request url 2015-06-05 16:53:15 +02:00
Laurent Monin
b306925b98 Move MBLinks js class to lib/mblinks.js, and use relative paths for @require 2015-06-05 11:13:42 +02:00
Laurent Monin
507641ee33 Bandcamp importer: add links to matching MB artist and releases
Based on the discogs importer code, but with few improvements:
- localStorage entries can expire (set to 1 week)
- code has its own namespace, and is more generic (it will move to a lib later)
- prevent jquery libs conflicts (GM vs website), jquery upgraded to 2.1.4
2015-06-05 10:39:00 +02:00
Laurent Monin
573c1d7eba CD1D importer: update version 2015-06-04 16:53:18 +02:00
Laurent Monin
7f6f2be7ee CD1D importer: use much more recent jquery version 2015-06-04 16:15:09 +02:00
Laurent Monin
aebed5afdd CD1D importer: fix a fatal typo 2015-06-04 16:13:31 +02:00
Laurent Monin
adf6c4fdca Calculate total duration of sub-tracks if needed
Tested with: http://www.discogs.com/release/1156598

Suggested by https://github.com/murdos/musicbrainz-userscripts/pull/45#issuecomment-108753443
2015-06-04 10:08:03 +02:00
Aurélien Mino
c72f353f6e Merge pull request #45 from zas/subtracks
Handle sub-tracks and their titles
2015-06-04 08:48:06 +02:00
Laurent Monin
45c0216ea0 Discogs importer: append sub-track titles to main title
If we have an index titled "A" with 2 sub-tracks "B" and "C", set the track title to "A: B / C"

Tested on http://www.discogs.com/release/5880212
2015-06-04 00:37:15 +02:00
Laurent Monin
0d4b481ac5 Merge commit 'a5138fe3d7013393c5c3f4aaea8510caaf60e40a' 2015-06-04 00:02:37 +02:00
Laurent Monin
acd9488c2e Update discogs importer version after e6adb9814a 2015-06-03 23:52:26 +02:00
Aurélien Mino
e6adb9814a Merge pull request #44 from zas/discogs_disc_titles
Discogs: import disc titles when possible
2015-06-03 19:38:14 +02:00
Laurent Monin
2e16ad5a27 Discogs: import disc titles when possible
https://github.com/murdos/musicbrainz-userscripts/issues/6
2015-06-03 17:09:38 +02:00
Laurent Monin
d00dfc4ca3 Improve style of the original image link
Open image in another tab by default (yes, i know target blank is evil).
2015-06-01 12:01:08 +02:00
Laurent Monin
66faf22f6b Merge pull request #43 from zas/hiddentracks
Bandcamp importer: better handling of hidden tracks
2015-06-01 11:03:34 +02:00
Laurent Monin
7d9c9d8ea5 Bandcamp importer: better handling of hidden tracks
Sometimes, Bandcamp album contains more tracks in the download than shown for streaming
In this case, append unknown tracks to the imported release to match the download
and remove the stream for free link (if any) as it doesn't match the whole release

This is a bit hacky since there is only one way i found to know how many tracks has the download:
- the info is from meta property description
- hidden tracks don't appear anywhere else
- no title (but sometimes artist lists them in annotations) and of course no duration
- script assumes hidden tracks are at the end of the release (which is very likely though)

Examples:
https://benfrost.bandcamp.com/album/by-the-throat
https://calicogalaxy.bandcamp.com/album/the-great-388-with-bonus-tracks
https://davyjones.bandcamp.com/album/christmas-jones-special-download-edition-w-bonus-tracks
https://theactivelistener.bandcamp.com/album/white-candles-flowers-for-delia-al009
2015-05-29 10:58:14 +02:00
Laurent Monin
4012edd162 Add @description in script headers and re-generate README.md 2015-05-28 10:26:38 +02:00
Aurélien Mino
496472415a Improve generated README to be friendlier, and less technical. 2015-05-27 21:29:19 +02:00
Laurent Monin
7cb969b327 Add README.md 2015-05-27 16:40:30 +02:00
Laurent Monin
4498e60c2f Add a python script to generate a human-readable list of user scripts 2015-05-27 16:40:06 +02:00