Mirrors/musicbrainz-userscripts
2
0
Fork 0
mirror of https://github.com/murdos/musicbrainz-userscripts synced 2024-12-13 20:02:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Simplify the logic of the date parsing func & other cleanup

Browse source
This commit is contained in:
Jesse Weinstein 2014-12-28 22:42:31 -08:00
parent e41a992a59
commit 8e8763bdcd
1 changed files with 44 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

92
batch-add-recording-relationships.user.js
View file

@ -592,25 +592,9 @@ function batch_recording_rels() {
$(".tbl > thead > tr").append("<th>Performance Attributes</th>"); $(".tbl > thead > tr").append("<th>Performance Attributes</th>");
$recordings.append( var date_element = $('<input/>')
$('<td class="bpr_attrs"></td>').append( .attr('type', "text")
$('<span class="partial">part.</span>/' + .addClass('date')
'<span class="live">live</span>/' +
'<span class="instrumental">inst.</span>/' +
'<span class="cover">cover</span>')
.css("cursor", "pointer")
.data("checked", false)
.click(function () {
var $this = $(this), checked = !$this.data("checked");
$this.data("checked", checked);
if (checked) {
$this.css({"background": "blue", "color": "white"});
} else {
$this.css({"background": "inherit", "color": "black"});
}
}), '&#160;<input type="text" class="date"/>'));
$recordings.find("td.bpr_attrs input.date")
.val("yyyy-mm-dd") .val("yyyy-mm-dd")
.css({"color": "#ddd", "width": "7em", "border": "1px #999 solid"}) .css({"color": "#ddd", "width": "7em", "border": "1px #999 solid"})
.bind("focus", function () { .bind("focus", function () {
@ -625,45 +609,57 @@ function batch_recording_rels() {
} }
}) })
.bind("input", function () { .bind("input", function () {
var error = (function ($input) { var regex_match, date = null,
return function () { error = (
function ($input) {return function () {
$input.css("border-color", "#f00"); $input.css("border-color", "#f00");
$input.parent().data("date", null); $input.parent().data("date", null);
}; date = null;
})($(this)); };})($(this)),
use_if_in_range = function (pos, type, min, max) {
var val;
if (date != null && regex_match[pos]) {
val = parseInt(regex_match[pos], 10);
if (val < min || val > max) {
error();
} else {
date[type] = val;
}
}
};
$(this).css("border-color", "#999");
if (this.value) { if (this.value) {
$(this).css("color", "#000"); $(this).css("color", "#000");
var date = this.value.match(/^([0-9]{4})(?:-([0-9]{2})(?:-([0-9]{2}))?)?$/); regex_match = this.value.match(/^([0-9]{4})(?:-([0-9]{2})(?:-([0-9]{2}))?)?$/);
if (date == null) { if (regex_match != null) {
date = {"year": parseInt(date[1], 10)};
use_if_in_range(2, 'month', 1, 12)
use_if_in_range(3, 'day', 1, 31);
} else {
error(); error();
return;
} }
var data = {}, year = date[1], month = date[2], day = date[3];
data["year"] = parseInt(year, 10);
if (month) {
month = parseInt(month, 10);
if (month < 1 || month > 12) {
error();
return;
}
data["month"] = month;
}
if (day) {
day = parseInt(day, 10);
if (day < 1 || day > 31) {
error();
return;
}
data["day"] = day;
}
$(this).parent().data("date", data);
} else {
$(this).parent().data("date", null);
} }
$(this).css("border-color", "#999"); $(this).parent().data("date", data);
}); });
$recordings.append(td(
$('<span class="partial">part.</span>/' +
'<span class="live">live</span>/' +
'<span class="instrumental">inst.</span>/' +
'<span class="cover">cover</span>')
.css("cursor", "pointer")
.data("checked", false)
.click(function () {
var checked = !$this.data("checked");
$(this).data("checked", checked)
.css({"background": checked ? "blue": "inherit",
"color": checked ? "white" : "black"});
}),
'&#160;',
date_element).addClass("bpr_attrs"));
// Style buttons // Style buttons
function style_buttons($buttons) { function style_buttons($buttons) {