Mirrors/musicbrainz-userscripts
2
0
Fork 0
mirror of https://github.com/murdos/musicbrainz-userscripts synced 2024-11-10 13:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

[discogs_importer] Fixes #16: comma after every artist.

Browse source 
Some odd/old Discogs releases have comma as ending join phrase in the
artist credit. While Discogs data is wrong, it's better to handle such
case.
This commit is contained in:
Aurélien Mino 2015-01-18 02:01:36 +01:00
parent 5424744063
commit 7890f15146
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
discogs_importer.user.js
View file

@ -1,7 +1,7 @@
// ==UserScript==
// ==UserScript==
// @name Import Discogs releases to MusicBrainz
// @version 2014.09.27.0
// @version 2015.01.18.0
// @namespace http://userscripts.org/users/22504
// @icon http://www.discogs.com/images/discogs130.png
// @downloadURL https://raw.github.com/murdos/musicbrainz-userscripts/master/discogs_importer.user.js
@ -17,6 +17,10 @@
////////////////////////////////////////////////////////////////////////////////////////////////////////
var unsafeWindow = unsafeWindow || window;
/*
* Test cases:
* - http://www.discogs.com/release/1566223 : Artist credit of tracks contains an ending ',' join phrase
*/
$(document).ready(function(){
@ -366,6 +370,10 @@ function parseDiscogsRelease(data) {
};
track.artist_credit.push(ac);
});
// Fix some odd Discogs release (e.g. http://api.discogs.com/releases/1566223) that have a ',' join phrase after the last artist
if (track.artist_credit[track.artist_credit.length-1].joinphrase == ", ") {
track.artist_credit[track.artist_credit.length-1].joinphrase = "";
}
}
// Track position and release number
@ -446,8 +454,11 @@ function decodeDiscogsJoinphrase(join) {
function mylog(obj) {
var DEBUG = true;
if (DEBUG && unsafeWindow.console) {
unsafeWindow.console.log(obj);
if (DEBUG) {
var window = unsafeWindow || window;
if (window.console) {
window.console.log(obj);
}
}
}