From a6e549471c335965b45f7b34f666f0ef7f0d8f53 Mon Sep 17 00:00:00 2001
From: Cameron Gutman <aicommander@gmail.com>
Date: Thu, 29 Aug 2024 02:14:04 -0500
Subject: [PATCH] Ignore failures when registering firewall exceptions

There appear to be bugs in the WiX firewall extension that causes errors on
install/upgrade in some scenarios (seemingly where existing fw exceptions for
Moonlight exist as in #1309).

Since a firewall exception really only provides minimal benefits for us in the
default configuration of Windows Firewall (outgoing: allow, incoming: deny) due
to WFP's stateful treatment of solicited unicast/multicast UDP traffic, let's
allow it to silently fail and not abort the whole installation.
---
 wix/Moonlight/Product.wxs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/wix/Moonlight/Product.wxs b/wix/Moonlight/Product.wxs
index 8f2ff2b9..905ad2b1 100644
--- a/wix/Moonlight/Product.wxs
+++ b/wix/Moonlight/Product.wxs
@@ -101,6 +101,7 @@
               Source="$(var.BuildDir)\app\$(var.Configuration)\Moonlight.exe">
           <fire:FirewallException Id="MoonlightFirewallException"
                                   Scope="any"
+                                  IgnoreFailure="yes"
                                   Name="$(var.FullName)" />
         </File>
       </Component>