From 8b6df34d8bf7a35e71672119dc9f2f0395a6a73d Mon Sep 17 00:00:00 2001 From: James Le Cuirot Date: Sat, 3 Jun 2023 17:51:00 +0100 Subject: [PATCH] Allow forced disabling of features instead of relying on pkg-config So-called "automagic" behaviour is considered unhelpful by distributions. A user may unintentionally build Moonlight with VDPAU support simply because they had that library installed, only for the whole application to break when they uninstall the library later. This could happen on any distribution, but it should especially be avoided on source-based distributions, where the user would not expect the package manager to encounter such issues. This commit is best viewed without whitespace changes. --- app/app.pro | 94 +++++++++++++++++++++++++++++++++-------------------- 1 file changed, 58 insertions(+), 36 deletions(-) diff --git a/app/app.pro b/app/app.pro index 82d941e7..85f38dd4 100644 --- a/app/app.pro +++ b/app/app.pro @@ -65,51 +65,73 @@ unix:!macx { CONFIG += link_pkgconfig PKGCONFIG += openssl sdl2 SDL2_ttf opus - packagesExist(libavcodec) { - PKGCONFIG += libavcodec libavutil - CONFIG += ffmpeg + !disable-ffmpeg { + packagesExist(libavcodec) { + PKGCONFIG += libavcodec libavutil + CONFIG += ffmpeg - packagesExist(libva) { - packagesExist(libva-x11) { - CONFIG += libva-x11 + !disable-libva { + packagesExist(libva) { + !disable-x11 { + packagesExist(libva-x11) { + CONFIG += libva-x11 + } + } + !disable-wayland { + packagesExist(libva-wayland) { + CONFIG += libva-wayland + } + } + !disable-libdrm { + packagesExist(libva-drm) { + CONFIG += libva-drm + } + } + CONFIG += libva + } } - packagesExist(libva-wayland) { - CONFIG += libva-wayland + + !disable-libvdpau { + packagesExist(vdpau) { + CONFIG += libvdpau + } } - packagesExist(libva-drm) { - CONFIG += libva-drm + + !disable-mmal { + packagesExist(mmal) { + PKGCONFIG += mmal + CONFIG += mmal + } + } + + !disable-libdrm { + packagesExist(libdrm) { + PKGCONFIG += libdrm + CONFIG += libdrm + } + } + + !disable-cuda { + packagesExist(ffnvcodec) { + PKGCONFIG += ffnvcodec + CONFIG += cuda + } } - CONFIG += libva } - packagesExist(vdpau) { - CONFIG += libvdpau + !disable-wayland { + packagesExist(wayland-client) { + CONFIG += wayland + PKGCONFIG += wayland-client + } } - packagesExist(mmal) { - PKGCONFIG += mmal - CONFIG += mmal + !disable-x11 { + packagesExist(x11) { + DEFINES += HAS_X11 + PKGCONFIG += x11 + } } - - packagesExist(libdrm) { - PKGCONFIG += libdrm - CONFIG += libdrm - } - - packagesExist(ffnvcodec) { - PKGCONFIG += ffnvcodec - CONFIG += cuda - } - } - - packagesExist(wayland-client) { - CONFIG += wayland - PKGCONFIG += wayland-client - } - - packagesExist(x11) { - DEFINES += HAS_X11 - PKGCONFIG += x11 } } win32 {