Mirrors/moonlight-qt
2
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-qt synced 2024-11-10 05:34:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Only block EGL rendering on Pi 4 and earlier

Browse source 
Hopefully Pi 5 is powerful enough to at least render 1080p 60 FPS.
This commit is contained in:
Cameron Gutman 2023-10-08 16:16:33 -05:00
parent 0ff9f8c55a
commit 7e4fddbe62
2 changed files with 34 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
app/streaming/video/ffmpeg-renderers/drm.cpp
View file

@ -1210,6 +1210,40 @@ bool DrmRenderer::canExportEGL() {
return false;
}
// EGL rendering is so slow on the Raspberry Pi 4 that we should basically
// never use it. It is suitable for 1080p 30 FPS on a good day, and much
// much less than that if you decide to do something crazy like stream
// in full-screen. It's nice that it at least works now on Bullseye, but
// it's so slow that we actually wish it didn't.
if (!strcmp(m_Version->name, "vc4") && qgetenv("RPI_ALLOW_EGL_RENDER") != "1") {
drmDevicePtr device;
bool matchedBadDevice = false;
if (drmGetDevice(m_DrmFd, &device) == 0) {
if (device->bustype == DRM_BUS_PLATFORM) {
for (int i = 0; device->deviceinfo.platform->compatible[i]; i++) {
QString compatibleId(device->deviceinfo.platform->compatible[i]);
if (compatibleId == "brcm,bcm2835-vc4" || compatibleId == "brcm,bcm2711-vc5") {
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"Disabling EGL rendering due to low performance on %s",
device->deviceinfo.platform->compatible[i]);
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"Set RPI_ALLOW_EGL_RENDER=1 to override");
matchedBadDevice = true;
break;
}
}
}
drmFreeDevice(&device);
}
if (matchedBadDevice) {
return false;
}
}
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"DRM backend supports exporting EGLImage");
return true;

11
app/streaming/video/ffmpeg-renderers/eglvid.cpp
View file

@ -990,17 +990,6 @@ bool EGLRenderer::testRenderFrame(AVFrame* frame)
{
EGLImage imgs[EGL_MAX_PLANES];
#ifdef HAVE_MMAL
// EGL rendering is so slow on the Raspberry Pi that we should basically
// never use it. It is suitable for 1080p 30 FPS on a good day, and much
// much less than that if you decide to do something crazy like stream
// in full-screen. It's nice that it at least works now on Bullseye, but
// it's so slow that we actually wish it didn't.
if (qgetenv("RPI_ALLOW_EGL_RENDER") != "1") {
return false;
}
#endif
// Make sure we can get working EGLImages from the backend renderer.
// Some devices (Raspberry Pi) will happily decode into DRM formats that
// its own GL implementation won't accept in eglCreateImage().