Mirrors/moonlight-qt
2
0
Fork 0
mirror of https://github.com/moonlight-stream/moonlight-qt synced 2024-12-13 21:02:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

Avoid doing non-trivial work in onCheckedChanged on settings page load

Browse source
This commit is contained in:
Cameron Gutman 2019-03-24 19:15:35 -07:00
parent 08482577eb
commit 764360c0f3
1 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
app/gui/SettingsView.qml
View file

@ -685,11 +685,15 @@ Flickable {
font.pointSize: 12 font.pointSize: 12
checked: prefs.unsupportedFps checked: prefs.unsupportedFps
onCheckedChanged: { onCheckedChanged: {
prefs.unsupportedFps = checked // This is called on init, so only do the work if we've
// actually changed the value.
if (prefs.unsupportedFps != checked) {
prefs.unsupportedFps = checked
// The selectable FPS values depend on whether // The selectable FPS values depend on whether
// this option is enabled or not // this option is enabled or not
fpsComboBox.reinitialize() fpsComboBox.reinitialize()
}
} }
} }
@ -699,16 +703,20 @@ Flickable {
font.pointSize: 12 font.pointSize: 12
checked: prefs.enableMdns checked: prefs.enableMdns
onCheckedChanged: { onCheckedChanged: {
prefs.enableMdns = checked // This is called on init, so only do the work if we've
// actually changed the value.
if (prefs.enableMdns != checked) {
prefs.enableMdns = checked
// We must save the updated preference to ensure // We must save the updated preference to ensure
// ComputerManager can observe the change internally. // ComputerManager can observe the change internally.
prefs.save() prefs.save()
// Restart polling so the mDNS change takes effect // Restart polling so the mDNS change takes effect
if (window.pollingActive) { if (window.pollingActive) {
ComputerManager.stopPollingAsync() ComputerManager.stopPollingAsync()
ComputerManager.startPolling() ComputerManager.startPolling()
}
} }
} }
} }