From 59cae610d2dbf0cad00fc9fd87803de07cd3bd35 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Tue, 25 Oct 2022 01:24:57 -0500 Subject: [PATCH] Clarify encoding resolution limit comment --- app/streaming/session.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/streaming/session.cpp b/app/streaming/session.cpp index e894c4ee..040f34af 100644 --- a/app/streaming/session.cpp +++ b/app/streaming/session.cpp @@ -797,10 +797,12 @@ bool Session::validateLaunch(SDL_Window* testWindow) emitLaunchWarning(tr("An attached gamepad has no mapping and won't be usable. Visit the Moonlight help to resolve this.")); } - // NVENC will fail to initialize when using dimensions over 4096 and H.264. + // NVENC will fail to initialize when any dimension exceeds 4096 using: + // - H.264 on all versions of NVENC + // - HEVC prior to Pascal // - // However, if we aren't using Nvidia hosting software, don't assume anything - // about H.264 capabilities by using HEVC Main10 support. It will likely be wrong. + // However, if we aren't using Nvidia hosting software, don't assume anything about + // encoding capabilities by using HEVC Main 10 support. It will likely be wrong. if ((m_StreamConfig.width > 4096 || m_StreamConfig.height > 4096) && m_Computer->isNvidiaServerSoftware) { // Pascal added support for 8K HEVC encoding support. Maxwell 2 could encode HEVC but only up to 4K. // We can't directly identify Pascal, but we can look for HEVC Main10 which was added in the same generation.