Commit graph

1574 commits

Author SHA1 Message Date
Ross Goldberg
86f916d4b5
Merge pull request #611 from rgoldberg/578-minimum-macos-10.13
Increase minimum macOS version to 10.13 & upgrade Swift to 5.7.1
2024-10-27 14:04:27 -04:00
Ross Goldberg
f83412bba1
Increase minimum macOS version to 10.13, since Swift 5.7 is already used, which requires Xcode 14+ to compile, which only supports macOS deployment targets 10.13+.
Use Swift 5.7.1, which is the newest version of Swift 5.7.

Resolve #578

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 14:01:45 -04:00
Ross Goldberg
b8194881d1
Merge pull request #610 from rgoldberg/543-help
Improve help output.
2024-10-27 12:12:41 -04:00
Ross Goldberg
52a0638f2b
Improve help output.
Make fish shell completions more consistent with the help output.

Resolve #543

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 12:09:43 -04:00
Ross Goldberg
f9ce4136e4
Restore git describe check in version.
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 07:26:46 -04:00
Ross Goldberg
e9fcf2b254
Merge branch 'main' into upstream/releases/release-1.8.7
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>

# Manual Merge Cleanup:
#	.actrc
#	.github/workflows/pr-checks.yml
#	.github/workflows/release.yml
#	Brewfile
#	script/test
#	script/version_bump

# Conflicts:
#	.github/workflows/build-test.yml
#	.gitignore
#	.swiftlint.yml
#	Brewfile.lock.json
#	Package.resolved
#	Sources/mas/Package.swift
#	Tests/masTests/.swiftlint.yml
#	script/bootstrap
#	script/build
#	script/format
#	script/lint
#	script/uninstall
#	script/version
2024-10-27 01:25:38 -04:00
Ben Chatelain
8bbf5525b4
🔨 Use MAS_VERSION in root_url 2024-10-26 15:08:06 -06:00
Ben Chatelain
64961e7c81
🔨 Fix root_url replacement syntax 2024-10-26 15:03:46 -06:00
Ben Chatelain
7ecbf60fb8
🔨 Update version in root_url 2024-10-26 14:57:33 -06:00
Ben Chatelain
3332773c1b
🔊 Echo commands in bottle script 2024-10-26 14:23:59 -06:00
Ben Chatelain
635898dd18
🔨 Change style to use file path
Removed brew list command as that only works with installed formulae
2024-10-26 14:23:10 -06:00
Ben Chatelain
a1a9a9d441
🚨 Resolve brew style lint offenses 2024-10-26 14:21:28 -06:00
Ben Chatelain
5b8fed8bee
🔨 Remove install and enhance audit command 2024-10-26 14:07:17 -06:00
Ross Goldberg
a256832b78
Merge pull request #601 from rgoldberg/597-formatted-price
Use `formattedPrice` for prices
2024-10-26 02:23:47 -04:00
Ross Goldberg
fd051eac1f
Require fileSizeBytes & price for SearchResult.
Resolve #597

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-26 02:17:08 -04:00
Ross Goldberg
1b4c97f652
Use formattedPrice instead of price.
Improve price output.

Partial #597

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-26 02:17:07 -04:00
Ross Goldberg
12832f293d
Merge pull request #600 from rgoldberg/585-naming
Improve naming
2024-10-25 23:44:08 -04:00
Ross Goldberg
880843d8e6
Rename *Mock as Mock*.
Resolve #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 23:39:52 -04:00
Ross Goldberg
cc219fe644
Rename MasAppLibrary as SoftwareMapAppLibrary.
Rename `AppLibraryMock` as `MockAppLibrary`.

Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:20 -04:00
Ross Goldberg
d7072fc66d
Rename *StoreSearch as *AppStoreSearcher.
Rename `MasStoreSearch` as `ITunesSearchAppStoreSearcher`.

Rename `StoreSearchMock` as `MockAppStoreSearcher`.

Rename variables/parameters of the above types as `searcher`.

Fix 'App Store.app' mention in help.

Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:20 -04:00
Ross Goldberg
ab22e22ace
Rename Mas as MAS.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:20 -04:00
Ross Goldberg
6bf5696093
Chop down multiline guard clauses.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:19 -04:00
Ross Goldberg
59a642590a
Rename some uses of *Url as *URL.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:14 -04:00
Ross Goldberg
0b11f3737c
Rename some uses of appName as searchTerm.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:51:07 -04:00
Ross Goldberg
0e49da7bf1
Rename *bundleId as *bundleID.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:51:07 -04:00
Ross Goldberg
3a5593c12d
Rename *accountId & username as *appleID.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:51:07 -04:00
Ross Goldberg
2eeff82f11
Merge pull request #599 from rgoldberg/313-uninstall
Fix `uninstall`
2024-10-25 22:49:33 -04:00
Ross Goldberg
98c85ac6d6
Delete apps via Scripting Bridge to Finder.
Resolve #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
53c64b1758
Improve errors.
Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
06ee9608be
Improve output.
Improve errors.

Simplify code.

Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
b0d2f23465
Add appID parameter to MASError.notInstalled().
Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
222646159d
Refactor AppLibrary.installedApp(…) as AppLibrary.installedApps(…)
because multiple installed apps can have the same app ID or app name.

Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:02 -04:00
Ross Goldberg
4e0a471d81
Remove unnecessary function from AppLibrary.
Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:01 -04:00
Ross Goldberg
6b27d516e9
Merge pull request #595 from rgoldberg/594-github-runners-macos-15
Improve GitHub runners
2024-10-24 07:54:00 -04:00
Ross Goldberg
cab684ba60
Install swiftlint via Brewfile if macOS >= 13 (install breaks on macOS <= 12).
Only install `peripheryapp/periphery` tap if macOS >= 13 (install breaks on macOS <= 12).

Resolve #594

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-24 07:49:43 -04:00
Ross Goldberg
9e3b079ec8
Update lint.
- Change Swift bird emoji to ensure consistent spacing.

- Suppress output on GitHub runners.

- Simplify `grep` patterns.

Partial #594

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-24 07:46:50 -04:00
Ross Goldberg
417fb824b4
Upgrade GitHub runners from macos-14 to macos-15.
Resolve #594

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 07:56:23 -04:00
Ross Goldberg
bb67ea5e48
Merge pull request #593 from rgoldberg/592-lint-cleanup
Additional linting / cleanup code
2024-10-23 06:23:46 -04:00
Ross Goldberg
c36a797ac2
SwiftLint
opt_in_rules:
- all

Resolve #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
4d4dd02cd3
Improve lint configurations.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
2edd21803b
Improve unwrapping.
Cleanup code.

Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
87aaba555d
Remove unnecessary variable type.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
ee28af69df
Eliminate magic numbers.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
fcf8ba29f6
Improve error output.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
65218eff74
Comment that catch ignores error.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
3a6d6724c9
Reorder elements.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:33 -04:00
Ross Goldberg
2af2a42a88
Improve parameter names.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:33 -04:00
Ross Goldberg
586de07389
Improve access control.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:33 -04:00
Ross Goldberg
490ee2d338
Fix class names.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:33 -04:00
Ross Goldberg
e927466dce
Use Self.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:33 -04:00